Re: em28xx breaks after hibernate

2014-09-28 Thread Mauro Carvalho Chehab
Em Sun, 28 Sep 2014 13:54:05 +0200 Johannes Stezenbach escreveu: > On Sun, Sep 28, 2014 at 08:12:11AM -0300, Mauro Carvalho Chehab wrote: > > Em Sun, 28 Sep 2014 12:55:40 +0200 > > Johannes Stezenbach escreveu: > > > > > I tried again both with and without the patch. The issue above > > > odes

Re: em28xx breaks after hibernate

2014-09-28 Thread Mauro Carvalho Chehab
Em Sun, 28 Sep 2014 13:54:05 +0200 Johannes Stezenbach escreveu: > On Sun, Sep 28, 2014 at 08:12:11AM -0300, Mauro Carvalho Chehab wrote: > > Em Sun, 28 Sep 2014 12:55:40 +0200 > > Johannes Stezenbach escreveu: > > > > > I tried again both with and without the patch. The issue above > > > odes

Re: em28xx breaks after hibernate

2014-09-28 Thread Mauro Carvalho Chehab
Em Sun, 28 Sep 2014 13:54:05 +0200 Johannes Stezenbach escreveu: > On Sun, Sep 28, 2014 at 08:12:11AM -0300, Mauro Carvalho Chehab wrote: > > Em Sun, 28 Sep 2014 12:55:40 +0200 > > Johannes Stezenbach escreveu: > > > > > I tried again both with and without the patch. The issue above > > > odes

Re: em28xx breaks after hibernate

2014-09-28 Thread Johannes Stezenbach
On Sun, Sep 28, 2014 at 08:12:11AM -0300, Mauro Carvalho Chehab wrote: > Em Sun, 28 Sep 2014 12:55:40 +0200 > Johannes Stezenbach escreveu: > > > I tried again both with and without the patch. The issue above > > odesn't reproduce, but after hibernate it fails to tune > > (while it works after s

Re: em28xx breaks after hibernate

2014-09-28 Thread Mauro Carvalho Chehab
Em Sun, 28 Sep 2014 12:55:40 +0200 Johannes Stezenbach escreveu: > On Fri, Sep 26, 2014 at 12:43:09PM -0300, Mauro Carvalho Chehab wrote: > > Em Fri, 26 Sep 2014 17:22:28 +0200 > > Johannes Stezenbach escreveu: > > > > > On Fri, Sep 26, 2014 at 05:06:02PM +0200, Johannes Stezenbach wrote: > > >

Re: em28xx breaks after hibernate

2014-09-28 Thread Johannes Stezenbach
On Fri, Sep 26, 2014 at 12:43:09PM -0300, Mauro Carvalho Chehab wrote: > Em Fri, 26 Sep 2014 17:22:28 +0200 > Johannes Stezenbach escreveu: > > > On Fri, Sep 26, 2014 at 05:06:02PM +0200, Johannes Stezenbach wrote: > > > > > > [ 20.212162] usb 1-1: reset high-speed USB device number 2 using >

Re: em28xx breaks after hibernate

2014-09-26 Thread Mauro Carvalho Chehab
Em Fri, 26 Sep 2014 17:42:27 +0200 Johannes Stezenbach escreveu: > On Fri, Sep 26, 2014 at 09:22:53AM -0600, Shuah Khan wrote: > > > > > > [ 20.212162] usb 1-1: reset high-speed USB device number 2 using > > > ehci-pci > > > [ 20.503868] em2884 #0: Resuming extensions > > > [ 20.505275] e

Re: em28xx breaks after hibernate

2014-09-26 Thread Mauro Carvalho Chehab
Em Fri, 26 Sep 2014 17:22:28 +0200 Johannes Stezenbach escreveu: > On Fri, Sep 26, 2014 at 05:06:02PM +0200, Johannes Stezenbach wrote: > > On Fri, Sep 26, 2014 at 08:30:32AM -0600, Shuah Khan wrote: > > > On 09/26/2014 08:25 AM, Johannes Stezenbach wrote: > > > > > > > > So, what is happening i

Re: em28xx breaks after hibernate

2014-09-26 Thread Johannes Stezenbach
On Fri, Sep 26, 2014 at 09:22:53AM -0600, Shuah Khan wrote: > > > > [ 20.212162] usb 1-1: reset high-speed USB device number 2 using ehci-pci > > [ 20.503868] em2884 #0: Resuming extensions > > [ 20.505275] em2884 #0: Resuming video extensionem2884 #0: Resuming DVB > > extension > > [ 20.

Re: em28xx breaks after hibernate

2014-09-26 Thread Mauro Carvalho Chehab
Em Fri, 26 Sep 2014 09:22:53 -0600 Shuah Khan escreveu: > On 09/26/2014 09:06 AM, Johannes Stezenbach wrote: > > On Fri, Sep 26, 2014 at 08:30:32AM -0600, Shuah Khan wrote: > >> On 09/26/2014 08:25 AM, Johannes Stezenbach wrote: > >>> > >>> So, what is happening is that the em28xx driver still as

Re: em28xx breaks after hibernate

2014-09-26 Thread Mauro Carvalho Chehab
Em Fri, 26 Sep 2014 09:22:53 -0600 Shuah Khan escreveu: > On 09/26/2014 09:06 AM, Johannes Stezenbach wrote: > > On Fri, Sep 26, 2014 at 08:30:32AM -0600, Shuah Khan wrote: > >> On 09/26/2014 08:25 AM, Johannes Stezenbach wrote: > >>> > >>> So, what is happening is that the em28xx driver still as

Re: em28xx breaks after hibernate

2014-09-26 Thread Shuah Khan
On 09/26/2014 09:06 AM, Johannes Stezenbach wrote: > On Fri, Sep 26, 2014 at 08:30:32AM -0600, Shuah Khan wrote: >> On 09/26/2014 08:25 AM, Johannes Stezenbach wrote: >>> >>> So, what is happening is that the em28xx driver still async initializes >>> while the initramfs already has started resume.

Re: em28xx breaks after hibernate

2014-09-26 Thread Johannes Stezenbach
On Fri, Sep 26, 2014 at 05:06:02PM +0200, Johannes Stezenbach wrote: > On Fri, Sep 26, 2014 at 08:30:32AM -0600, Shuah Khan wrote: > > On 09/26/2014 08:25 AM, Johannes Stezenbach wrote: > > > > > > So, what is happening is that the em28xx driver still async initializes > > > while the initramfs al

Re: em28xx breaks after hibernate

2014-09-26 Thread Johannes Stezenbach
On Fri, Sep 26, 2014 at 08:30:32AM -0600, Shuah Khan wrote: > On 09/26/2014 08:25 AM, Johannes Stezenbach wrote: > > > > So, what is happening is that the em28xx driver still async initializes > > while the initramfs already has started resume. Thus the rootfs in not > > mounted and the firmware

Re: em28xx breaks after hibernate

2014-09-26 Thread Shuah Khan
On 09/26/2014 08:25 AM, Johannes Stezenbach wrote: > On Fri, Sep 26, 2014 at 03:25:13PM +0200, Johannes Stezenbach wrote: >> >> (snipped some irrelevant part of resume) > > Looking closer, I snipped too much: > > [1.646784] Freeing unused kernel memory: 1080K (8800018f2000 - > 880001

Re: em28xx breaks after hibernate

2014-09-26 Thread Johannes Stezenbach
On Fri, Sep 26, 2014 at 03:25:13PM +0200, Johannes Stezenbach wrote: > > (snipped some irrelevant part of resume) Looking closer, I snipped too much: [1.646784] Freeing unused kernel memory: 1080K (8800018f2000 - 880001a0) Loading, please wait... [1.655328] busybox (67) used

Re: em28xx breaks after hibernate

2014-09-26 Thread Shuah Khan
On 09/26/2014 07:25 AM, Johannes Stezenbach wrote: > On Fri, Sep 26, 2014 at 10:12:22AM -0300, Mauro Carvalho Chehab wrote: >> Try to add a WARN_ON or printk at em28xx_usb_resume(). > > It is called two times, once during hibernate and once during resume: > > root@debian:~# echo disk >/sys/power

Re: em28xx breaks after hibernate

2014-09-26 Thread Johannes Stezenbach
On Fri, Sep 26, 2014 at 10:12:22AM -0300, Mauro Carvalho Chehab wrote: > Try to add a WARN_ON or printk at em28xx_usb_resume(). It is called two times, once during hibernate and once during resume: root@debian:~# echo disk >/sys/power/state [ 107.108149] PM: Syncing filesystems ... done. [ 107.

Re: em28xx breaks after hibernate

2014-09-26 Thread Mauro Carvalho Chehab
Em Fri, 26 Sep 2014 14:27:21 +0200 Johannes Stezenbach escreveu: > On Fri, Sep 26, 2014 at 09:03:16AM -0300, Mauro Carvalho Chehab wrote: > > > > The patch I sent you (or some fixed version of it) is part of the > > solution, but this still bothers me: > > > > > > [3.776854] [] drxk_attach

Re: em28xx breaks after hibernate

2014-09-26 Thread Johannes Stezenbach
On Fri, Sep 26, 2014 at 09:03:16AM -0300, Mauro Carvalho Chehab wrote: > > The patch I sent you (or some fixed version of it) is part of the > solution, but this still bothers me: > > > > [3.776854] [] drxk_attach+0x546/0x656 > > > [3.777675] [] em28xx_dvb_init.part.3+0xa3e/0x1cdf > > >

Re: em28xx breaks after hibernate

2014-09-26 Thread Mauro Carvalho Chehab
Em Fri, 26 Sep 2014 14:02:33 +0200 Johannes Stezenbach escreveu: > On Fri, Sep 26, 2014 at 08:42:15AM -0300, Mauro Carvalho Chehab wrote: > > Could you please try this patch (untested): > > > > [media] drxk: load firmware again at resume > > No joy. I think you need to keep the firmware around

Re: em28xx breaks after hibernate

2014-09-26 Thread Mauro Carvalho Chehab
Em Fri, 26 Sep 2014 08:42:15 -0300 Mauro Carvalho Chehab escreveu: > Em Fri, 26 Sep 2014 13:07:27 +0200 > Johannes Stezenbach escreveu: > > > Hi Mauro, > > > > On Fri, Sep 26, 2014 at 07:14:11AM -0300, Mauro Carvalho Chehab wrote: > > > > > > I just pushed the pending patched and added a reve

Re: em28xx breaks after hibernate

2014-09-26 Thread Johannes Stezenbach
On Fri, Sep 26, 2014 at 08:42:15AM -0300, Mauro Carvalho Chehab wrote: > Could you please try this patch (untested): > > [media] drxk: load firmware again at resume No joy. I think you need to keep the firmware around for reuse after resume instead of requesting it again. [2.521597] PM: Ima

Re: em28xx breaks after hibernate

2014-09-26 Thread Mauro Carvalho Chehab
Em Fri, 26 Sep 2014 13:07:27 +0200 Johannes Stezenbach escreveu: > Hi Mauro, > > On Fri, Sep 26, 2014 at 07:14:11AM -0300, Mauro Carvalho Chehab wrote: > > > > I just pushed the pending patched and added a reverted patch for > > b89193e0b06f at the media_tree.git. Could you please use it to com

Re: em28xx breaks after hibernate

2014-09-26 Thread Johannes Stezenbach
Hi Mauro, On Fri, Sep 26, 2014 at 07:14:11AM -0300, Mauro Carvalho Chehab wrote: > > I just pushed the pending patched and added a reverted patch for > b89193e0b06f at the media_tree.git. Could you please use it to compile > or, if you prefer to keep using 3.16, you can use the media_build.git[1]

Re: em28xx breaks after hibernate

2014-09-26 Thread Mauro Carvalho Chehab
Hi Johannes/Shuah, Em Fri, 26 Sep 2014 10:08:24 +0200 Johannes Stezenbach escreveu: > On Fri, Sep 26, 2014 at 10:00:30AM +0200, Johannes Stezenbach wrote: > > On Thu, Sep 25, 2014 at 12:45:24PM -0600, Shuah Khan wrote: > > > > > > Revert is good. Just checked 3.16 and we are good > > > on that.

Re: em28xx breaks after hibernate

2014-09-26 Thread Johannes Stezenbach
On Fri, Sep 26, 2014 at 10:00:30AM +0200, Johannes Stezenbach wrote: > On Thu, Sep 25, 2014 at 12:45:24PM -0600, Shuah Khan wrote: > > > > Revert is good. Just checked 3.16 and we are good > > on that. It needs to be reverted from 3.17 for sure. > > > > ok now I know why the second path didn't >

Re: em28xx breaks after hibernate

2014-09-26 Thread Johannes Stezenbach
On Thu, Sep 25, 2014 at 12:45:24PM -0600, Shuah Khan wrote: > > Revert is good. Just checked 3.16 and we are good > on that. It needs to be reverted from 3.17 for sure. > > ok now I know why the second path didn't > apply. It depends on another change that added resume > function > > 7ab1c07614b

Re: em28xx breaks after hibernate

2014-09-26 Thread Johannes Stezenbach
Hi Shuah, On Thu, Sep 25, 2014 at 01:03:30PM -0600, Shuah Khan wrote: > On 09/25/2014 12:45 PM, Shuah Khan wrote: > > > ok now I know why the second path didn't > > apply. It depends on another change that added resume > > function > > > > 7ab1c07614b984778a808dc22f84b682fedefea1 > > > > You do

Re: em28xx breaks after hibernate

2014-09-25 Thread Shuah Khan
Hi Johannes and Mauro, On 09/25/2014 12:45 PM, Shuah Khan wrote: >> > > Revert is good. Just checked 3.16 and we are good > on that. It needs to be reverted from 3.17 for sure. Mauro! Do you need anything from me for this revert? Please let me know. Gotta be done soon I am guessing with us so c

Re: em28xx breaks after hibernate

2014-09-25 Thread Shuah Khan
On 09/25/2014 12:17 PM, Johannes Stezenbach wrote: > On Thu, Sep 25, 2014 at 11:40:45AM -0600, Shuah Khan wrote: >> >> Right. I introduced DVB_FE_DEVICE_RESUME code to resume >> problems in drx39xxj driver. Because I had to make it not >> toggle power on the fe for resume. In other words, for it >>

Re: em28xx breaks after hibernate

2014-09-25 Thread Johannes Stezenbach
On Thu, Sep 25, 2014 at 11:40:45AM -0600, Shuah Khan wrote: > > Right. I introduced DVB_FE_DEVICE_RESUME code to resume > problems in drx39xxj driver. Because I had to make it not > toggle power on the fe for resume. In other words, for it > to differentiate between disconnect and resume condition

Re: em28xx breaks after hibernate

2014-09-25 Thread Shuah Khan
Hi Johannes, On 09/25/2014 11:36 AM, Johannes Stezenbach wrote: > On Thu, Sep 25, 2014 at 06:01:34PM +0200, Johannes Stezenbach wrote: > FWIW, there are six other xc5000 patches in the queue: > > http://git.linuxtv.org/cgit.cgi/media_tree.git/log/drivers/media/tuners/xc5000.c?h=devel-3.17-rc6 >

Re: em28xx breaks after hibernate

2014-09-25 Thread Shuah Khan
On 09/25/2014 10:01 AM, Johannes Stezenbach wrote: > Hi Shuah, > > On Thu, Sep 25, 2014 at 07:45:37AM -0600, Shuah Khan wrote: >> On 09/25/2014 06:53 AM, Johannes Stezenbach wrote: >>> ever since your patchset which implements suspend/resume >>> for em28xx, hibernating the system breaks the Hauppa

Re: em28xx breaks after hibernate

2014-09-25 Thread Johannes Stezenbach
On Thu, Sep 25, 2014 at 06:01:34PM +0200, Johannes Stezenbach wrote: > Hi Shuah, > > On Thu, Sep 25, 2014 at 07:45:37AM -0600, Shuah Khan wrote: > > On 09/25/2014 06:53 AM, Johannes Stezenbach wrote: > > > ever since your patchset which implements suspend/resume > > > for em28xx, hibernating the s

Re: em28xx breaks after hibernate

2014-09-25 Thread Johannes Stezenbach
Hi Shuah, On Thu, Sep 25, 2014 at 07:45:37AM -0600, Shuah Khan wrote: > On 09/25/2014 06:53 AM, Johannes Stezenbach wrote: > > ever since your patchset which implements suspend/resume > > for em28xx, hibernating the system breaks the Hauppauge WinTV HVR 930C > > driver. > > In v3.15.y and v3.16.y

Re: em28xx breaks after hibernate

2014-09-25 Thread Shuah Khan
On 09/25/2014 08:10 AM, Mauro Carvalho Chehab wrote: > Hi Johannes and Shuah, > > Em Thu, 25 Sep 2014 07:45:37 -0600 > Shuah Khan escreveu: > >> Hi Johannes, >> >> On 09/25/2014 06:53 AM, Johannes Stezenbach wrote: >>> Hi Shuah, >>> >>> ever since your patchset which implements suspend/resume >>

Re: em28xx breaks after hibernate

2014-09-25 Thread Mauro Carvalho Chehab
Hi Johannes and Shuah, Em Thu, 25 Sep 2014 07:45:37 -0600 Shuah Khan escreveu: > Hi Johannes, > > On 09/25/2014 06:53 AM, Johannes Stezenbach wrote: > > Hi Shuah, > > > > ever since your patchset which implements suspend/resume > > for em28xx, hibernating the system breaks the Hauppauge WinTV

Re: em28xx breaks after hibernate

2014-09-25 Thread Shuah Khan
Hi Johannes, On 09/25/2014 06:53 AM, Johannes Stezenbach wrote: > Hi Shuah, > > ever since your patchset which implements suspend/resume > for em28xx, hibernating the system breaks the Hauppauge WinTV HVR 930C driver. > In v3.15.y and v3.16.y it throws a request_firmware warning > during hibernat

em28xx breaks after hibernate

2014-09-25 Thread Johannes Stezenbach
Hi Shuah, ever since your patchset which implements suspend/resume for em28xx, hibernating the system breaks the Hauppauge WinTV HVR 930C driver. In v3.15.y and v3.16.y it throws a request_firmware warning during hibernate + resume, and the /dev/dvb/ device nodes disappears after resume. In curre