Re: [REVIEW PATCH] em28xx: fix bytesperline calculation in TRY_FMT

2013-02-06 Thread Frank Schäfer
Am 06.02.2013 13:14, schrieb Hans Verkuil: > From: Hans Verkuil > > The bytesperline calculation was incorrect: it used the old width instead of > the provided width. Fixed. > > Signed-off-by: Hans Verkuil > --- > drivers/media/usb/em28xx/em28xx-video.c |2 +- > 1 file changed, 1 insertion(+

[REVIEW PATCH] em28xx: fix bytesperline calculation in TRY_FMT

2013-02-06 Thread Hans Verkuil
From: Hans Verkuil The bytesperline calculation was incorrect: it used the old width instead of the provided width. Fixed. Signed-off-by: Hans Verkuil --- drivers/media/usb/em28xx/em28xx-video.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/usb/em28xx/em2

em28xx: fix bytesperline calculation in TRY_FMT

2013-02-06 Thread Hans Verkuil
Compared to the previous patch I've removed the calculation change (I still think it is wrong, but this needs to be considered in a wider perspective). But the more obvious problem where the current width instead of the one provided by the application is used still needed to be fixed, which is don

Re: [RFC PATCH] em28xx: fix bytesperline calculation in TRY_FMT

2013-01-29 Thread Mauro Carvalho Chehab
Em Tue, 29 Jan 2013 19:21:50 +0100 Hans Verkuil escreveu: > On Tue January 29 2013 18:51:46 Frank Schäfer wrote: > > Am 29.01.2013 10:49, schrieb Hans Verkuil: > > > This was part of my original em28xx patch series. That particular patch > > > combined two things: this fix and the change where TR

Re: [RFC PATCH] em28xx: fix bytesperline calculation in TRY_FMT

2013-01-29 Thread Hans Verkuil
On Tue January 29 2013 18:51:46 Frank Schäfer wrote: > Am 29.01.2013 10:49, schrieb Hans Verkuil: > > This was part of my original em28xx patch series. That particular patch > > combined two things: this fix and the change where TRY_FMT would no > > longer return -EINVAL for unsupported pixelformat

Re: [RFC PATCH] em28xx: fix bytesperline calculation in TRY_FMT

2013-01-29 Thread Frank Schäfer
Am 29.01.2013 10:49, schrieb Hans Verkuil: > This was part of my original em28xx patch series. That particular patch > combined two things: this fix and the change where TRY_FMT would no > longer return -EINVAL for unsupported pixelformats. The latter change was > rejected (correctly), but we all f

Re: [RFC PATCH] em28xx: fix bytesperline calculation in TRY_FMT

2013-01-29 Thread Devin Heitmueller
On Tue, Jan 29, 2013 at 4:49 AM, Hans Verkuil wrote: > This was part of my original em28xx patch series. That particular patch > combined two things: this fix and the change where TRY_FMT would no > longer return -EINVAL for unsupported pixelformats. The latter change was > rejected (correctly), b

[RFC PATCH] em28xx: fix bytesperline calculation in TRY_FMT

2013-01-29 Thread Hans Verkuil
This was part of my original em28xx patch series. That particular patch combined two things: this fix and the change where TRY_FMT would no longer return -EINVAL for unsupported pixelformats. The latter change was rejected (correctly), but we all forgot about the second part of the patch which fixe