[PATCH v4 04/21] rockchip/vpu: Cleanup JPEG bounce buffer management

2019-04-25 Thread Boris Brezillon
From: Ezequiel Garcia In order to make the code more generic, introduce a pair of start/stop codec operations, and use them to allocate and release the JPEG bounce buffer. Signed-off-by: Ezequiel Garcia Signed-off-by: Boris Brezillon --- Changes from v3: * None Changes from v2: * Reword boun

[PATCH v3 04/15] rockchip/vpu: Cleanup JPEG bounce buffer management

2019-04-22 Thread Boris Brezillon
From: Ezequiel Garcia In order to make the code more generic, introduce a pair of start/stop codec operations, and use them to allocate and release the JPEG bounce buffer. Signed-off-by: Ezequiel Garcia Signed-off-by: Boris Brezillon --- Changes from v2: * Reword bounce buffer comment, so it'

Re: [PATCH v2 06/11] rockchip/vpu: Cleanup JPEG bounce buffer management

2019-03-28 Thread Tomasz Figa
On Fri, Mar 29, 2019 at 3:30 AM Ezequiel Garcia wrote: > > On Thu, 2019-03-28 at 15:15 +0900, Tomasz Figa wrote: > > Hi Ezequiel, > > > > On Tue, Mar 5, 2019 at 4:26 AM Ezequiel Garcia > > wrote: > > > In order to make the code more generic, introduce a pair of start/stop > > > codec operations,

Re: [PATCH v2 06/11] rockchip/vpu: Cleanup JPEG bounce buffer management

2019-03-28 Thread Ezequiel Garcia
On Thu, 2019-03-28 at 15:15 +0900, Tomasz Figa wrote: > Hi Ezequiel, > > On Tue, Mar 5, 2019 at 4:26 AM Ezequiel Garcia wrote: > > In order to make the code more generic, introduce a pair of start/stop > > codec operations, and use them to allocate and release the JPEG bounce > > buffer. > > > >

Re: [PATCH v2 06/11] rockchip/vpu: Cleanup JPEG bounce buffer management

2019-03-27 Thread Tomasz Figa
Hi Ezequiel, On Tue, Mar 5, 2019 at 4:26 AM Ezequiel Garcia wrote: > > In order to make the code more generic, introduce a pair of start/stop > codec operations, and use them to allocate and release the JPEG bounce > buffer. > > Signed-off-by: Ezequiel Garcia > --- > .../media/rockchip/vpu/rk32

[PATCH v2 06/11] rockchip/vpu: Cleanup JPEG bounce buffer management

2019-03-04 Thread Ezequiel Garcia
In order to make the code more generic, introduce a pair of start/stop codec operations, and use them to allocate and release the JPEG bounce buffer. Signed-off-by: Ezequiel Garcia --- .../media/rockchip/vpu/rk3288_vpu_hw.c| 2 ++ .../rockchip/vpu/rk3288_vpu_hw_jpeg_enc.c | 4 +--

[PATCH 05/10] rockchip/vpu: Cleanup JPEG bounce buffer management

2019-02-05 Thread Ezequiel Garcia
In order to make the code more generic, introduce a pair of start/stop codec operations, and use them to allocate and release the JPEG bounce buffer. Signed-off-by: Ezequiel Garcia --- .../media/rockchip/vpu/rk3288_vpu_hw.c| 2 ++ .../rockchip/vpu/rk3288_vpu_hw_jpeg_enc.c | 4 +--

[PATCH v11 01/19] media: v4l2-mem2mem: extend m2m APIs for more accurate buffer management

2017-06-15 Thread Stanimir Varbanov
this add functions for: - remove buffers from src/dst queue by index - remove exact buffer from src/dst queue also extends m2m API to iterate over a list of src/dst buffers in safely and non-safely manner. Signed-off-by: Stanimir Varbanov --- drivers/media/v4l2-core/v4l2-mem2mem.c | 37

[PATCH v10 01/18] media: v4l2-mem2mem: extend m2m APIs for more accurate buffer management

2017-06-12 Thread Stanimir Varbanov
this add functions for: - remove buffers from src/dst queue by index - remove exact buffer from src/dst queue also extends m2m API to iterate over a list of src/dst buffers in safely and non-safely manner. Signed-off-by: Stanimir Varbanov --- drivers/media/v4l2-core/v4l2-mem2mem.c | 37

[PATCH v9 1/9] media: v4l2-mem2mem: extend m2m APIs for more accurate buffer management

2017-05-09 Thread Stanimir Varbanov
this add functions for: - remove buffers from src/dst queue by index - remove exact buffer from src/dst queue also extends m2m API to iterate over a list of src/dst buffers in safely and non-safely manner. Reviewed-by: Hans Verkuil Signed-off-by: Stanimir Varbanov --- drivers/media/v4l2-co

Re: [PATCH v8 02/10] media: v4l2-mem2mem: extend m2m APIs for more accurate buffer management

2017-05-05 Thread Hans Verkuil
On 04/28/17 11:13, Stanimir Varbanov wrote: > this add functions for: > - remove buffers from src/dst queue by index > - remove exact buffer from src/dst queue > > also extends m2m API to iterate over a list of src/dst buffers > in safely and non-safely manner. > > Signed-off-by: Stanimir Var

[PATCH v8 02/10] media: v4l2-mem2mem: extend m2m APIs for more accurate buffer management

2017-04-28 Thread Stanimir Varbanov
this add functions for: - remove buffers from src/dst queue by index - remove exact buffer from src/dst queue also extends m2m API to iterate over a list of src/dst buffers in safely and non-safely manner. Signed-off-by: Stanimir Varbanov --- drivers/media/v4l2-core/v4l2-mem2mem.c | 37

[PATCH v7 1/9] media: v4l2-mem2mem: extend m2m APIs for more accurate buffer management

2017-03-13 Thread Stanimir Varbanov
this add functions for: - remove buffers from src/dst queue by index - remove exact buffer from src/dst queue also extends m2m API to iterate over a list of src/dst buffers in safely and non-safely manner. Signed-off-by: Stanimir Varbanov --- drivers/media/v4l2-core/v4l2-mem2mem.c | 37

[PATCH v6 1/9] media: v4l2-mem2mem: extend m2m APIs for more accurate buffer management

2017-02-07 Thread Stanimir Varbanov
this add functions for: - remove buffers from src/dst queue by index - remove exact buffer from src/dst queue also extends m2m API to iterate over a list of src/dst buffers in safely and non-safely manner. Signed-off-by: Stanimir Varbanov --- drivers/media/v4l2-core/v4l2-mem2mem.c | 37

[PATCH v5 1/9] media: v4l2-mem2mem: extend m2m APIs for more accurate buffer management

2016-12-15 Thread Stanimir Varbanov
this add functions for: - remove buffers from src/dst queue by index - remove exact buffer from src/dst queue also extends m2m API to iterate over a list of src/dst buffers in safely and non-safely manner. Signed-off-by: Stanimir Varbanov --- drivers/media/v4l2-core/v4l2-mem2mem.c | 37

Re: [PATCH v4 1/9] media: v4l2-mem2mem: extend m2m APIs for more accurate buffer management

2016-12-05 Thread Stanimir Varbanov
Hi Hans, On 12/05/2016 01:25 PM, Hans Verkuil wrote: > On 12/01/2016 10:03 AM, Stanimir Varbanov wrote: >> this add functions for: >> - remove buffers from src/dst queue by index >> - remove exact buffer from src/dst queue >> >> also extends m2m API to iterate over a list of src/dst buffers >>

Re: [PATCH v4 1/9] media: v4l2-mem2mem: extend m2m APIs for more accurate buffer management

2016-12-05 Thread Hans Verkuil
On 12/01/2016 10:03 AM, Stanimir Varbanov wrote: > this add functions for: > - remove buffers from src/dst queue by index > - remove exact buffer from src/dst queue > > also extends m2m API to iterate over a list of src/dst buffers > in safely and non-safely manner. > > Signed-off-by: Stanimi

Re: [PATCH v4 1/9] media: v4l2-mem2mem: extend m2m APIs for more accurate buffer management

2016-12-02 Thread kbuild test robot
Hi Stanimir, [auto build test WARNING on linuxtv-media/master] [also build test WARNING on v4.9-rc7 next-20161202] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Stanimir-Varbanov/Qualcomm-video

[PATCH v4 1/9] media: v4l2-mem2mem: extend m2m APIs for more accurate buffer management

2016-12-01 Thread Stanimir Varbanov
this add functions for: - remove buffers from src/dst queue by index - remove exact buffer from src/dst queue also extends m2m API to iterate over a list of src/dst buffers in safely and non-safely manner. Signed-off-by: Stanimir Varbanov --- drivers/media/v4l2-core/v4l2-mem2mem.c | 37

rcar_vin video buffer management fixes, v3

2015-01-26 Thread William Towle
The series comprises: [PATCH 1/2] media: rcar_vin: helper function for streaming stop [PATCH 2/2] media: rcar_vin: move buffer management to Cheers, Wills -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@

[PATCH 2/2] media: rcar_vin: move buffer management to .stop_streaming handler

2015-01-26 Thread William Towle
This commit moves the "buffer in use" logic from the .buf_cleanup handler into .stop_streaming, based on advice that this is its proper logical home. By ensuring the list of pointers in priv->queue_buf[] is managed as soon as possible, we avoid warnings concerning buffers in ACTIVE state when the

Re: [RFC PATCH 5/5] media: rcar_vin: move buffer management to .stop_streaming handler

2015-01-20 Thread William Towle
On Mon, 19 Jan 2015, Guennadi Liakhovetski wrote: On Mon, 19 Jan 2015, William Towle wrote: in the patchset Ben linked to above we think we have the appropriate loops: a for loop for queue_buf[], and list_for_each_safe() for anything left in priv->capture; this is consistent with rcar_vin_fi

Re: [RFC PATCH 5/5] media: rcar_vin: move buffer management to .stop_streaming handler

2015-01-19 Thread Hans Verkuil
On 01/19/2015 03:11 PM, William Towle wrote: > > On Mon, 19 Jan 2015, Guennadi Liakhovetski wrote: > On Thu, 18 Dec 2014, Ben Hutchings wrote: >>> Well, I thought that too. Will's submission from last week has that >>> change: >>> http://thread.gmane.org/gmane.linux.drivers.video-input-infr

Re: [RFC PATCH 5/5] media: rcar_vin: move buffer management to .stop_streaming handler

2015-01-19 Thread Guennadi Liakhovetski
Hi, On Mon, 19 Jan 2015, William Towle wrote: > > On Mon, 19 Jan 2015, Guennadi Liakhovetski wrote: > > > > > On Thu, 18 Dec 2014, Ben Hutchings wrote: > > > Well, I thought that too. Will's submission from last week has that > > > change: > > > http://thread.gmane.org/gmane.linux.drivers.vide

Re: [RFC PATCH 5/5] media: rcar_vin: move buffer management to .stop_streaming handler

2015-01-19 Thread William Towle
On Mon, 19 Jan 2015, Guennadi Liakhovetski wrote: On Thu, 18 Dec 2014, Ben Hutchings wrote: Well, I thought that too. Will's submission from last week has that change: http://thread.gmane.org/gmane.linux.drivers.video-input-infrastructure/87009 Anyway, yes, that looks better! But I would s

Re: [RFC PATCH 5/5] media: rcar_vin: move buffer management to .stop_streaming handler

2015-01-19 Thread Guennadi Liakhovetski
On Mon, 19 Jan 2015, Ben Hutchings wrote: > On Sun, 2015-01-18 at 22:23 +0100, Guennadi Liakhovetski wrote: > > On Thu, 18 Dec 2014, Ben Hutchings wrote: > > > > > From: William Towle > > > > > > Move the buffer state test in the .buf_cleanup handler into > > > .stop_streaming so that a) the vb

Re: [RFC PATCH 5/5] media: rcar_vin: move buffer management to .stop_streaming handler

2015-01-19 Thread Ben Hutchings
On Sun, 2015-01-18 at 22:23 +0100, Guennadi Liakhovetski wrote: > On Thu, 18 Dec 2014, Ben Hutchings wrote: > > > From: William Towle > > > > Move the buffer state test in the .buf_cleanup handler into > > .stop_streaming so that a) the vb2_queue API is not subverted, and > > b) tracking of acti

Re: [RFC PATCH 5/5] media: rcar_vin: move buffer management to .stop_streaming handler

2015-01-18 Thread Guennadi Liakhovetski
On Thu, 18 Dec 2014, Ben Hutchings wrote: > From: William Towle > > Move the buffer state test in the .buf_cleanup handler into > .stop_streaming so that a) the vb2_queue API is not subverted, and > b) tracking of active-state buffers via priv->queue_buf[] is handled > as early as is possible H

[RFC PATCH 0/5] media: rcar_vin: Fixes for buffer management

2015-01-16 Thread William Towle
The following is a subset of our work in progress branch for video support on the Renesas "Lager" board, comprising hotfixes for video buffer management. We are successfully capturing single frames and video with the complete branch, and intend to follow up with stable patches from

[PATCH 2/2] media: rcar_vin: move buffer management to .stop_streaming handler

2015-01-16 Thread William Towle
This commit moves the "buffer in use" logic from the .buf_cleanup handler into .stop_streaming, based on advice that this is its proper logical home. By ensuring the list of pointers in priv->queue_buf[] is managed as soon as possible, we avoid warnings concerning buffers in ACTIVE state when the

[PATCH 2/2] media: rcar_vin: move buffer management to .stop_streaming handler

2015-01-16 Thread William Towle
This commit moves the "buffer in use" logic from the .buf_cleanup handler into .stop_streaming, based on advice that this is its proper logical home. By ensuring the list of pointers in priv->queue_buf[] is managed as soon as possible, we avoid warnings concerning buffers in ACTIVE state when the

Re: [RFC PATCH 0/5] media: rcar_vin: Fixes for buffer management

2014-12-18 Thread Sergei Shtylyov
buffers are returned to error state before stopping. media: rcar_vin: Fix race condition terminating stream media: rcar_vin: Clean up rcar_vin_irq William Towle (1): media: rcar_vin: move buffer management to .stop_streaming handler Having actual fixes and clean-ups in a single seri

Re: [RFC PATCH 5/5] media: rcar_vin: move buffer management to .stop_streaming handler

2014-12-18 Thread Sergei Shtylyov
Hello. On 12/18/2014 05:50 PM, Ben Hutchings wrote: From: William Towle Move the buffer state test in the .buf_cleanup handler into .stop_streaming so that a) the vb2_queue API is not subverted, and b) tracking of active-state buffers via priv->queue_buf[] is handled as early as is possible

[RFC PATCH 5/5] media: rcar_vin: move buffer management to .stop_streaming handler

2014-12-18 Thread Ben Hutchings
From: William Towle Move the buffer state test in the .buf_cleanup handler into .stop_streaming so that a) the vb2_queue API is not subverted, and b) tracking of active-state buffers via priv->queue_buf[] is handled as early as is possible Signed-off-by: William Towle --- drivers/media/platfor

[RFC PATCH 0/5] media: rcar_vin: Fixes for buffer management

2014-12-18 Thread Ben Hutchings
ar_vin: Fix race condition terminating stream media: rcar_vin: Clean up rcar_vin_irq William Towle (1): media: rcar_vin: move buffer management to .stop_streaming handler drivers/media/platform/soc_camera/rcar_vin.c | 109 ++ 1 file changed, 59 insertions(+), 5

[RFC] video-buffer management optimizations

2011-02-21 Thread Guennadi Liakhovetski
Agenda: === User-space applications need more flexibility in managing their video- (multimedia-) buffers to achieve their goals. A popular example is a photo- camera with a preview. Currently the application has to first enter the preview mode: * set the preview format * allocate buffers (if

Re: buffer management

2010-06-30 Thread Marko Ristola
ring buffer. Then you would wake up the waiting ringbuffer reader, and it would do the copy_to_user() as is done now. Some or most of the DMA buffer management could be in dvb_core/ side, because it is so generic. On Mantis side, you must grab DMA interrupt and call a function li

Re: buffer management

2010-06-23 Thread Marko Ristola
23.06.2010 15:43, Steven Toth kirjoitti: Now, on each video interrupt, I know which SG list i need to read from. At this stage i do need to copy the buffers associated with each of the SG lists at once. In this scenario, I don't see how videobuf could be used, while I keep getting this feeling th

Re: buffer management

2010-06-23 Thread Steven Toth
Now, on each video interrupt, I know which SG list i need to read from. At this stage i do need to copy the buffers associated with each of the SG lists at once. In this scenario, I don't see how videobuf could be used, while I keep getting this feeling that a simple copy_to_user of the entire buf

buffer management

2010-06-22 Thread Manu Abraham
Hi All, While working on a driver, i stumbled up on this question. I have a driver where the driver allocates it's buffers (maybe it's better to term that the hardware requires it that way) in the following fashion: Buffer 1: SG list 1 Buffer 2: SG list 2 Buffer 3: SG list 3 Buffer 4: SG list 4 B