Re: rt-mutex usage in i2c

2015-03-16 Thread Sebastian Andrzej Siewior
On 03/15/2015 08:07 AM, Mike Rapoport wrote: > On Sat, Mar 14, 2015 at 1:32 PM, Wolfram Sang wrote: >> On Sat, Mar 14, 2015 at 12:27:03PM +0100, Wolfram Sang wrote: >>> Hi Sebastian, >>> - i2c_transfer() has this piece: 2091 if (in_atomic() || irqs_disabled()) {

Re: rt-mutex usage in i2c

2015-03-15 Thread Mike Rapoport
On Sat, Mar 14, 2015 at 1:32 PM, Wolfram Sang wrote: > On Sat, Mar 14, 2015 at 12:27:03PM +0100, Wolfram Sang wrote: >> Hi Sebastian, >> >> > - i2c_transfer() has this piece: >> > 2091 if (in_atomic() || irqs_disabled()) { >> > 2092 ret = i2c_trylock_ada

Re: rt-mutex usage in i2c

2015-03-14 Thread Wolfram Sang
On Sat, Mar 14, 2015 at 12:27:03PM +0100, Wolfram Sang wrote: > Hi Sebastian, > > > - i2c_transfer() has this piece: > > 2091 if (in_atomic() || irqs_disabled()) { > > 2092 ret = i2c_trylock_adapter(adap); > > > > is this irqs_disabled() is what bothe

Re: rt-mutex usage in i2c

2015-03-14 Thread Wolfram Sang
Hi Sebastian, > - i2c_transfer() has this piece: > 2091 if (in_atomic() || irqs_disabled()) { > 2092 ret = i2c_trylock_adapter(adap); > > is this irqs_disabled() is what bothers me and should not be there. > pxa does a spin_lock_irq() which would en