Re: checkpatch.pl WARNING: Do not use whitespace before Signed-off-by:

2011-09-06 Thread Joe Perches
On Tue, 2011-09-06 at 19:23 +0300, Antti Palosaari wrote: > hmm, lets see. Maybe I will add --format=email as keyboard shortcut button. or add [format] pretty = email to your .gitconfig or create and use a check_commitlog shell script or... -- To unsubscribe from this list: send the li

Re: checkpatch.pl WARNING: Do not use whitespace before Signed-off-by:

2011-09-06 Thread Antti Palosaari
On 09/06/2011 07:10 PM, Joe Perches wrote: On Tue, 2011-09-06 at 18:30 +0300, Antti Palosaari wrote: On 09/06/2011 06:15 PM, Joe Perches wrote: On Tue, 2011-09-06 at 17:41 +0300, Antti Palosaari wrote: So what is recommended way to ensure patch is correct currently? a) before commit Use check

Re: checkpatch.pl WARNING: Do not use whitespace before Signed-off-by:

2011-09-06 Thread Joe Perches
On Tue, 2011-09-06 at 18:30 +0300, Antti Palosaari wrote: > On 09/06/2011 06:15 PM, Joe Perches wrote: > > On Tue, 2011-09-06 at 17:41 +0300, Antti Palosaari wrote: > >> So what is recommended way to ensure patch is correct currently? > >> a) before commit > > Use checkpatch. > >> b) after commit >

Re: checkpatch.pl WARNING: Do not use whitespace before Signed-off-by:

2011-09-06 Thread Antti Palosaari
On 09/06/2011 06:15 PM, Joe Perches wrote: On Tue, 2011-09-06 at 17:41 +0300, Antti Palosaari wrote: So what is recommended way to ensure patch is correct currently? a) before commit Use checkpatch. b) after commit Make the output of the commit log look like a patch. --format=email But

Re: checkpatch.pl WARNING: Do not use whitespace before Signed-off-by:

2011-09-06 Thread Joe Perches
On Tue, 2011-09-06 at 17:41 +0300, Antti Palosaari wrote: > So what is recommended way to ensure patch is correct currently? > a) before commit Use checkpatch. > b) after commit Make the output of the commit log look like a patch. -- To unsubscribe from this list: send the line "unsubscribe li

Re: checkpatch.pl WARNING: Do not use whitespace before Signed-off-by:

2011-09-06 Thread Antti Palosaari
On 09/06/2011 10:50 AM, Bjørn Mork wrote: Antti Palosaari writes: I am almost sure this have been working earlier, but now it seems like nothing is acceptable for checkpatch.pl! I did surely about 20 --amend and tried to remove everything, without luck. Could someone point out whats new accept

Re: checkpatch.pl WARNING: Do not use whitespace before Signed-off-by:

2011-09-06 Thread Bjørn Mork
Antti Palosaari writes: > I am almost sure this have been working earlier, but now it seems like > nothing is acceptable for checkpatch.pl! I did surely about 20 --amend > and tried to remove everything, without luck. Could someone point out > whats new acceptable logging format for checkpatch.pl