Re: Problematic code in media/v4l2-core/v4l2-mem2mem.c

2019-02-21 Thread Shaobo He
Hi Laurent, Thank you very much for your reply. While I was working on a patch, I realized that if we drop the two problematic NULL checks, we essentially eliminate one path of `v4l2_m2m_get_vq` where a NULL pointer is returned. So here comes a question, we may want to remove all the NULL chec

Re: Problematic code in media/v4l2-core/v4l2-mem2mem.c

2019-02-21 Thread Laurent Pinchart
Hi Shaobo, On Thu, Feb 21, 2019 at 11:11:32AM -0700, Shaobo wrote: > Hello everyone, > > I think I brought up this issue before but didn't resolve it completely. > Now I'd like to double check this and if we can agree on it, I'd also > like to submit a patch to fix it. The problem is that funct