Re: Patch for stack/DMA problems in Cinergy T2 drivers (2)

2009-08-01 Thread Nils Kassube
emag...@magic.ms wrote: > Here's a patch for cinergyT2-core.c: More like cinergyT2-fe.c according to the patch :) Anyway, thanks for the patch. I can confirm the problem with the current Ubuntu Karmic alpha kernel (2.6.31-4.23). If I use the modules of the current hg tree from http://linuxtv.org

Re: Patch for stack/DMA problems in Cinergy T2 drivers (2)

2009-08-01 Thread emagick
Johannes Stezenbach wrote: There is a fair amount of code duplication. A better aproach would be to allocate buffers once in cinergyt2_fe_attach() (add them to struct cinergyt2_fe_state). That's how it was done in the old cinergyT2 driver. Does the code in DVB frontend code assure that the f

Re: Patch for stack/DMA problems in Cinergy T2 drivers (2)

2009-08-01 Thread emagick
I've found another bug in the Cinergy T2 driver: originally (ie, e.g. in kernel 2.6.23), the structure containing "struct dvbt_set_parameters_msg param" was allocated with kzalloc, now "struct dvbt_set_parameters_msg param" lives on the stack. However, the "flags" member of that structure is not i

Re: Patch for stack/DMA problems in Cinergy T2 drivers (2)

2009-08-01 Thread emagick
Johannes Stezenbach wrote: There is a fair amount of code duplication. A better aproach would be to allocate buffers once in cinergyt2_fe_attach() (add them to struct cinergyt2_fe_state). Yes, but first I have to investigate why tuning is still quite unreliable (ie, more unreliable than in 2.

Re: Patch for stack/DMA problems in Cinergy T2 drivers (2)

2009-07-31 Thread Johannes Stezenbach
On Fri, Jul 31, 2009 at 10:25:20PM +0200, emag...@magic.ms wrote: > Here's a patch for cinergyT2-core.c: > > --- a/drivers/media/dvb/dvb-usb/cinergyT2-fe.c2009-06-10 > 05:05:27.0 +0200 > +++ b/drivers/media/dvb/dvb-usb/cinergyT2-fe.c2009-07-31 > 22:02:48.0 +0200 >

Re: Patch for stack/DMA problems in Cinergy T2 drivers

2009-07-31 Thread emagick
The patch I sent is incomplete, there are more instances of the same problem in cinergyT2-core.c. -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html