Hi,
Am Samstag, den 23.01.2010, 15:25 +0400 schrieb Manu Abraham:
> On Sat, Jan 23, 2010 at 5:08 AM, hermann pitton
> wrote:
> > Hi.
> >
> > Am Samstag, den 23.01.2010, 01:23 +0400 schrieb Manu Abraham:
> >> On Sat, Jan 23, 2010 at 1:14 AM, Mauro Carvalho Chehab
> >> wrote:
> >> > Devin Heitmue
On Sat, Jan 23, 2010 at 10:46 PM, Andreas Regel wrote:
> Hi Manu,
>
> Am 23.01.2010 19:32, schrieb Manu Abraham:
>>
>> On Sat, Jan 23, 2010 at 10:07 PM, Manu Abraham
>> wrote:
>>>
>>> Hi Andreas,
>>>
>>> On Sat, Jan 23, 2010 at 9:50 PM, Andreas Regel
>>> wrote:
Hi Manu,
Am 22
Hi Manu,
Am 23.01.2010 19:32, schrieb Manu Abraham:
On Sat, Jan 23, 2010 at 10:07 PM, Manu Abraham wrote:
Hi Andreas,
On Sat, Jan 23, 2010 at 9:50 PM, Andreas Regel wrote:
Hi Manu,
Am 22.01.2010 21:22, schrieb Manu Abraham:
On Fri, Jan 22, 2010 at 11:40 PM, Devin Heitmueller
wrote:
On Sat, Jan 23, 2010 at 10:07 PM, Manu Abraham wrote:
> Hi Andreas,
>
> On Sat, Jan 23, 2010 at 9:50 PM, Andreas Regel wrote:
>> Hi Manu,
>>
>> Am 22.01.2010 21:22, schrieb Manu Abraham:
>>>
>>> On Fri, Jan 22, 2010 at 11:40 PM, Devin Heitmueller
>>> wrote:
Also, the dvb_frontend.c ma
Hi Andreas,
On Sat, Jan 23, 2010 at 9:50 PM, Andreas Regel wrote:
> Hi Manu,
>
> Am 22.01.2010 21:22, schrieb Manu Abraham:
>>
>> On Fri, Jan 22, 2010 at 11:40 PM, Devin Heitmueller
>> wrote:
>>>
>>> Also, the dvb_frontend.c makes calls to i2c_gate_ctrl() at various
>>> points, so you would nee
Hi Manu,
Am 22.01.2010 21:22, schrieb Manu Abraham:
On Fri, Jan 22, 2010 at 11:40 PM, Devin Heitmueller
wrote:
Also, the dvb_frontend.c makes calls to i2c_gate_ctrl() at various
points, so you would need to ensure that none of those occur before
calling into your driver as there could potenti
On Sat, Jan 23, 2010 at 5:08 AM, hermann pitton wrote:
> Hi.
>
> Am Samstag, den 23.01.2010, 01:23 +0400 schrieb Manu Abraham:
>> On Sat, Jan 23, 2010 at 1:14 AM, Mauro Carvalho Chehab
>> wrote:
>> > Devin Heitmueller wrote:
>> >> On Fri, Jan 22, 2010 at 3:22 PM, Manu Abraham
>> >> wrote:
>> >>
On Sat, Jan 23, 2010 at 1:58 PM, Oliver Endriss wrote:
> Manu Abraham wrote:
>> Hi Oliver,
>>
>> On Sat, Jan 23, 2010 at 7:09 AM, Oliver Endriss wrote:
>> > Manu Abraham wrote:
>> >> On Fri, Jan 22, 2010 at 11:40 PM, Devin Heitmueller
>> >> wrote:
>> >> > Also, the dvb_frontend.c makes calls to
Manu Abraham wrote:
> Hi Oliver,
>
> On Sat, Jan 23, 2010 at 7:09 AM, Oliver Endriss wrote:
> > Manu Abraham wrote:
> >> On Fri, Jan 22, 2010 at 11:40 PM, Devin Heitmueller
> >> wrote:
> >> > Also, the dvb_frontend.c makes calls to i2c_gate_ctrl() at various
> >> > points, so you would need to e
Hi Oliver,
On Sat, Jan 23, 2010 at 7:09 AM, Oliver Endriss wrote:
> Manu Abraham wrote:
>> On Fri, Jan 22, 2010 at 11:40 PM, Devin Heitmueller
>> wrote:
>> > Also, the dvb_frontend.c makes calls to i2c_gate_ctrl() at various
>> > points, so you would need to ensure that none of those occur befor
Manu Abraham wrote:
> On Fri, Jan 22, 2010 at 11:40 PM, Devin Heitmueller
> wrote:
> > Also, the dvb_frontend.c makes calls to i2c_gate_ctrl() at various
> > points, so you would need to ensure that none of those occur before
> > calling into your driver as there could potentially be a deadlock
>
Hi.
Am Samstag, den 23.01.2010, 01:23 +0400 schrieb Manu Abraham:
> On Sat, Jan 23, 2010 at 1:14 AM, Mauro Carvalho Chehab
> wrote:
> > Devin Heitmueller wrote:
> >> On Fri, Jan 22, 2010 at 3:22 PM, Manu Abraham
> >> wrote:
> >>> On Fri, Jan 22, 2010 at 11:40 PM, Devin Heitmueller
> >>> wrote:
On Sat, Jan 23, 2010 at 1:14 AM, Mauro Carvalho Chehab
wrote:
> Devin Heitmueller wrote:
>> On Fri, Jan 22, 2010 at 3:22 PM, Manu Abraham wrote:
>>> On Fri, Jan 22, 2010 at 11:40 PM, Devin Heitmueller
>>> wrote:
Also, the dvb_frontend.c makes calls to i2c_gate_ctrl() at various
points,
Devin Heitmueller wrote:
> On Fri, Jan 22, 2010 at 3:22 PM, Manu Abraham wrote:
>> On Fri, Jan 22, 2010 at 11:40 PM, Devin Heitmueller
>> wrote:
>>> Also, the dvb_frontend.c makes calls to i2c_gate_ctrl() at various
>>> points, so you would need to ensure that none of those occur before
>>> calli
On Fri, Jan 22, 2010 at 4:03 PM, Mauro Carvalho Chehab
wrote:
> I've checked the core and it does it on a balanced way. Yet, it is risky
> to assume that this will always happen, and having a bad, non-interrupt
> mutex there can lead to machine hangups.
The core does balance the calls (I actually
On Fri, Jan 22, 2010 at 3:59 PM, Manu Abraham wrote:
> No, rather on frontend shutdown, demodulator sleep() is called
> instead. demodulator sleep() shuts down the tuner, AFAIR. This is the
> original and correct behaviour for dvb frontend.
Both the tuner and frontend are issued sleep calls. Se
Devin Heitmueller wrote:
> On Fri, Jan 22, 2010 at 1:23 PM, Manu Abraham wrote:
>> The point there is that it is a dual demod which implements a FSM for
>> it's tuner flow control and hence. The demodulators in the tree are
>> generally single/standalone and don't need such a FSM to handle that.
>
On Sat, Jan 23, 2010 at 12:42 AM, Devin Heitmueller
wrote:
> On Fri, Jan 22, 2010 at 3:22 PM, Manu Abraham wrote:
>> On Fri, Jan 22, 2010 at 11:40 PM, Devin Heitmueller
>> wrote:
>>> Also, the dvb_frontend.c makes calls to i2c_gate_ctrl() at various
>>> points, so you would need to ensure that n
On Fri, Jan 22, 2010 at 3:22 PM, Manu Abraham wrote:
> On Fri, Jan 22, 2010 at 11:40 PM, Devin Heitmueller
> wrote:
>> Also, the dvb_frontend.c makes calls to i2c_gate_ctrl() at various
>> points, so you would need to ensure that none of those occur before
>> calling into your driver as there cou
On Fri, Jan 22, 2010 at 11:40 PM, Devin Heitmueller
wrote:
> Also, the dvb_frontend.c makes calls to i2c_gate_ctrl() at various
> points, so you would need to ensure that none of those occur before
> calling into your driver as there could potentially be a deadlock
> there too.
Ok, thanks for the
On Fri, Jan 22, 2010 at 11:40 PM, Devin Heitmueller
wrote:
> On Fri, Jan 22, 2010 at 2:11 PM, Manu Abraham wrote:
>> I think you understood incorrectly. Generally most demodulators have
>> an option to detect the I2C stop bit, thereby automatically disabling
>> the gate, while some don't. In thos
On Fri, Jan 22, 2010 at 2:11 PM, Manu Abraham wrote:
> I think you understood incorrectly. Generally most demodulators have
> an option to detect the I2C stop bit, thereby automatically disabling
> the gate, while some don't. In those cases, you don't even need a
> i2c_gate_control(disable)
> It i
On Fri, Jan 22, 2010 at 10:43 PM, Devin Heitmueller
wrote:
> On Fri, Jan 22, 2010 at 1:23 PM, Manu Abraham wrote:
>> The point there is that it is a dual demod which implements a FSM for
>> it's tuner flow control and hence. The demodulators in the tree are
>> generally single/standalone and don'
On Fri, Jan 22, 2010 at 1:23 PM, Manu Abraham wrote:
> The point there is that it is a dual demod which implements a FSM for
> it's tuner flow control and hence. The demodulators in the tree are
> generally single/standalone and don't need such a FSM to handle that.
> Even if it's a dual frontend,
On Fri, Jan 22, 2010 at 9:56 PM, Devin Heitmueller
wrote:
> On Fri, Jan 22, 2010 at 12:48 PM, Mauro Carvalho Chehab
> wrote:
> if (stv090x_i2c_gate_ctrl(fe, 1) < 0)
> goto err;
>
> tuner access
>
> if (stv090x_i2c_gate_ctrl(fe, 0) < 0)
> got
On Fri, Jan 22, 2010 at 9:48 PM, Mauro Carvalho Chehab
wrote:
> Manu Abraham wrote:
>> On Sat, Jan 16, 2010 at 5:14 PM, Mauro Carvalho Chehab
>> wrote:
>>> Hi Andreas,
>>>
>>> Andreas Regel wrote:
>>>
you don't have to look at stv090x_i2c_gate_ctrl alone. stv090x driver
contains code li
On Fri, Jan 22, 2010 at 12:48 PM, Mauro Carvalho Chehab
wrote:
if (stv090x_i2c_gate_ctrl(fe, 1) < 0)
goto err;
tuner access
if (stv090x_i2c_gate_ctrl(fe, 0) < 0)
goto err;
>>> Ok. It is very unusual to have a lock internally like the a
Oliver Endriss wrote:
> Hi,
>
> Mauro Carvalho Chehab wrote:
>> Hi Andreas,
>>
>> Andreas Regel wrote:
>>
>>> you don't have to look at stv090x_i2c_gate_ctrl alone. stv090x driver
>>> contains code like this:
>>>
>>> if (stv090x_i2c_gate_ctrl(fe, 1) < 0)
>>> goto err;
>>>
>>> tun
Manu Abraham wrote:
> On Sat, Jan 16, 2010 at 5:14 PM, Mauro Carvalho Chehab
> wrote:
>> Hi Andreas,
>>
>> Andreas Regel wrote:
>>
>>> you don't have to look at stv090x_i2c_gate_ctrl alone. stv090x driver
>>> contains code like this:
>>>
>>> if (stv090x_i2c_gate_ctrl(fe, 1) < 0)
>>> go
Hi,
Mauro Carvalho Chehab wrote:
> Hi Andreas,
>
> Andreas Regel wrote:
>
> > you don't have to look at stv090x_i2c_gate_ctrl alone. stv090x driver
> > contains code like this:
> >
> > if (stv090x_i2c_gate_ctrl(fe, 1) < 0)
> > goto err;
> >
> > tuner access
> >
> > if (st
On Sat, Jan 16, 2010 at 5:14 PM, Mauro Carvalho Chehab
wrote:
> Hi Andreas,
>
> Andreas Regel wrote:
>
>> you don't have to look at stv090x_i2c_gate_ctrl alone. stv090x driver
>> contains code like this:
>>
>> if (stv090x_i2c_gate_ctrl(fe, 1) < 0)
>> goto err;
>>
>> tuner access
>>
Hi Andreas,
Andreas Regel wrote:
> you don't have to look at stv090x_i2c_gate_ctrl alone. stv090x driver
> contains code like this:
>
> if (stv090x_i2c_gate_ctrl(fe, 1) < 0)
> goto err;
>
> tuner access
>
> if (stv090x_i2c_gate_ctrl(fe, 0) < 0)
> goto err;
Ok. It
Oliver Endriss wrote:
> Mauro Carvalho Chehab wrote:
>> Oliver Endriss wrote:
>>> Manu Abraham wrote:
On Mon, Jan 11, 2010 at 12:17 AM, Manu Abraham
wrote:
> Mauro,
>
>
> Following the changesets 13830 - 13894 from my earlier pull request,
Correction, 13880 - 13894
Mauro Carvalho Chehab wrote:
> Oliver Endriss wrote:
> > Manu Abraham wrote:
> >> On Mon, Jan 11, 2010 at 12:17 AM, Manu Abraham
> >> wrote:
> >>> Mauro,
> >>>
> >>>
> >>> Following the changesets 13830 - 13894 from my earlier pull request,
> >> Correction, 13880 - 13894 inclusive of both.
> >>
>
Manu Abraham wrote:
> On Mon, Jan 11, 2010 at 12:17 AM, Manu Abraham wrote:
> > Mauro,
> >
> >
> > Following the changesets 13830 - 13894 from my earlier pull request,
>
> Correction, 13880 - 13894 inclusive of both.
>
> >
> > Please pull the following changeset as well
> >
> >
> > http://jusst.
Oliver Endriss wrote:
> Manu Abraham wrote:
>> On Mon, Jan 11, 2010 at 12:17 AM, Manu Abraham
>> wrote:
>>> Mauro,
>>>
>>>
>>> Following the changesets 13830 - 13894 from my earlier pull request,
>> Correction, 13880 - 13894 inclusive of both.
>>
>>> Please pull the following changeset as well
>>
On Mon, Jan 11, 2010 at 12:17 AM, Manu Abraham wrote:
> Mauro,
>
>
> Following the changesets 13830 - 13894 from my earlier pull request,
Correction, 13880 - 13894 inclusive of both.
>
> Please pull the following changeset as well
>
>
> http://jusst.de/hg/stv090x/rev/80c74966d955
>
>
> It fixes
Hi,
Manu Abraham wrote:
> On Sun, Jan 10, 2010 at 4:52 PM, Mauro Carvalho Chehab
> wrote:
> > Manu Abraham wrote:
> >> Mauro,
> >>
> >> Please pull http://jusst.de/hg/stv090x changesets: from 13880 - 13891
> >> inclusive of both.
> >
> > The third changeset has some locking troubles:
> >
> > # No
On Sun, Jan 10, 2010 at 6:43 PM, Andreas Regel wrote:
> Hi Mauro,
>
> Am 10.01.2010 15:15, schrieb Mauro Carvalho Chehab:
>>
>> Andreas Regel wrote:
>>>
>>> Hi Mauro,
>>>
>>> Am 10.01.2010 13:52, schrieb Mauro Carvalho Chehab:
Manu Abraham wrote:
>
> Mauro,
>
> Please pul
Hi Mauro,
Am 10.01.2010 15:15, schrieb Mauro Carvalho Chehab:
Andreas Regel wrote:
Hi Mauro,
Am 10.01.2010 13:52, schrieb Mauro Carvalho Chehab:
Manu Abraham wrote:
Mauro,
Please pull http://jusst.de/hg/stv090x changesets: from 13880 - 13891
inclusive of both.
The third changeset has some
Andreas Regel wrote:
> Hi Mauro,
>
> Am 10.01.2010 13:52, schrieb Mauro Carvalho Chehab:
>> Manu Abraham wrote:
>>> Mauro,
>>>
>>> Please pull http://jusst.de/hg/stv090x changesets: from 13880 - 13891
>>> inclusive of both.
>>
>> The third changeset has some locking troubles:
>>
>> # Node ID 4dd17
Mauro,
On Sun, Jan 10, 2010 at 4:52 PM, Mauro Carvalho Chehab
wrote:
> Manu Abraham wrote:
>> Mauro,
>>
>> Please pull http://jusst.de/hg/stv090x changesets: from 13880 - 13891
>> inclusive of both.
>
> The third changeset has some locking troubles:
>
> # Node ID 4dd17a6a5ecc320eab58590a8567e5ba0
Hi Mauro,
Am 10.01.2010 13:52, schrieb Mauro Carvalho Chehab:
Manu Abraham wrote:
Mauro,
Please pull http://jusst.de/hg/stv090x changesets: from 13880 - 13891
inclusive of both.
The third changeset has some locking troubles:
# Node ID 4dd17a6a5ecc320eab58590a8567e5ba03b9d53a
[STV090x] Added
Manu Abraham wrote:
> Mauro,
>
> Please pull http://jusst.de/hg/stv090x changesets: from 13880 - 13891
> inclusive of both.
The third changeset has some locking troubles:
# Node ID 4dd17a6a5ecc320eab58590a8567e5ba03b9d53a
[STV090x] Added mutex protection around tuner I2C access.
After the patch
44 matches
Mail list logo