Re: [REVIEW] au0828-video.c

2014-12-12 Thread Devin Heitmueller
> As we've discussed on IRC channel, it would be good to add support > for format enumeration on it, but the changes don't seem to be > trivial. I'm not willing to do it, due to my lack of time, but, > if someone steps up for doing that, then we can wait for those > patches before bumping the versi

Re: [REVIEW] au0828-video.c

2014-12-12 Thread Mauro Carvalho Chehab
Em Fri, 12 Dec 2014 11:46:13 -0500 Devin Heitmueller escreveu: > >> In short, that code cannot be removed. > > > > Sure it can. I just tried tvtime and you are right, it blocks the GUI. > > But the fix is very easy as well. So now I've updated tvtime so that > > it timeouts and gives the GUI time

Re: [REVIEW] au0828-video.c

2014-12-12 Thread Devin Heitmueller
>> In short, that code cannot be removed. > > Sure it can. I just tried tvtime and you are right, it blocks the GUI. > But the fix is very easy as well. So now I've updated tvtime so that > it timeouts and gives the GUI time to update itself. That's a nice change to tvtime and I'm sure it will mak

Re: [REVIEW] au0828-video.c

2014-12-12 Thread Hans Verkuil
On 12/12/2014 04:52 PM, Devin Heitmueller wrote: >> No, tvtime no longer hangs if no frames arrive, so there is no need for >> this timeout handling. I'd strip it out, which can be done in a separate >> patch. > > Did you actually try it? Mauro tried it, not me. I'm not sure if he looked at wheth

Re: [REVIEW] au0828-video.c

2014-12-12 Thread Devin Heitmueller
> No, tvtime no longer hangs if no frames arrive, so there is no need for > this timeout handling. I'd strip it out, which can be done in a separate > patch. Did you actually try it? Do you have some patches to tvtime which aren't upstream? I wrote the comment in question (and added the associate

Re: [REVIEW] au0828-video.c

2014-12-12 Thread Shuah Khan
On 12/12/2014 08:28 AM, Hans Verkuil wrote: > On 12/12/2014 04:26 PM, Shuah Khan wrote: >> On 12/12/2014 06:14 AM, Mauro Carvalho Chehab wrote: >>> Em Fri, 12 Dec 2014 13:55:14 +0100 >>> Hans Verkuil escreveu: >>> On 12/12/2014 01:49 PM, Mauro Carvalho Chehab wrote: > Em Fri, 12 Dec 2014

Re: [REVIEW] au0828-video.c

2014-12-12 Thread Hans Verkuil
On 12/12/2014 04:26 PM, Shuah Khan wrote: > On 12/12/2014 06:14 AM, Mauro Carvalho Chehab wrote: >> Em Fri, 12 Dec 2014 13:55:14 +0100 >> Hans Verkuil escreveu: >> >>> On 12/12/2014 01:49 PM, Mauro Carvalho Chehab wrote: Em Fri, 12 Dec 2014 11:16:01 +0100 Hans Verkuil escreveu: >>>

Re: [REVIEW] au0828-video.c

2014-12-12 Thread Shuah Khan
On 12/12/2014 06:14 AM, Mauro Carvalho Chehab wrote: > Em Fri, 12 Dec 2014 13:55:14 +0100 > Hans Verkuil escreveu: > >> On 12/12/2014 01:49 PM, Mauro Carvalho Chehab wrote: >>> Em Fri, 12 Dec 2014 11:16:01 +0100 >>> Hans Verkuil escreveu: >>> Hi Shuah, This is the video.c review w

Re: [REVIEW] au0828-video.c

2014-12-12 Thread Shuah Khan
Hi Hans, Thanks for a quick review. On 12/12/2014 03:16 AM, Hans Verkuil wrote: > Hi Shuah, > > This is the video.c review with your patch applied. > >> /* >> * Auvitek AU0828 USB Bridge (Analog video support) >> * >> * Copyright (C) 2009 Devin Heitmueller >> * Copyright (C) 2005-2008 Auvi

Re: [REVIEW] au0828-video.c

2014-12-12 Thread Mauro Carvalho Chehab
Em Fri, 12 Dec 2014 13:55:14 +0100 Hans Verkuil escreveu: > On 12/12/2014 01:49 PM, Mauro Carvalho Chehab wrote: > > Em Fri, 12 Dec 2014 11:16:01 +0100 > > Hans Verkuil escreveu: > > > >> Hi Shuah, > >> > >> This is the video.c review with your patch applied. > >> > >>> /* > >>> * Auvitek AU08

Re: [REVIEW] au0828-video.c

2014-12-12 Thread Hans Verkuil
On 12/12/2014 01:49 PM, Mauro Carvalho Chehab wrote: > Em Fri, 12 Dec 2014 11:16:01 +0100 > Hans Verkuil escreveu: > >> Hi Shuah, >> >> This is the video.c review with your patch applied. >> >>> /* >>> * Auvitek AU0828 USB Bridge (Analog video support) >>> * >>> * Copyright (C) 2009 Devin Heit

Re: [REVIEW] au0828-video.c

2014-12-12 Thread Mauro Carvalho Chehab
Em Fri, 12 Dec 2014 11:16:01 +0100 Hans Verkuil escreveu: > Hi Shuah, > > This is the video.c review with your patch applied. > > > /* > > * Auvitek AU0828 USB Bridge (Analog video support) > > * > > * Copyright (C) 2009 Devin Heitmueller > > * Copyright (C) 2005-2008 Auvitek International