Re: [PATCH 3/3] au8522, au0828: Added demodulator reset

2014-01-13 Thread Devin Heitmueller
On Sat, Jan 11, 2014 at 5:12 PM, Tim Mester wrote: > My device is the 950q, so it uses the AU8522_DEMODLOCKING method. No devices do tuner locking for digital (it's always the demodulator). That code should really just be ripped out. > It does not appear to be an xc5000 issue on the surface.

Re: [PATCH 3/3] au8522, au0828: Added demodulator reset

2014-01-11 Thread Tim Mester
On Wed, Jan 8, 2014 at 1:26 PM, Devin Heitmueller wrote: > Hi Tim, > > On Wed, Jan 8, 2014 at 12:12 AM, Tim Mester wrote: >> Commit 2e68a75990011ccd looks interesting. It makes sense to me >> that if we are gating the clock, and it is possible that we are >> glitching the clock line, it could

Re: [PATCH 3/3] au8522, au0828: Added demodulator reset

2014-01-08 Thread Devin Heitmueller
Hi Tim, On Wed, Jan 8, 2014 at 12:12 AM, Tim Mester wrote: > Commit 2e68a75990011ccd looks interesting. It makes sense to me > that if we are gating the clock, and it is possible that we are > glitching the clock line, it could put the internal synchronous logic > into a bad state. If that ha

Re: [PATCH 3/3] au8522, au0828: Added demodulator reset

2014-01-07 Thread Tim Mester
On Mon, Jan 6, 2014 at 9:53 PM, Devin Heitmueller wrote: >> I suspect this is actually a different problem which out of dumb luck >> gets "fixed" by resetting the chip. Without more details on the >> specific behavior you are seeing though I cannot really advise on what >> the correct change is.

Re: [PATCH 3/3] au8522, au0828: Added demodulator reset

2014-01-07 Thread Tim Mester
On Mon, Jan 6, 2014 at 9:45 PM, Devin Heitmueller wrote: > > On Mon, Jan 6, 2014 at 11:29 PM, Tim Mester wrote: > > The demodulator can get in a state in ATSC mode where just > > restarting the feed alone does not correct the corrupted stream. The > > demodulator reset in addition to the feed re

Re: [PATCH 3/3] au8522, au0828: Added demodulator reset

2014-01-07 Thread Devin Heitmueller
On Tue, Jan 7, 2014 at 9:58 AM, Mauro Carvalho Chehab wrote: > Patches 1 and 2 are ok? If so, could you please reply to them with your > ack? Sure, no problem. >> http://git.kernellabs.com/?p=dheitmueller/linuxtv.git;a=shortlog;h=refs/heads/950q_improv >> >> I'm not against the hack you've propo

Re: [PATCH 3/3] au8522, au0828: Added demodulator reset

2014-01-07 Thread Mauro Carvalho Chehab
Hi Devin, Em Mon, 06 Jan 2014 23:53:15 -0500 Devin Heitmueller escreveu: > What is the actual "corruption" that you are seeing? Can you describe > it in greater detail? The original fix was specifically related to > the internal FIFO on the au0828 where it can get shifted by one or > more bits

Re: [PATCH 3/3] au8522, au0828: Added demodulator reset

2014-01-06 Thread Devin Heitmueller
> I suspect this is actually a different problem which out of dumb luck > gets "fixed" by resetting the chip. Without more details on the > specific behavior you are seeing though I cannot really advise on what > the correct change is. Tim, It might be worth trying out the following patch series

Re: [PATCH 3/3] au8522, au0828: Added demodulator reset

2014-01-06 Thread Devin Heitmueller
On Mon, Jan 6, 2014 at 11:29 PM, Tim Mester wrote: > The demodulator can get in a state in ATSC mode where just > restarting the feed alone does not correct the corrupted stream. The > demodulator reset in addition to the feed restart seems to correct > the condition. > > The au8522 driver has be