Re: [PATCH 1/1 v3] libv4l: Add plugin support to libv4l

2011-04-29 Thread Hans de Goede
Hi, On 04/29/2011 10:55 AM, Yordan Kamenov wrote: Hans de Goede wrote: Hi, Hi Hans, Thanks for your comments. First of all my apologies for taking so long to get around to reviewing this. Over all it looks good, I've put some small remarks inline, if you fix these I can merge this. I wonde

Re: [PATCH 1/1 v3] libv4l: Add plugin support to libv4l

2011-04-29 Thread Yordan Kamenov
Hans de Goede wrote: Hi, Hi Hans, Thanks for your comments. First of all my apologies for taking so long to get around to reviewing this. Over all it looks good, I've put some small remarks inline, if you fix these I can merge this. I wonder though, given the recent limbo around Nokia's chan

Re: [PATCH 1/1 v3] libv4l: Add plugin support to libv4l

2011-04-28 Thread Hans Verkuil
Yupeng, Can you take a look at this as well? After all, Qualcomm is one of the intended users. Regards, Hans On Thursday, April 28, 2011 14:46:27 Hans de Goede wrote: > Hi, > > First of all my apologies for taking so long to get around to > reviewing this. > > Over all it looks good,

Re: [PATCH 1/1 v3] libv4l: Add plugin support to libv4l

2011-04-28 Thread Sakari Ailus
Hans de Goede wrote: > Hi, Hi Hans, Yordan, > First of all my apologies for taking so long to get around to > reviewing this. > > Over all it looks good, I've put some small remarks inline, if > you fix these I can merge this. I wonder though, given the recent > limbo around Nokia's change of fo

Re: [PATCH 1/1 v3] libv4l: Add plugin support to libv4l

2011-04-28 Thread Hans de Goede
Hi, First of all my apologies for taking so long to get around to reviewing this. Over all it looks good, I've put some small remarks inline, if you fix these I can merge this. I wonder though, given the recent limbo around Nokia's change of focus, if there are any plans to actually move forward