Re: [PATCH 09/12] v4l2-compat-ioctl32.c: copy clip list in put_v4l2_window32

2018-01-29 Thread Sakari Ailus
On Mon, Jan 29, 2018 at 12:13:14PM -0200, Mauro Carvalho Chehab wrote: > Em Mon, 29 Jan 2018 11:47:42 +0200 > Sakari Ailus escreveu: > > > > > + compat_caddr_t p; > > > + > > > if (copy_to_user(&up->w, &kp->w, sizeof(kp->w)) || > > > put_user(kp->field, &up->field) || > > > put_use

Re: [PATCH 09/12] v4l2-compat-ioctl32.c: copy clip list in put_v4l2_window32

2018-01-29 Thread Mauro Carvalho Chehab
Em Mon, 29 Jan 2018 11:47:42 +0200 Sakari Ailus escreveu: > > + compat_caddr_t p; > > + > > if (copy_to_user(&up->w, &kp->w, sizeof(kp->w)) || > > put_user(kp->field, &up->field) || > > put_user(kp->chromakey, &up->chromakey) || > > put_user(kp->clipcount, &up->clip

Re: [PATCH 09/12] v4l2-compat-ioctl32.c: copy clip list in put_v4l2_window32

2018-01-29 Thread Sakari Ailus
Hi Hans, On Fri, Jan 26, 2018 at 01:43:24PM +0100, Hans Verkuil wrote: > From: Hans Verkuil > > put_v4l2_window32() didn't copy back the clip list to userspace. > Drivers can update the clip rectangles, so this should be done. > > Signed-off-by: Hans Verkuil > --- > drivers/media/v4l2-core/v4