Re: [PATCH/RFC 1/1] Add a libv4l plugin for Exynos4 camera

2014-10-10 Thread Jacek Anaszewski
Hi Hans, On 10/10/2014 10:54 AM, Hans Verkuil wrote: Hi Jacek, I didn't do an in-depth review, but one thing caught my eye: On 10/08/2014 10:46 AM, Jacek Anaszewski wrote: The plugin provides support for the media device on Exynos4 SoC. Added is also a media device configuration file parser.

Re: [PATCH/RFC 1/1] Add a libv4l plugin for Exynos4 camera

2014-10-10 Thread Hans Verkuil
Hi Jacek, I didn't do an in-depth review, but one thing caught my eye: On 10/08/2014 10:46 AM, Jacek Anaszewski wrote: The plugin provides support for the media device on Exynos4 SoC. Added is also a media device configuration file parser. The media configuration file is used for conveying info

Re: [PATCH/RFC 1/1] Add a libv4l plugin for Exynos4 camera

2014-10-10 Thread Jacek Anaszewski
Hi, On 10/09/2014 10:20 AM, Hans de Goede wrote: Hi, On 10/08/2014 03:22 PM, Jacek Anaszewski wrote: Hi Hans, On 10/08/2014 02:42 PM, Hans de Goede wrote: +} + +/* refresh device topology data after linking */ +release_entities(mdev); + +ret = get_device_topology(mdev); +

Re: [PATCH/RFC 1/1] Add a libv4l plugin for Exynos4 camera

2014-10-09 Thread Hans de Goede
Hi, On 10/08/2014 03:22 PM, Jacek Anaszewski wrote: > Hi Hans, > > On 10/08/2014 02:42 PM, Hans de Goede wrote: >>> +} >>> + >>> +/* refresh device topology data after linking */ >>> +release_entities(mdev); >>> + >>> +ret = get_device_topology(mdev); >>> + >>> +/* close me

Re: [PATCH/RFC 1/1] Add a libv4l plugin for Exynos4 camera

2014-10-09 Thread Jacek Anaszewski
On 10/08/2014 05:49 PM, Antonio Ospite wrote: On Wed, 08 Oct 2014 15:22:43 +0200 Jacek Anaszewski wrote: Hi Hans, On 10/08/2014 02:42 PM, Hans de Goede wrote: Hi, On 10/08/2014 10:46 AM, Jacek Anaszewski wrote: The plugin provides support for the media device on Exynos4 SoC. Added is also

Re: [PATCH/RFC 1/1] Add a libv4l plugin for Exynos4 camera

2014-10-08 Thread Antonio Ospite
On Wed, 08 Oct 2014 15:22:43 +0200 Jacek Anaszewski wrote: > Hi Hans, > > On 10/08/2014 02:42 PM, Hans de Goede wrote: > > Hi, > > > > On 10/08/2014 10:46 AM, Jacek Anaszewski wrote: > >> The plugin provides support for the media device on Exynos4 SoC. > >> Added is also a media device configura

Re: [PATCH/RFC 1/1] Add a libv4l plugin for Exynos4 camera

2014-10-08 Thread Jacek Anaszewski
Hi Hans, On 10/08/2014 02:42 PM, Hans de Goede wrote: Hi, On 10/08/2014 10:46 AM, Jacek Anaszewski wrote: The plugin provides support for the media device on Exynos4 SoC. Added is also a media device configuration file parser. The media configuration file is used for conveying information abou

Re: [PATCH/RFC 1/1] Add a libv4l plugin for Exynos4 camera

2014-10-08 Thread Hans de Goede
Hi, On 10/08/2014 10:46 AM, Jacek Anaszewski wrote: > The plugin provides support for the media device on Exynos4 SoC. > Added is also a media device configuration file parser. > The media configuration file is used for conveying information > about media device links that need to be established a