>Pawel Osciak [mailto:p.osc...@samsung.com] wrote:
>>> +unsigned int v4l2_m2m_poll(struct file *file, struct v4l2_m2m_ctx *m2m_ctx,
>>> + struct poll_table_struct *wait)
>>> +{
>>> + struct videobuf_queue *dst_q;
>>> + struct videobuf_buffer *vb = NULL;
>>> + unsigned int
Hi Hans,
thank you for the review. My comments below.
> Hans Verkuil [mailto:hverk...@xs4all.nl] wrote:
>Here is my review...
>
[...]
>> +/**
>> + * v4l2_m2m_next_src_buf() - return next source buffer from the list of
>> ready
>> + * buffers
>> + */
>> +inline void *v4l2_m2m_next_src_buf(struc
> -Original Message-
> From: Hans Verkuil [mailto:hverk...@xs4all.nl]
> Sent: Thursday, April 01, 2010 2:37 PM
> To: Pawel Osciak
> Cc: linux-media@vger.kernel.org; m.szyprow...@samsung.com;
> kyungmin.p...@samsung.com; Hiremath, Vaibhav
> Subject: Re: [PATCH v3 1/
On Thursday 01 April 2010 11:06:51 Hans Verkuil wrote:
> Here is my review...
>
> > +/**
> > + * v4l2_m2m_release() - cleans up and frees a m2m_dev structure
> > + *
> > + * Usually called from driver's remove() function.
> > + */
> > +void v4l2_m2m_release(struct v4l2_m2m_dev *m2m_dev)
> > +{
> >
Here is my review...
On Monday 29 March 2010 09:36:46 Pawel Osciak wrote:
> A mem-to-mem device is a device that uses memory buffers passed by
> userspace applications for both their source and destination data. This
> is different from existing drivers, which utilize memory buffers for either
> i
>Andy Walls [mailto:awa...@md.metrocast.net] wrote:
>I didn't do a full review (I have no time lately), but I noticed this:
>
>
>> +static void v4l2_m2m_try_schedule(struct v4l2_m2m_ctx *m2m_ctx)
>> +{
>> +struct v4l2_m2m_dev *m2m_dev;
>[...]
>> +v4l2_m2m_try_run(m2m_dev);
>> +}
>
>[...]
On Mon, 2010-03-29 at 09:36 +0200, Pawel Osciak wrote:
> A mem-to-mem device is a device that uses memory buffers passed by
> userspace applications for both their source and destination data. This
> is different from existing drivers, which utilize memory buffers for either
> input or output, but
