module_usb_driver eliminates the boilerplate and makes the code simpler.
Signed-off-by: Sachin Kamat
---
drivers/media/radio/radio-keene.c | 19 +--
1 file changed, 1 insertion(+), 18 deletions(-)
diff --git a/drivers/media/radio/radio-keene.c
b/drivers/media/radio/radio-keen
From: Hans Verkuil
drivers/media/radio/radio-keene.c:126:45: warning: dubious: !x | y
Signed-off-by: Hans Verkuil
---
drivers/media/radio/radio-keene.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/radio/radio-keene.c
b/drivers/media/radio/radio-keene.c
ind
From: Hans Verkuil
Can you try this patch:
---
drivers/media/radio/radio-keene.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/media/radio/radio-keene.c
b/drivers/media/radio/radio-keene.c
index 4c9ae76..99da3d4 100644
--- a/drivers/media/radio/radio-keene.c
+
Hans, here you are!
Antti Palosaari (1):
keene: add delay in order to settle hardware
Hans Verkuil (1):
Keene
drivers/media/radio/radio-keene.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
--
1.7.11.7
--
To unsubscribe from this list: send the line "unsubscribe
It was found by trial and error testing that at least 11 ms delay is
needed before first I/O, otherwise device will skip given command.
Signed-off-by: Antti Palosaari
---
drivers/media/radio/radio-keene.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/media/radio/radio-keene.c
b/
On Thu May 30 2013 01:52:02 Antti Palosaari wrote:
> On 05/29/2013 08:58 PM, Antti Palosaari wrote:
> > On 05/29/2013 05:26 PM, Hans Verkuil wrote:
> >> On Fri April 19 2013 11:11:27 Antti Palosaari wrote:
> >>> On 04/19/2013 10:12 AM, Hans Verkuil wrote:
> On Wed April 17 2013 21:45:24 Antti
2 Mon Sep 17 00:00:00 2001
From: Antti Palosaari
Date: Thu, 30 May 2013 02:45:47 +0300
Subject: [PATCH] Keene: start Tx by default
Signed-off-by: Antti Palosaari
---
drivers/media/radio/radio-keene.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/drivers/media/radio/radio-kee
On 05/29/2013 05:26 PM, Hans Verkuil wrote:
On Fri April 19 2013 11:11:27 Antti Palosaari wrote:
On 04/19/2013 10:12 AM, Hans Verkuil wrote:
On Wed April 17 2013 21:45:24 Antti Palosaari wrote:
On 04/15/2013 09:55 AM, Hans Verkuil wrote:
On Fri April 12 2013 02:11:41 Antti Palosaari wrote:
H
On Fri April 19 2013 11:11:27 Antti Palosaari wrote:
> On 04/19/2013 10:12 AM, Hans Verkuil wrote:
> > On Wed April 17 2013 21:45:24 Antti Palosaari wrote:
> >> On 04/15/2013 09:55 AM, Hans Verkuil wrote:
> >>> On Fri April 12 2013 02:11:41 Antti Palosaari wrote:
> Hello Hans,
> That devi
On Fri, Apr 19, 2013 at 5:58 AM, Hans Verkuil wrote:
> So perhaps this can be solved with two generic controls:
>
> bool CID_POWER_OFF_AT_LAST_CLOSE
> int CID_POWER_OFF_DELAY (unit: seconds)
>
> If POWER_OFF_AT_LAST_CLOSE is false, then you never power off. If it is true,
> then power off after a
18;
> >>> radio->tx = 0x32;
> >>> radio->stereo = true;
> >>> - radio->curfreq = 95.16 * FREQ_MUL;
> >>> if (hdl->error) {
> >>> retval = hdl->error;
> >>>
> >&
/usb/mixer.c:932 13:0: cannot get min/max values for control 2
(id 13)
usb 5-2: new full-speed USB device number 3 using ohci_hcd
usb 5-2: New USB device found, idVendor=046d, idProduct=0a0e
usb 5-2: New USB device strings: Mfr=1, Product=2, SerialNumber=0
usb 5-2: Product: B-LINK USB Audio
u
> 2) What is that log printing?
> >> ALSA sound/usb/mixer.c:932 13:0: cannot get min/max values for control 2
> >> (id 13)
> >>
> >>
> >> usb 5-2: new full-speed USB device number 3 using ohci_hcd
> >> usb 5-2: New USB device found, idVendo
-speed USB device number 3 using ohci_hcd
usb 5-2: New USB device found, idVendor=046d, idProduct=0a0e
usb 5-2: New USB device strings: Mfr=1, Product=2, SerialNumber=0
usb 5-2: Product: B-LINK USB Audio
usb 5-2: Manufacturer: HOLTEK
ALSA sound/usb/mixer.c:932 13:0: cannot get min/max values for
evice number 3 using ohci_hcd
> usb 5-2: New USB device found, idVendor=046d, idProduct=0a0e
> usb 5-2: New USB device strings: Mfr=1, Product=2, SerialNumber=0
> usb 5-2: Product: B-LINK USB Audio
> usb 5-2: Manufacturer: HOLTEK
> ALSA sound/usb/mixer.c:932 13:0: cannot get min/max valu
device strings: Mfr=1, Product=2, SerialNumber=0
usb 5-2: Product: B-LINK USB Audio
usb 5-2: Manufacturer: HOLTEK
ALSA sound/usb/mixer.c:932 13:0: cannot get min/max values for control 2
(id 13)
radio-keene 5-2:1.2: V4L2 device registered as radio0
$ v4l2-ctl -d /dev/radio0 --all -L
Driver Info
: Maintained
F: Documentation/kdump/
+KEENE FM RADIO TRANSMITTER DRIVER
+M: Hans Verkuil
+L: linux-media@vger.kernel.org
+T: git git://linuxtv.org/media_tree.git
+W: http://linuxtv.org
+S: Maintained
+F: drivers/media/radio/radio-keene*
+
KERNEL AUTOMOUNTER v4 (AUTOFS4
On Fri, 2012-04-27 at 13:56 +0200, Hans Verkuil wrote:
> Hi Mauro,
>
> One small trivial ivtv fix and a patch that adds support for suspend/resume
> to the radio-keene driver.
>
> Regards,
>
> Hans
>
> The following changes since commit bcb2cf6e0b
Hi Mauro,
>
> One small trivial ivtv fix and a patch that adds support for suspend/resume
> to the radio-keene driver.
>
> Regards,
>
> Hans
>
> The following changes since commit bcb2cf6e0bf033d79821c89e5ccb328bfbd44907:
>
> [media] ngene: remove an unne
Hi Mauro,
One small trivial ivtv fix and a patch that adds support for suspend/resume
to the radio-keene driver.
Regards,
Hans
The following changes since commit bcb2cf6e0bf033d79821c89e5ccb328bfbd44907:
[media] ngene: remove an unneeded condition (2012-04-26 15:29:23 -0300)
are
On Thu, 2 Feb 2012, Hans Verkuil wrote:
> From: Hans Verkuil
>
> The Keene FM transmitter USB device has the same USB ID as
> the Logitech AudioHub Speaker, but it should ignore the hid.
> Check if the name is that of the Keene device.
>
> Signed-off-by: Hans Verkuil
Mau
From: Hans Verkuil
The Keene FM transmitter USB device has the same USB ID as
the Logitech AudioHub Speaker, but it should ignore the hid.
Check if the name is that of the Keene device.
Signed-off-by: Hans Verkuil
---
drivers/hid/hid-core.c | 10 ++
drivers/hid/hid-ids.h |1
: the
module will be called radio-si4713.
+config USB_KEENE
+ tristate "Keene FM Transmitter USB support"
+ depends on USB && VIDEO_V4L2
+ ---help---
+ Say Y here if you want to connect this type of FM transmitter
+ to your c
This patch series is for 3.4. It adds a V4L2 driver for the Keene USB FM
Transmitter:
http://www.amazon.co.uk/Keene-Electronics-USB-FM-Transmitter/dp/B003GCHPDY
This device is very useful to test V4L2 FM radio receivers.
Changes since RFCv2 of the radio-keene driver:
- Use the new v4l2 support
: the
module will be called radio-si4713.
+config USB_KEENE
+ tristate "Keene FM Transmitter USB support"
+ depends on USB && VIDEO_V4L2
+ ---help---
+ Say Y here if you want to connect this type of FM transmitter
+ to your c
Hi all,
Here is a V4L2 driver for the Keene USB FM Transmitter:
http://www.amazon.co.uk/Keene-Electronics-USB-FM-Transmitter/dp/B003GCHPDY
Changes from v1:
Incorporated comments from Oliver Neukum:
- Use kmalloc to allocate the DMA buffer
- Check the product name in the keene driver as well
From: Hans Verkuil
The Keene FM transmitter USB device has the same USB ID as
the Logitech AudioHub Speaker, but it should ignore the hid.
Check if the name is that of the Keene device.
Signed-off-by: Hans Verkuil
---
drivers/hid/hid-core.c | 10 ++
drivers/hid/hid-ids.h |1
On Mon, 16 Jan 2012 14:11:20 +0100
Oliver Neukum wrote:
> Am Montag, 16. Januar 2012, 14:02:05 schrieb Hans Verkuil:
> > > > +/* Set frequency (if non-0), PA, mute and turn on/off the FM
> > > > transmitter. */ +static int keene_cmd_main(struct keene_device *radio,
> > > > unsigned freq, bool pla
Am Montag, 16. Januar 2012, 14:03:07 schrieb Hans Verkuil:
> > Oh, I forgot. You have no guarantee the hid driver is already loaded.
> > This driver needs to also gracefully handle being called for a HID
> > device.
>
> And how do I do that? Do you have a pointer to another driver for me?
As you'
Am Montag, 16. Januar 2012, 14:02:05 schrieb Hans Verkuil:
> > > +/* Set frequency (if non-0), PA, mute and turn on/off the FM
> > > transmitter. */ +static int keene_cmd_main(struct keene_device *radio,
> > > unsigned freq, bool play) +{
> > > + unsigned short freq_send = freq ? (freq - 76 * 160
On Monday 16 January 2012 13:46:46 Oliver Neukum wrote:
> Am Montag, 16. Januar 2012, 13:29:19 schrieb Hans Verkuil:
> > +/* check if the device is present and register with v4l and usb if it is
> > */ +static int usb_keene_probe(struct usb_interface *intf,
> > + const
On Monday 16 January 2012 13:44:37 Oliver Neukum wrote:
> Am Montag, 16. Januar 2012, 13:29:19 schrieb Hans Verkuil:
> > From: Hans Verkuil
> >
> > +MODULE_DEVICE_TABLE(usb, usb_keene_device_table);
> > +
> > +struct keene_device {
> > + struct usb_device *usbdev;
> > + struct usb_interface *
Am Montag, 16. Januar 2012, 13:29:19 schrieb Hans Verkuil:
> +/* check if the device is present and register with v4l and usb if it is */
> +static int usb_keene_probe(struct usb_interface *intf,
> + const struct usb_device_id *id)
> +{
> + struct keene_device *r
Am Montag, 16. Januar 2012, 13:29:19 schrieb Hans Verkuil:
> From: Hans Verkuil
> +MODULE_DEVICE_TABLE(usb, usb_keene_device_table);
> +
> +struct keene_device {
> + struct usb_device *usbdev;
> + struct usb_interface *intf;
> + struct video_device vdev;
> + struct v4l2_device v4l
Hi all,
Here is a V4L2 driver for the Keene USB FM Transmitter:
http://www.amazon.co.uk/Keene-Electronics-USB-FM-Transmitter/dp/B003GCHPDY
It's been very useful to test V4L2 FM radio receivers.
Note that the Keene FM transmitter USB device has the same USB ID as
the Logitech AudioHub Sp
From: Hans Verkuil
The Keene FM transmitter USB device has the same USB ID as
the Logitech AudioHub Speaker, but it should ignore the hid.
Check if the name is that of the Keene device.
Signed-off-by: Hans Verkuil
---
drivers/hid/hid-core.c | 10 ++
drivers/hid/hid-ids.h |1
: the
module will be called radio-si4713.
+config USB_KEENE
+ tristate "Keene FM Transmitter USB support"
+ depends on USB && VIDEO_V4L2
+ ---help---
+ Say Y here if you want to connect this type of FM transmitter
+ to your c
37 matches
Mail list logo
