[PATCH v11 15/15] media: tvp5150: make debug output more readable

2019-09-30 Thread Marco Felsch
The debug output for tvp5150_selmux() isn't really intuitive. Register values are printed decimal formatted and the input/output driver states are printed as enum. Even more the "normal" output enum mapps to zero so a active output will printing output=0 and a inactive output=1.

[PATCH v10 14/14] media: tvp5150: make debug output more readable

2019-08-30 Thread Marco Felsch
The debug output for tvp5150_selmux() isn't really intuitive. Register values are printed decimal formatted and the input/output driver states are printed as enum. Even more the "normal" output enum mapps to zero so a active output will printing output=0 and a inactive output=1.

[PATCH v9 13/13] media: tvp5150: make debug output more readable

2019-08-22 Thread Marco Felsch
The debug output for tvp5150_selmux() isn't really intuitive. Register values are printed decimal formatted and the input/output driver states are printed as enum. Even more the "normal" output enum mapps to zero so a active output will printing output=0 and a inactive output=1.

[PATCH v8 13/13] media: tvp5150: make debug output more readable

2019-08-21 Thread Marco Felsch
The debug output for tvp5150_selmux() isn't really intuitive. Register values are printed decimal formatted and the input/output driver states are printed as enum. Even more the "normal" output enum mapps to zero so a active output will printing output=0 and a inactive output=1.

[PATCH v7 13/13] media: tvp5150: make debug output more readable

2019-08-15 Thread Marco Felsch
The debug output for tvp5150_selmux() isn't really intuitive. Register values are printed decimal formatted and the input/output driver states are printed as enum. Even more the "normal" output enum mapps to zero so a active output will printing output=0 and a inactive output=1.

Re: [PATCH v6 13/13] media: tvp5150: make debug output more readable

2019-08-08 Thread Marco Felsch
too? Regards, Marco > > > > On Mon, Apr 15, 2019 at 02:44:13PM +0200, Marco Felsch wrote: > > > The debug output for tvp5150_selmux() isn't really intuitive. Register > > > values are printed decimal formatted and the input/output driver states > > > are

Re: [PATCH v6 13/13] media: tvp5150: make debug output more readable

2019-05-14 Thread Mauro Carvalho Chehab
Em Mon, 6 May 2019 15:39:05 +0200 Jacopo Mondi escreveu: > Hi Marco, > thanks > > Reviewed-by: Jacopo Mondi Looks ok to me too. > > On Mon, Apr 15, 2019 at 02:44:13PM +0200, Marco Felsch wrote: > > The debug output for tvp5150_selmux() isn't really intui

Re: [PATCH v6 13/13] media: tvp5150: make debug output more readable

2019-05-06 Thread Jacopo Mondi
Hi Marco, thanks Reviewed-by: Jacopo Mondi On Mon, Apr 15, 2019 at 02:44:13PM +0200, Marco Felsch wrote: > The debug output for tvp5150_selmux() isn't really intuitive. Register > values are printed decimal formatted and the input/output driver states > are printed as enum.

[PATCH v6 13/13] media: tvp5150: make debug output more readable

2019-04-15 Thread Marco Felsch
The debug output for tvp5150_selmux() isn't really intuitive. Register values are printed decimal formatted and the input/output driver states are printed as enum. Even more the "normal" output enum mapps to zero so a active output will printing output=0 and a inactive output=1.

[PATCH 06/13] media: coda: add menu strings to s_ctrl debug output

2019-04-12 Thread Philipp Zabel
When a menu control is updated via s_ctrl, print the corresponding menu entry string in addition to the numerical value it is set to. Signed-off-by: Philipp Zabel --- drivers/media/platform/coda/coda-common.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/me

[PATCH v5 13/13] media: tvp5150: make debug output more readable

2019-04-04 Thread Marco Felsch
The debug output for tvp5150_selmux() isn't really intuitive. Register values are printed decimal formatted and the input/output driver states are printed as enum. Even more the "normal" output enum mapps to zero so a active output will printing output=0 and a inactive output=1.

[PATCH 15/15] media: coda: debug output when setting visible size via crop selection

2018-11-05 Thread Philipp Zabel
In addition to the S_FMT debug output, S_SELECTION (SEL_TGT_CROP) is relevant to determine encoded size. Add debug output for it. Signed-off-by: Philipp Zabel --- drivers/media/platform/coda/coda-common.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/platform/coda/coda

[PATCH 14/15] media: coda: normalise debug output

2018-11-05 Thread Philipp Zabel
Consistently add the context index to debug output, which otherwise is impossible to make sense of when two contexts are running concurrently. For this purpose, add a convenience macro coda_dbg(). Use the function name with the coda_ prefix stripped as keyword where applicable, and consistently

[PATCH v4 17/22] gpu: ipu-v3: image-convert: fix debug output for varying tile sizes

2018-10-19 Thread Philipp Zabel
Since tile dimensions now vary between tiles, add debug output for each tile's position and dimensions. Signed-off-by: Philipp Zabel --- No changes since v3. --- drivers/gpu/ipu-v3/ipu-image-convert.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/driver

[PATCH v3 11/16] gpu: ipu-v3: image-convert: fix debug output for varying tile sizes

2018-09-18 Thread Philipp Zabel
Since tile dimensions now vary between tiles, add debug output for each tile's position and dimensions. Signed-off-by: Philipp Zabel --- No changes since v2. --- drivers/gpu/ipu-v3/ipu-image-convert.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/driver

[PATCH v2 09/16] gpu: ipu-v3: image-convert: fix debug output for varying tile sizes

2018-07-19 Thread Philipp Zabel
Since tile dimensions now vary between tiles, add debug output for each tile's position and dimensions. Signed-off-by: Philipp Zabel --- drivers/gpu/ipu-v3/ipu-image-convert.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/ipu-v3/ipu-

[PATCH 09/16] gpu: ipu-v3: image-convert: fix debug output for varying tile sizes

2018-06-22 Thread Philipp Zabel
Since tile dimensions now vary between tiles, add debug output for each tile's position and dimensions. Signed-off-by: Philipp Zabel --- drivers/gpu/ipu-v3/ipu-image-convert.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/ipu-v3/ipu-

[PATCH v3] saa7164: Fix driver name in debug output

2018-05-04 Thread Brad Love
This issue was reported by a user who downloaded a corrupt saa7164 firmware, then went looking for a valid xc5000 firmware to fix the error displayed...but the device in question has no xc5000, thus after much effort, the wild goose chase eventually led to a support call. The xc5000 has nothing to

Re: [PATCH v2] saa7164: Fix driver name in debug output

2018-05-04 Thread kbuild test robot
/0day-ci/linux/commits/Brad-Love/saa7164-Fix-driver-name-in-debug-output/20180504-114908 base: git://linuxtv.org/media_tree.git master config: i386-allyesconfig (attached as .config) compiler: gcc-7 (Debian 7.3.0-16) 7.3.0 reproduce: # save the attached .config to linux build tree

Re: [PATCH v2] saa7164: Fix driver name in debug output

2018-05-03 Thread kbuild test robot
/0day-ci/linux/commits/Brad-Love/saa7164-Fix-driver-name-in-debug-output/20180504-114908 base: git://linuxtv.org/media_tree.git master config: xtensa-allyesconfig (attached as .config) compiler: xtensa-linux-gcc (GCC) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests

[PATCH v2] saa7164: Fix driver name in debug output

2018-05-03 Thread Brad Love
This issue was reported by a user who downloaded a corrupt saa7164 firmware, then went looking for a valid xc5000 firmware to fix the error displayed...but the device in question has no xc5000, thus after much effort, the wild goose chase eventually led to a support call. The xc5000 has nothing to

Re: [PATCH] saa7164: Fix driver name in debug output

2018-05-03 Thread kbuild test robot
/0day-ci/linux/commits/Brad-Love/saa7164-Fix-driver-name-in-debug-output/20180503-133636 base: git://linuxtv.org/media_tree.git master config: sparc64-allmodconfig (attached as .config) compiler: sparc64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https

[PATCH] saa7164: Fix driver name in debug output

2018-05-02 Thread Brad Love
This issue was reported by a user who downloaded a corrupt saa7164 firmware, then went looking for a valid xc5000 firmware to fix the error displayed...but the device in question has no xc5000, thus after much effort, the wild goose chase eventually led to a support call. The xc5000 has nothing to

Re: [PATCH 5/5] v4l2: async: Add debug output to v4l2-async module

2017-12-17 Thread Sakari Ailus
4 @@ config VIDEO_ADV_DEBUG > > > V4L devices. > > > In doubt, say N. > > > > > > +config VIDEO_V4L2_ASYNC_DEBUG > > > + bool "Enable debug functionalities for V4L2 async module" > > > + depends on VIDEO_V4L2 > > > > I'm not sure I&#x

Re: [PATCH 5/5] v4l2: async: Add debug output to v4l2-async module

2017-12-17 Thread Laurent Pinchart
2-core/Kconfig > > +++ b/drivers/media/v4l2-core/Kconfig > > @@ -17,6 +17,14 @@ config VIDEO_ADV_DEBUG > > V4L devices. > > In doubt, say N. > > > > +config VIDEO_V4L2_ASYNC_DEBUG > > + bool "Enable debug functionalities for V4L2 asy

Re: [PATCH 5/5] v4l2: async: Add debug output to v4l2-async module

2017-12-17 Thread jacopo mondi
O_V4L2_ASYNC_DEBUG > > + bool "Enable debug functionalities for V4L2 async module" > > + depends on VIDEO_V4L2 > > I'm not sure I'd add a Kconfig option. This is adding a fairly simple > function only to the kernel. So I will use a symbol defined in

Re: [PATCH 5/5] v4l2: async: Add debug output to v4l2-async module

2017-12-15 Thread Sakari Ailus
ities for V4L2 async module" > + depends on VIDEO_V4L2 I'm not sure I'd add a Kconfig option. This is adding a fairly simple function only to the kernel. > + default n > + ---help--- > + Say Y here to enable debug output in V4L2 async module. > +

[PATCH 5/5] v4l2: async: Add debug output to v4l2-async module

2017-12-13 Thread Jacopo Mondi
g @@ -17,6 +17,14 @@ config VIDEO_ADV_DEBUG V4L devices. In doubt, say N. +config VIDEO_V4L2_ASYNC_DEBUG + bool "Enable debug functionalities for V4L2 async module" + depends on VIDEO_V4L2 + default n + ---help--- + Say Y here to ena

[PATCH 0/5] Add debug output to v4l2-async

2017-12-13 Thread Jacopo Mondi
linux-media anyhow for feedbacks. Thanks j Jacopo Mondi (4): device property: Add fwnode_get_name() operation include: v4l2_async: Add 'owner' field to notifier v4l2: async: Postpone subdev_notifier registration v4l2: async: Add debug output to v4l2-async module Sakar

[PATCH v4 4/7] [media] coda: add debug output about tiling

2017-01-20 Thread Michael Tretter
From: Philipp Zabel In order to make the VDOA work correctly, the CODA must produce frames in tiled format. Print this information in the debug output. Also print the color format in fourcc instead of the numeric value. Signed-off-by: Philipp Zabel Signed-off-by: Michael Tretter --- drivers

[PATCH v3 4/7] [media] coda: add debug output about tiling

2017-01-02 Thread Michael Tretter
From: Philipp Zabel In order to make the VDOA work correctly, the CODA must produce frames in tiled format. Print this information in the debug output. Also print the color format in fourcc instead of the numeric value. Signed-off-by: Philipp Zabel Signed-off-by: Michael Tretter --- drivers

[PATCH v2 4/7] [media] coda: add debug output about tiling

2016-12-09 Thread Michael Tretter
From: Philipp Zabel In order to make the VDOA work correctly, the CODA must produce frames in tiled format. Print this information in the debug output. Also print the color format in fourcc instead of the numeric value. Signed-off-by: Philipp Zabel Signed-off-by: Michael Tretter --- drivers

[PATCH 6/9] [media] coda: add debug output about tiling

2016-12-08 Thread Michael Tretter
From: Philipp Zabel In order to make the VDOA work correctly, the CODA must produce frames in tiled format. Print this information in the debug output. Also print the color format in fourcc instead of the numeric value. Signed-off-by: Philipp Zabel Signed-off-by: Michael Tretter --- drivers

[PATCHv2 3/4] add extra debug output, remove noisy warning

2015-05-25 Thread Florian Echtler
Add dev_dbg statements for easier future debugging; also change the warning about packet ID mismatches to debug output to avoid flooding the logs. This warning is only important in a very specific/rare use case when trying to correlate input events with video data. Signed-off-by: Martin

[PATCH 3/4] add extra debug output, remove noisy warning

2015-05-21 Thread Florian Echtler
Signed-off-by: Martin Kaltenbrunner Signed-off-by: Florian Echtler --- drivers/input/touchscreen/sur40.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/input/touchscreen/sur40.c b/drivers/input/touchscreen/sur40.c index d860d05..8add986 100644 --- a/drivers/

[PATCH 06/24] xc5000: add support for showing the SNR and gain in the debug output

2012-08-06 Thread Devin Heitmueller
When debugging is enabled, also show the analog SNR and the total gain status values. Signed-off-by: Devin Heitmueller --- drivers/media/common/tuners/xc5000.c | 20 1 files changed, 20 insertions(+), 0 deletions(-) diff --git a/drivers/media/common/tuners/xc5000.c b/dri

Re: Debug output

2011-12-01 Thread Mauro Carvalho Chehab
On 01-12-2011 17:01, damateem wrote: Ok, if I set debug as follows vfd->debug =V4L2_DEBUG_IOCTL | V4L2_DEBUG_IOCTL_ARG; I can see the debug trace in dmesg, but this doesn't seem like the correct way to set the flags. In general, what it is none is to add a debug modprobe parameter that would

Re: Debug output

2011-12-01 Thread damateem
Ok, if I set debug as follows vfd->debug =V4L2_DEBUG_IOCTL | V4L2_DEBUG_IOCTL_ARG; I can see the debug trace in dmesg, but this doesn't seem like the correct way to set the flags. What is the typical method of setting these debug flags? Is this the best place to ask these type of questions? Th

Debug output

2011-11-30 Thread damateem
There are a fair number of debug print statements in the V4L2 code. How do I turn those on? For instance, I'd like the following code to print if ((vfd->debug & V4L2_DEBUG_IOCTL) && !(vfd->debug & V4L2_DEBUG_IOCTL_ARG)) { v4l_print_ioctl(vfd->name, cmd); printk(KER

Re: [PATCH] v4l: mx3_camera: fix NULL pointer dereference if debug output enabled

2011-02-02 Thread Guennadi Liakhovetski
On Wed, 2 Feb 2011, Guennadi Liakhovetski wrote: > On Mon, 31 Jan 2011, Anatolij Gustschin wrote: > > > Running with enabled debug output in the mx3_camera driver results > > in a kernel crash: > > ... > > mx3-camera mx3-camera.0: Providing format Bayer BGGR (

Re: [PATCH] v4l: mx3_camera: fix NULL pointer dereference if debug output enabled

2011-02-02 Thread Guennadi Liakhovetski
On Mon, 31 Jan 2011, Anatolij Gustschin wrote: > Running with enabled debug output in the mx3_camera driver results > in a kernel crash: > ... > mx3-camera mx3-camera.0: Providing format Bayer BGGR (sRGB) 8 bit using code > 11 > Unable to handle kernel NULL pointer dereference

[PATCH] v4l: mx3_camera: fix NULL pointer dereference if debug output enabled

2011-01-31 Thread Anatolij Gustschin
Running with enabled debug output in the mx3_camera driver results in a kernel crash: ... mx3-camera mx3-camera.0: Providing format Bayer BGGR (sRGB) 8 bit using code 11 Unable to handle kernel NULL pointer dereference at virtual address 0004 ... Fix it by incrementing 'xlate' a

[PATCH] soc_camera: Fix debug output of supported formats count

2009-06-15 Thread Stefan Herbrechtsmeier
The supported formats count must be set to 0 after debug output right before the second pass. Signed-off-by: Stefan Herbrechtsmeier diff --git a/linux/drivers/media/video/soc_camera.c b/linux/drivers/media/video/soc_camera.c --- a/linux/drivers/media/video/soc_camera.c +++ b/linux/drivers

Re: [PATCH] soc_camera: Fix debug output of supported formats count

2009-06-11 Thread Guennadi Liakhovetski
On Thu, 2 Apr 2009, Stefan Herbrechtsmeier wrote: > The supported formats count must be set to 0 after debug output > right before the second pass. > Hi Stefan, could you please resend with your Sob? Thanks Guennadi > diff --git a/linux/drivers/media/video/soc_camera.c >

[PATCH] soc_camera: Fix debug output of supported formats count

2009-04-02 Thread Stefan Herbrechtsmeier
The supported formats count must be set to 0 after debug output right before the second pass. diff --git a/linux/drivers/media/video/soc_camera.c b/linux/drivers/media/video/soc_camera.c --- a/linux/drivers/media/video/soc_camera.c +++ b/linux/drivers/media/video/soc_camera.c @@ -236,11 +236,11

Re: [PATCH] Remove debug output from stb6100_cfg.h

2009-03-27 Thread Manu Abraham
Mauro Carvalho Chehab wrote: > Manu, > > If ok to you, please ack. > > On Thu, 26 Mar 2009 10:45:53 +0100 > Artem Makhutov wrote: > > This patch removes the debug output from stb6100_cfg.h as it is flooding > the syslog with tuning data during normal operation

Re: [PATCH] Remove debug output from stb6100_cfg.h

2009-03-27 Thread Mauro Carvalho Chehab
Manu, If ok to you, please ack. On Thu, 26 Mar 2009 10:45:53 +0100 Artem Makhutov wrote: This patch removes the debug output from stb6100_cfg.h as it is flooding the syslog with tuning data during normal operation. Signed-off-by: Artem Makhutov --- linux.old/drivers/media/dvb/frontends

[PATCH] Remove debug output from stb6100_cfg.h

2009-03-26 Thread Artem Makhutov
This patch removes the debug output from stb6100_cfg.h as it is flooding the syslog with tuning data during normal operation. Signed-off-by: Artem Makhutov --- linux.old/drivers/media/dvb/frontends/stb6100_cfg.h 2009-03-26 10:28:57.0 +0100 +++ linux/drivers/media/dvb/frontends