Re: [PATCH v4 00/11] media: Report camera sensor properties

2019-10-18 Thread Sakari Ailus
Hi Jacopo, On Mon, Oct 07, 2019 at 06:29:02PM +0200, Jacopo Mondi wrote: > Hello, fourth iteration following: > > "media: v4l2-ctrls: Add camera sensor location" > https://patchwork.kernel.org/project/linux-media/list/?series=160901 > "[v2,00/10] media: Report ca

[PATCH v4 00/11] media: Report camera sensor properties

2019-10-07 Thread Jacopo Mondi
Hello, fourth iteration following: "media: v4l2-ctrls: Add camera sensor location" https://patchwork.kernel.org/project/linux-media/list/?series=160901 "[v2,00/10] media: Report camera sensor properties https://patchwork.kernel.org/cover/6443/ "[PATCH v3 00/11] media:

[PATCH 1/1] v4l: Put camera sensor, lens and flash drivers under MEDIA_CAMERA_SUPPORT

2019-09-23 Thread Sakari Ailus
Instead of individually depending on MEDIA_CAMERA_SUPPORT (or forgetting it), put all camera sensor, lens and flash drivers under MEDIA_CAMERA_SUPPORT as a whole. The lens VCM devices didn't use to do this, but make them depend on MEDIA_CAMERA_SUPPORT as well since there's no use for the

Re: [V2, 2/2] media: i2c: Add more sensor modes for ov8856 camera sensor

2019-09-13 Thread Sakari Ailus
Hi Dongchun, On Tue, Sep 10, 2019 at 09:04:46PM +0800, dongchun@mediatek.com wrote: > From: Dongchun Zhu > > This patch mainly adds two more sensor modes for OV8856 CMOS image sensor. > That is, the resolution of 1632*1224 and 3264*2448, corresponding to the > bayer order of BGGR. > The sen

[PATCH v3 00/11] media: Report camera sensor properties

2019-09-12 Thread Jacopo Mondi
Hello, third iteration following: "media: v4l2-ctrls: Add camera sensor location" https://patchwork.kernel.org/project/linux-media/list/?series=160901 "[v2,00/10] media: Report camera sensor properties https://patchwork.kernel.org/cover/6443/ Compared to v2 I have dropped

Re: [V2, 2/2] media: i2c: Add more sensor modes for ov8856 camera sensor

2019-09-10 Thread Andy Shevchenko
On Tue, Sep 10, 2019 at 09:04:46PM +0800, dongchun@mediatek.com wrote: > From: Dongchun Zhu > > This patch mainly adds two more sensor modes for OV8856 CMOS image sensor. > That is, the resolution of 1632*1224 and 3264*2448, corresponding to the > bayer order of BGGR. > The sensor revision a

[V2, 2/2] media: i2c: Add more sensor modes for ov8856 camera sensor

2019-09-10 Thread dongchun.zhu
From: Dongchun Zhu This patch mainly adds two more sensor modes for OV8856 CMOS image sensor. That is, the resolution of 1632*1224 and 3264*2448, corresponding to the bayer order of BGGR. The sensor revision also differs in some OTP register. Signed-off-by: Dongchun Zhu --- drivers/media/i2c/

Re: [V1, 2/2] media: i2c: Add more sensor mode for ov8856 camera sensor

2019-09-09 Thread Sakari Ailus
Hi Dongchun, On Mon, Sep 09, 2019 at 04:46:15PM +0800, Dongchun Zhu wrote: > Hi Sakari, > > On Thu, 2019-08-08 at 16:53 +0300, Sakari Ailus wrote: > > Hi Dongchun, > > > > Thanks for the patch. > > > > On Thu, Aug 08, 2019 at 05:22:15PM +0800, dongchun@mediatek.com wrote: > > > From: Dongch

Re: [V1, 2/2] media: i2c: Add more sensor mode for ov8856 camera sensor

2019-09-09 Thread Dongchun Zhu
Hi Tomasz, On Fri, 2019-08-23 at 19:01 +0900, Tomasz Figa wrote: > Hi Dongchun, > > On Thu, Aug 08, 2019 at 05:22:15PM +0800, dongchun@mediatek.com wrote: > > From: Dongchun Zhu > > > > This patch mainly adds two more sensor modes for OV8856 image sensor. > > The OV8856 driver currently sup

Re: [V1, 2/2] media: i2c: Add more sensor mode for ov8856 camera sensor

2019-09-09 Thread Dongchun Zhu
Hi Sakari, On Thu, 2019-08-08 at 16:53 +0300, Sakari Ailus wrote: > Hi Dongchun, > > Thanks for the patch. > > On Thu, Aug 08, 2019 at 05:22:15PM +0800, dongchun@mediatek.com wrote: > > From: Dongchun Zhu > > > > This patch mainly adds two more sensor modes for OV8856 image sensor. > > The

Re: [V4, 2/2] media: i2c: Add Omnivision OV02A10 camera sensor driver

2019-09-08 Thread Sakari Ailus
Hi Dongchun, Thanks for the update. A few more comments below. On Sat, Sep 07, 2019 at 05:27:28PM +0800, dongchun@mediatek.com wrote: > From: Dongchun Zhu > > This patch adds a V4L2 sub-device driver for OV02A10 image sensor. > The OV02A10 is a 1/5" CMOS sensor from Omnivision, > supporting

Re: [V4, 2/2] media: i2c: Add Omnivision OV02A10 camera sensor driver

2019-09-07 Thread kbuild test robot
Hi, I love your patch! Perhaps something to improve: [auto build test WARNING on linuxtv-media/master] [cannot apply to v5.3-rc7 next-20190904] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/do

Re: [V4, 2/2] media: i2c: Add Omnivision OV02A10 camera sensor driver

2019-09-07 Thread kbuild test robot
Hi, I love your patch! Perhaps something to improve: [auto build test WARNING on linuxtv-media/master] [cannot apply to v5.3-rc7 next-20190904] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/do

[V4, 2/2] media: i2c: Add Omnivision OV02A10 camera sensor driver

2019-09-07 Thread dongchun.zhu
From: Dongchun Zhu This patch adds a V4L2 sub-device driver for OV02A10 image sensor. The OV02A10 is a 1/5" CMOS sensor from Omnivision, supporting output format: 10-bit Raw. The OV02A10 has a single MIPI lane interface and use the I2C bus for control and the CSI-2 bus for data. Signed-off-by:

Re: [V3, 2/2] media: i2c: Add Omnivision OV02A10 camera sensor driver

2019-09-05 Thread Dongchun Zhu
Hi Tomasz, Thanks very much for your careful review. Reply to the comments see belows. Any missing please let me know. On Wed, 2019-08-21 at 19:30 +0900, Tomasz Figa wrote: > Hi Dongchun, > > On Mon, Aug 19, 2019 at 11:43:31AM +0800, dongchun@mediatek.com wrote: > > From: Dongchun Zhu > >

Re: [V3, 2/2] media: i2c: Add Omnivision OV02A10 camera sensor driver

2019-09-05 Thread Sakari Ailus
Hi Dongchun, On Thu, Sep 05, 2019 at 05:41:05PM +0800, Dongchun Zhu wrote: ... > > > + ret = regulator_bulk_enable(OV02A10_NUM_SUPPLIES, ov02a10->supplies); > > > + if (ret < 0) { > > > + dev_err(dev, "Failed to enable regulators\n"); > > > + goto disable_clk; > > > + } > > > + m

Re: [V3, 2/2] media: i2c: Add Omnivision OV02A10 camera sensor driver

2019-09-05 Thread Dongchun Zhu
Hi Sakari, On Mon, 2019-08-19 at 11:30 +0300, Sakari Ailus wrote: > Hi Dongchun, > > Thanks for the update. > > On Mon, Aug 19, 2019 at 11:43:31AM +0800, dongchun@mediatek.com wrote: > > From: Dongchun Zhu > > > > This patch adds a V4L2 sub-device driver for OV02A10 image sensor. > > The O

[PATCH v2 00/10] media: Report camera sensor properties

2019-08-27 Thread Jacopo Mondi
Hello, this second version of this series includes both the previously sent "media: v4l2-ctrls: Add camera sensor location" https://patchwork.kernel.org/project/linux-media/list/?series=160901 "media: i2c: ov5670: Report native size and crop bounds" https://patchwork.kern

Re: [V1, 2/2] media: i2c: Add more sensor mode for ov8856 camera sensor

2019-08-23 Thread Tomasz Figa
Hi Dongchun, On Thu, Aug 08, 2019 at 05:22:15PM +0800, dongchun@mediatek.com wrote: > From: Dongchun Zhu > > This patch mainly adds two more sensor modes for OV8856 image sensor. > The OV8856 driver currently supports output format: 10-bit Raw, > the resolution of 1632*1224 and 3264*2448, an

Re: [V3, 2/2] media: i2c: Add Omnivision OV02A10 camera sensor driver

2019-08-21 Thread Sakari Ailus
Hi Tomasz, On Wed, Aug 21, 2019 at 07:30:38PM +0900, Tomasz Figa wrote: ... > > + > > +/* > > + * xvclk 24Mhz > > This seems to assume 24MHz, but the driver allows a range in probe. Is that > correct? I think it'd be better to check for an exact frequency: this is board specific and its exact va

Re: [V3, 2/2] media: i2c: Add Omnivision OV02A10 camera sensor driver

2019-08-21 Thread Tomasz Figa
Hi Dongchun, On Mon, Aug 19, 2019 at 11:43:31AM +0800, dongchun@mediatek.com wrote: > From: Dongchun Zhu > > This patch adds a V4L2 sub-device driver for OV02A10 image sensor. > The OV02A10 is a 1/5" CMOS sensor from Omnivision, > which supports output format: 10-bit Raw. > The OV02A10 has a

Re: [V3, 2/2] media: i2c: Add Omnivision OV02A10 camera sensor driver

2019-08-19 Thread Sakari Ailus
Hi Dongchun, Thanks for the update. On Mon, Aug 19, 2019 at 11:43:31AM +0800, dongchun@mediatek.com wrote: > From: Dongchun Zhu > > This patch adds a V4L2 sub-device driver for OV02A10 image sensor. > The OV02A10 is a 1/5" CMOS sensor from Omnivision, > which supports output format: 10-bit

[V3, 2/2] media: i2c: Add Omnivision OV02A10 camera sensor driver

2019-08-18 Thread dongchun.zhu
From: Dongchun Zhu This patch adds a V4L2 sub-device driver for OV02A10 image sensor. The OV02A10 is a 1/5" CMOS sensor from Omnivision, which supports output format: 10-bit Raw. The OV02A10 has a single MIPI lane interface and use the I2C bus for control and the CSI-2 bus for data. Signed-off-b

Re: [RFC,V2,2/2] media: i2c: Add Omnivision OV02A10 camera sensor driver

2019-08-16 Thread Dongchun Zhu
..@lists.infradead.org; Louis Kuo (郭德寧) > ; linux-arm-ker...@lists.infradead.org; > linux-media@vger.kernel.org > Subject: Re: [RFC,V2,2/2] media: i2c: Add Omnivision OV02A10 camera sensor > driver > > > > On 7/4/19 4:46 PM, dongchun@mediatek.com wrote: > >

Re: [V1, 2/2] media: i2c: Add more sensor mode for ov8856 camera sensor

2019-08-08 Thread Sakari Ailus
Hi Dongchun, Thanks for the patch. On Thu, Aug 08, 2019 at 05:22:15PM +0800, dongchun@mediatek.com wrote: > From: Dongchun Zhu > > This patch mainly adds two more sensor modes for OV8856 image sensor. > The OV8856 driver currently supports output format: 10-bit Raw, > the resolution of 1632

[V1, 2/2] media: i2c: Add more sensor mode for ov8856 camera sensor

2019-08-08 Thread dongchun.zhu
From: Dongchun Zhu This patch mainly adds two more sensor modes for OV8856 image sensor. The OV8856 driver currently supports output format: 10-bit Raw, the resolution of 1632*1224 and 3264*2448, and the bayer order of BGGR. The hardware version also differs in some OTP regiser, as well as PLL re

Re: [RFC,V2,2/2] media: i2c: Add Omnivision OV02A10 camera sensor driver

2019-07-08 Thread Bingbu Cao
On 7/4/19 4:46 PM, dongchun@mediatek.com wrote: > From: Dongchun Zhu > > This patch adds a V4L2 sub-device driver for OV02A10 image sensor. > The OV02A10 is a 1/5" CMOS sensor from Omnivision. > Supports output format: 10-bit Raw. > The OV02A10 has a single MIPI lane interface and use the

[RFC,V2,2/2] media: i2c: Add Omnivision OV02A10 camera sensor driver

2019-07-04 Thread dongchun.zhu
From: Dongchun Zhu This patch adds a V4L2 sub-device driver for OV02A10 image sensor. The OV02A10 is a 1/5" CMOS sensor from Omnivision. Supports output format: 10-bit Raw. The OV02A10 has a single MIPI lane interface and use the I2C bus for control and the CSI-2 bus for data. Signed-off-by: Do

Re: [PATCH 1/3] media: i2c: ov02a10: Add ov02a10 camera sensor driver

2019-06-26 Thread Sakari Ailus
Hi Dongchun, On Tue, Jun 11, 2019 at 10:09:49PM +0800, Dongchun Zhu wrote: ... > > > + return -EINVAL; > > > + > > > + fse->code = MEDIA_BUS_FMT_SBGGR10_1X10; > > > > Instead you need check the caller set this. The frame sizes could be > > different for different media bus formats. > > >

Re: [PATCH 1/3] media: i2c: ov02a10: Add ov02a10 camera sensor driver

2019-06-13 Thread Dongchun Zhu
Hi Nicolas, On Sun, 2019-05-26 at 16:53 +0800, Nicolas Boichat wrote: > On Thu, May 23, 2019 at 6:22 PM wrote: > > > > From: Dongchun Zhu > > > > Add a V4L2 sub-device driver for the OmniVision image sensor. > > This is a camera sensor using the I2C bus for

Re: [PATCH 1/3] media: i2c: ov02a10: Add ov02a10 camera sensor driver

2019-06-13 Thread Dongchun Zhu
Hi Bingbu, On Tue, 2019-05-28 at 14:20 +0800, Bingbu Cao wrote: > > On 5/23/19 6:22 PM, dongchun@mediatek.com wrote: > > From: Dongchun Zhu > > > > Add a V4L2 sub-device driver for the OmniVision image sensor. > > This is a camera sensor using the I2C bus for

Re: [PATCH 1/3] media: i2c: ov02a10: Add ov02a10 camera sensor driver

2019-06-11 Thread Dongchun Zhu
Hi Sakari, On Fri, 2019-05-31 at 20:03 +0300, Sakari Ailus wrote: > Hi Dongchun, > > On Thu, May 23, 2019 at 06:22:02PM +0800, dongchun@mediatek.com wrote: > > From: Dongchun Zhu > > > > Add a V4L2 sub-device driver for the OmniVision image sensor. > > This

Re: [PATCH 1/3] media: i2c: ov02a10: Add ov02a10 camera sensor driver

2019-05-31 Thread Sakari Ailus
Hi Dongchun, On Thu, May 23, 2019 at 06:22:02PM +0800, dongchun@mediatek.com wrote: > From: Dongchun Zhu > > Add a V4L2 sub-device driver for the OmniVision image sensor. > This is a camera sensor using the I2C bus for control and the > CSI-2 bus for data. > > Signed

Re: [PATCH 1/3] media: i2c: ov02a10: Add ov02a10 camera sensor driver

2019-05-27 Thread Bingbu Cao
On 5/23/19 6:22 PM, dongchun@mediatek.com wrote: > From: Dongchun Zhu > > Add a V4L2 sub-device driver for the OmniVision image sensor. > This is a camera sensor using the I2C bus for control and the > CSI-2 bus for data. > > Signed-off-by: Dongchun Zhu >

Re: [PATCH 1/3] media: i2c: ov02a10: Add ov02a10 camera sensor driver

2019-05-26 Thread Nicolas Boichat
On Thu, May 23, 2019 at 6:22 PM wrote: > > From: Dongchun Zhu > > Add a V4L2 sub-device driver for the OmniVision image sensor. > This is a camera sensor using the I2C bus for control and the > CSI-2 bus for data. > > Signed-off-by: Dongchun Zhu > --- > driv

[PATCH 1/3] media: i2c: ov02a10: Add ov02a10 camera sensor driver

2019-05-23 Thread dongchun.zhu
From: Dongchun Zhu Add a V4L2 sub-device driver for the OmniVision image sensor. This is a camera sensor using the I2C bus for control and the CSI-2 bus for data. Signed-off-by: Dongchun Zhu --- drivers/media/i2c/Makefile |1 + drivers/media/i2c/ov02a10.c | 1067

Re: [PATCH 4/6] ARM: dts: sun8i: a83t: Add device node for CSI (Camera Sensor Interface)

2019-05-20 Thread Ondřej Jirman
> > > > > > wrote: > > > > > > > On Tue, Apr 09, 2019 at 12:57:42AM +0800, Chen-Yu Tsai wrote: > > > > > > > > From: Chen-Yu Tsai > > > > > > > > > > > > > > > > The A83T SoC has a camera

Re: [PATCH 0/2] Remove more SoC camera sensor drivers

2019-02-07 Thread Hans Verkuil
On 2/4/19 4:42 PM, Sakari Ailus wrote: > Hi folks, > > This set removes two additional SoC camera sensor drivers that have > corresponding V4L2 sub-device drivers. > > Sakari Ailus (2): > soc_camera: Remove the mt9m001 SoC camera sensor driver > soc_camera: Remo

[PATCH 1/2] soc_camera: Remove the mt9m001 SoC camera sensor driver

2019-02-04 Thread Sakari Ailus
There is a V4L2 sub-device sensor driver for the mt9m001. Remove the SoC camera one. Signed-off-by: Sakari Ailus --- drivers/media/i2c/soc_camera/Kconfig | 7 - drivers/media/i2c/soc_camera/Makefile | 1 - drivers/media/i2c/soc_camera/soc_mt9m001.c | 757 --

[PATCH 0/2] Remove more SoC camera sensor drivers

2019-02-04 Thread Sakari Ailus
Hi folks, This set removes two additional SoC camera sensor drivers that have corresponding V4L2 sub-device drivers. Sakari Ailus (2): soc_camera: Remove the mt9m001 SoC camera sensor driver soc_camera: Remove the rj45n1 SoC camera sensor driver drivers/media/i2c/soc_camera/Kconfig

[PATCH 2/2] soc_camera: Remove the rj45n1 SoC camera sensor driver

2019-02-04 Thread Sakari Ailus
There is a V4L2 sub-device sensor driver for the rj45n1. Remove the SoC camera one. Signed-off-by: Sakari Ailus --- drivers/media/i2c/soc_camera/Kconfig |6 - drivers/media/i2c/soc_camera/Makefile |1 - drivers/media/i2c/soc_camera/soc_rj54n1cb0c.c | 1415 ---

Re: [PATCH v12 1/2] dt-bindings: media: Add Allwinner V3s Camera Sensor Interface (CSI)

2018-11-23 Thread Yong
> > > create mode 100644 > > > > > Documentation/devicetree/bindings/media/sun6i-csi.txt > > > > > > > > > > diff --git a/Documentation/devicetree/bindings/media/sun6i-csi.txt > > > > > b/Documentation/devicetree/bindings/media/su

Re: [PATCH v12 1/2] dt-bindings: media: Add Allwinner V3s Camera Sensor Interface (CSI)

2018-11-23 Thread jacopo mondi
+ > > > > 1 file changed, 56 insertions(+) > > > > create mode 100644 > > > > Documentation/devicetree/bindings/media/sun6i-csi.txt > > > > > > > > diff --git a/Documentation/devicetree/bindings/media/sun6i-csi.txt >

Re: [PATCH v12 1/2] dt-bindings: media: Add Allwinner V3s Camera Sensor Interface (CSI)

2018-11-23 Thread Yong
; > diff --git a/Documentation/devicetree/bindings/media/sun6i-csi.txt > > > b/Documentation/devicetree/bindings/media/sun6i-csi.txt new file mode > > > 100644 > > > index ..443e18c181b3 > > > --- /dev/null > > > +++ b/Documentation/devicetr

Re: [PATCH v12 1/2] dt-bindings: media: Add Allwinner V3s Camera Sensor Interface (CSI)

2018-11-22 Thread jacopo mondi
..443e18c181b3 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/media/sun6i-csi.txt > > @@ -0,0 +1,56 @@ > > +Allwinner V3s Camera Sensor Interface > > +- > > + > > +Allwinner V3s SoC features a CSI module(CSI1) with

Re: [PATCH] dt-bindings: media: i2c: Fix i2c address for OV5645 camera sensor

2018-11-17 Thread Rob Herring
On Fri, 9 Nov 2018 13:26:43 +0530, Manivannan Sadhasivam wrote: > The i2c address for the Omnivision OV5645 camera sensor is 0x3c. It is > incorrectly mentioned as 0x78 in binding. Hence fix that. > > Fixes: 09c716af36e6 [media] media: i2c/ov5645: add the device tree binding > do

Re: [PATCH 0/7] media: i2c: small enhancements for camera sensor drivers

2018-11-13 Thread jacopo mondi
Hello Mita-san, thanks for the patches On Tue, Nov 13, 2018 at 01:00:47AM +0900, Akinobu Mita wrote: > This patchset addds relatively small enhancements (log_status ioctl, event > interface, V4L2_CID_TEST_PATTERN control, and V4L2_CID_COLORFX control) for > mt9m111, ov2640, ov5640, ov7670, and

[PATCH 0/7] media: i2c: small enhancements for camera sensor drivers

2018-11-12 Thread Akinobu Mita
This patchset addds relatively small enhancements (log_status ioctl, event interface, V4L2_CID_TEST_PATTERN control, and V4L2_CID_COLORFX control) for mt9m111, ov2640, ov5640, ov7670, and ov772x drivers. I have these devices so these patches are tested with real devices. Akinobu Mita (7): media

Re: [PATCH] dt-bindings: media: i2c: Fix i2c address for OV5645 camera sensor

2018-11-09 Thread Todor Tomov
Hi Mani, On 9.11.2018 09:56, Manivannan Sadhasivam wrote: > The i2c address for the Omnivision OV5645 camera sensor is 0x3c. It is > incorrectly mentioned as 0x78 in binding. Hence fix that. The seven bit i2c address of ov5645 is really 0x3c. Thank you for finding this and sending t

[PATCH] dt-bindings: media: i2c: Fix i2c address for OV5645 camera sensor

2018-11-08 Thread Manivannan Sadhasivam
The i2c address for the Omnivision OV5645 camera sensor is 0x3c. It is incorrectly mentioned as 0x78 in binding. Hence fix that. Fixes: 09c716af36e6 [media] media: i2c/ov5645: add the device tree binding document Signed-off-by: Manivannan Sadhasivam --- Documentation/devicetree/bindings/media

Re: [PATCH v12 1/2] dt-bindings: media: Add Allwinner V3s Camera Sensor Interface (CSI)

2018-10-30 Thread Laurent Pinchart
gt; b/Documentation/devicetree/bindings/media/sun6i-csi.txt new file mode > 100644 > index ..443e18c181b3 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/sun6i-csi.txt > @@ -0,0 +1,56 @@ > +Allwinner V3s Camera Sensor Interface > +-

[PATCH v12 1/2] dt-bindings: media: Add Allwinner V3s Camera Sensor Interface (CSI)

2018-10-30 Thread Yong Deng
@@ -0,0 +1,56 @@ +Allwinner V3s Camera Sensor Interface +- + +Allwinner V3s SoC features a CSI module(CSI1) with parallel interface. + +Required properties: + - compatible: value must be "allwinner,sun8i-v3s-csi" + - reg: base address and size of the mem

Re: [PATCH v7] media: add imx319 camera sensor driver

2018-10-20 Thread Tomasz Figa
900, Tomasz Figa wrote: > > > > > > Hi Sakari, > > > > > > > > > > > > On Wed, Sep 26, 2018 at 11:38 AM wrote: > > > > > > > > > > > > > > From: Bingbu Cao > > > > > > > > > > &g

Re: [PATCH v7] media: add imx319 camera sensor driver

2018-10-20 Thread Sakari Ailus
38 AM wrote: > > > > > > > > > > > > From: Bingbu Cao > > > > > > > > > > > > Add a v4l2 sub-device driver for the Sony imx319 image sensor. > > > > > > This is a camera sensor using the i2c bus

Re: [PATCH v7] media: add imx319 camera sensor driver

2018-10-17 Thread Tomasz Figa
On Fri, Oct 12, 2018 at 01:51:10PM +0900, Tomasz Figa wrote: > > > > Hi Sakari, > > > > > > > > On Wed, Sep 26, 2018 at 11:38 AM wrote: > > > > > > > > > > From: Bingbu Cao > > > > > > > > > > Add a v

Re: [linux-sunxi] [PATCH v11 1/2] dt-bindings: media: Add Allwinner V3s Camera Sensor Interface (CSI)

2018-10-17 Thread Jagan Teki
t > new file mode 100644 > index ..2ff47a9507a6 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/sun6i-csi.txt > @@ -0,0 +1,59 @@ > +Allwinner V3s Camera Sensor Interface > +- > + > +Allwinner V3s SoC features two C

Re: [PATCH v7] media: add imx319 camera sensor driver

2018-10-16 Thread Sakari Ailus
t; > > > On Wed, Sep 26, 2018 at 11:38 AM wrote: > > > > > > > > From: Bingbu Cao > > > > > > > > Add a v4l2 sub-device driver for the Sony imx319 image sensor. > > > > This is a camera sensor using the i2c bus for control and the >

Re: [PATCH v7] media: add imx319 camera sensor driver

2018-10-12 Thread Tomasz Figa
; > > Add a v4l2 sub-device driver for the Sony imx319 image sensor. > > > This is a camera sensor using the i2c bus for control and the > > > csi-2 bus for data. > > > > > > This driver supports following features: > > > - manual exposure and ana

Re: [PATCH v7] media: add imx319 camera sensor driver

2018-10-12 Thread Sakari Ailus
Hi Tomasz, On Fri, Oct 12, 2018 at 01:51:10PM +0900, Tomasz Figa wrote: > Hi Sakari, > > On Wed, Sep 26, 2018 at 11:38 AM wrote: > > > > From: Bingbu Cao > > > > Add a v4l2 sub-device driver for the Sony imx319 image sensor. > > This is a camera senso

Re: [PATCH v7] media: add imx319 camera sensor driver

2018-10-11 Thread Tomasz Figa
Hi Sakari, On Wed, Sep 26, 2018 at 11:38 AM wrote: > > From: Bingbu Cao > > Add a v4l2 sub-device driver for the Sony imx319 image sensor. > This is a camera sensor using the i2c bus for control and the > csi-2 bus for data. > > This driver supports following features:

[PATCH v11 2/3] [media] imx214: Add imx214 camera sensor driver

2018-10-05 Thread Ricardo Ribalda Delgado
Add a V4L2 sub-device driver for the Sony IMX214 image sensor. This is a camera sensor using the I2C bus for control and the CSI-2 bus for data. Tested on a DB820c alike board with Intrinsyc Open-Q 13MP camera. Signed-off-by: Ricardo Ribalda Delgado Reviewed-by: Jacopo Mondi --- Changelog from

[PATCH v8 2/3] [media] imx214: Add imx214 camera sensor driver

2018-10-05 Thread Ricardo Ribalda Delgado
Add a V4L2 sub-device driver for the Sony IMX214 image sensor. This is a camera sensor using the I2C bus for control and the CSI-2 bus for data. Tested on a DB820c alike board with Intrinsyc Open-Q 13MP camera. Signed-off-by: Ricardo Ribalda Delgado Reviewed-by: Jacopo Mondi --- Changelog from

Re: [PATCH v7 2/2] [media] imx214: Add imx214 camera sensor driver

2018-10-05 Thread Sakari Ailus
Hi Ricardo, Thanks for the update. On Thu, Oct 04, 2018 at 04:08:33PM +0200, Ricardo Ribalda Delgado wrote: > Add a V4L2 sub-device driver for the Sony IMX214 image sensor. > This is a camera sensor using the I2C bus for control and the > CSI-2 bus for data. > > Tested on a DB8

Re: [PATCH v5] media: imx208: Add imx208 camera sensor driver

2018-10-04 Thread Sakari Ailus
Hi Ping-chung, On Thu, Sep 27, 2018 at 03:19:07AM +, Chen, Ping-chung wrote: > Hi, > > >-Original Message- > >From: Yeh, Andy > >Sent: Wednesday, September 26, 2018 11:19 PM > >To: Sakari Ailus ; Chen, Ping-chung > > > > >Hi Sakari, PC, > > >sensors that do need >digital gain appl

Re: [PATCH v5] media: imx208: Add imx208 camera sensor driver

2018-10-01 Thread Philippe De Muyter
Hi, On Mon, Oct 01, 2018 at 12:50:02PM +0200, Helmut Grohne wrote: > Hi Laurent, > > On Fri, Sep 28, 2018 at 03:49:38PM +0200, Laurent Pinchart wrote: > > I don't think we'll reach an agreement here if we don't start talking about > > real use cases. Would you have some to share ? > > Fair enou

Re: [PATCH v5] media: imx208: Add imx208 camera sensor driver

2018-10-01 Thread Helmut Grohne
Hi Laurent, On Fri, Sep 28, 2018 at 03:49:38PM +0200, Laurent Pinchart wrote: > I don't think we'll reach an agreement here if we don't start talking about > real use cases. Would you have some to share ? Fair enough, but at that point, we very much disconnect from the imx208 in the subject. I'

Re: [PATCH v3] media: add imx355 camera sensor driver

2018-10-01 Thread Sakari Ailus
Hi Bingbu, On Sat, Sep 29, 2018 at 06:03:54PM +0800, bingbu@intel.com wrote: > From: Bingbu Cao > > Add a v4l2 sub-device driver for the Sony imx355 image sensor. > This is a camera sensor using the i2c bus for control and the > csi-2 bus for data. > > This driv

[PATCH v3] media: add imx355 camera sensor driver

2018-09-29 Thread bingbu . cao
From: Bingbu Cao Add a v4l2 sub-device driver for the Sony imx355 image sensor. This is a camera sensor using the i2c bus for control and the csi-2 bus for data. This driver supports following features: - manual exposure and analog/digital gain control support - vblank/hblank control support

Re: [PATCH v5] media: imx208: Add imx208 camera sensor driver

2018-09-28 Thread Laurent Pinchart
Hi Helmut, On Friday, 21 September 2018 10:23:37 EEST Helmut Grohne wrote: > On Thu, Sep 20, 2018 at 11:00:26PM +0200, Laurent Pinchart wrote: > > On Thursday, 20 September 2018 23:16:47 EEST Sylwester Nawrocki wrote: > >> On 09/20/2018 06:49 PM, Grant Grundler wrote: > >>> On Thu, Sep 20, 2018 at

RE: [PATCH v5] media: imx208: Add imx208 camera sensor driver

2018-09-26 Thread Chen, Ping-chung
Hi, >-Original Message- >From: Yeh, Andy >Sent: Wednesday, September 26, 2018 11:19 PM >To: Sakari Ailus ; Chen, Ping-chung > >Hi Sakari, PC, >sensors that do need >digital gain applied, too --- assuming it'd be >combined with the TRY_EXT_CTRLS rounding flags. >> >> There might be man

RE: [PATCH v5] media: imx208: Add imx208 camera sensor driver

2018-09-26 Thread Yeh, Andy
mail.com; linux-media me...@vger.kernel.org>; Yeh, Andy ; Lai, Jim >; grund...@chromium.org; Mani, Rajmohan > >Subject: Re: [PATCH v5] media: imx208: Add imx208 camera sensor driver > >Hi Ping-chung, > >On Wed, Sep 26, 2018 at 02:27:01AM +, Chen, Ping-chung wrot

Re: [PATCH v5] media: imx208: Add imx208 camera sensor driver

2018-09-26 Thread Sakari Ailus
Hi Ping-chung, On Wed, Sep 26, 2018 at 02:27:01AM +, Chen, Ping-chung wrote: > Hi Sakari, > > >-Original Message- > >From: Sakari Ailus [mailto:sakari.ai...@linux.intel.com] > >Sent: Wednesday, September 26, 2018 5:55 AM > > >Hi Ping-chung, > > >On Tue, Sep 25, 2018 at 10:17:48AM +

Re: [PATCH v7] media: add imx319 camera sensor driver

2018-09-26 Thread Bing Bu Cao
On 09/26/2018 03:57 PM, Sakari Ailus wrote: > Hi Bingbu, > > On Wed, Sep 26, 2018 at 10:42:18AM +0800, bingbu@intel.com wrote: >> From: Bingbu Cao >> >> Add a v4l2 sub-device driver for the Sony imx319 image sensor. >> This is a camera sensor using the i2c

Re: [PATCH v7] media: add imx319 camera sensor driver

2018-09-26 Thread Sakari Ailus
Hi Bingbu, On Wed, Sep 26, 2018 at 10:42:18AM +0800, bingbu@intel.com wrote: > From: Bingbu Cao > > Add a v4l2 sub-device driver for the Sony imx319 image sensor. > This is a camera sensor using the i2c bus for control and the > csi-2 bus for data. > > This driv

[PATCH v7] media: add imx319 camera sensor driver

2018-09-25 Thread bingbu . cao
From: Bingbu Cao Add a v4l2 sub-device driver for the Sony imx319 image sensor. This is a camera sensor using the i2c bus for control and the csi-2 bus for data. This driver supports following features: - manual exposure and analog/digital gain control support - vblank/hblank control support

RE: [PATCH v5] media: imx208: Add imx208 camera sensor driver

2018-09-25 Thread Chen, Ping-chung
Hi Sakari, >-Original Message- >From: Sakari Ailus [mailto:sakari.ai...@linux.intel.com] >Sent: Wednesday, September 26, 2018 5:55 AM >Hi Ping-chung, >On Tue, Sep 25, 2018 at 10:17:48AM +, Chen, Ping-chung wrote: >... > > > > Controls that have a documented unit use that unit --- as

Re: [PATCH v5] media: imx208: Add imx208 camera sensor driver

2018-09-25 Thread Sakari Ailus
Hi Ping-chung, On Tue, Sep 25, 2018 at 10:17:48AM +, Chen, Ping-chung wrote: ... > > > > Controls that have a documented unit use that unit --- as long as > > > > that's the unit used by the hardware. If it's not, it tends to be > > > > that another unit is used but the user space has curren

RE: [PATCH v5] media: imx208: Add imx208 camera sensor driver

2018-09-25 Thread Chen, Ping-chung
Hi Sakari, >-Original Message- >From: Sakari Ailus [mailto:sakari.ai...@linux.intel.com] >Sent: Tuesday, September 25, 2018 5:25 PM >To: Chen, Ping-chung >Cc: Ricardo Ribalda Delgado ; Laurent Pinchart >Subject: Re: [PATCH v5] media: imx208: Add imx208 camera senso

Re: [PATCH v6] media: add imx319 camera sensor driver

2018-09-25 Thread Sakari Ailus
Hi Bingbu, On Tue, Sep 25, 2018 at 05:10:59PM +0800, Bing Bu Cao wrote: ... > > +/* Initialize control handlers */ > > +static int imx319_init_controls(struct imx319 *imx319) > > +{ > > + struct i2c_client *client = v4l2_get_subdevdata(&imx319->sd); > > + struct v4l

Re: [PATCH v5] media: imx208: Add imx208 camera sensor driver

2018-09-25 Thread Sakari Ailus
Ailus ; tf...@chromium.org; Sakari Ailus > ; sylwester.nawro...@gmail.com; linux-media > ; Yeh, Andy ; Lai, Jim > ; grund...@chromium.org; Mani, Rajmohan > > Subject: RE: [PATCH v5] media: imx208: Add imx208 camera sensor driver > > Hi Sakari, > > >-Original Me

Re: [PATCH v6] media: add imx319 camera sensor driver

2018-09-25 Thread Bing Bu Cao
>>>> On Fri, Sep 21, 2018 at 05:41:55PM +0800, bingbu@intel.com wrote: >>>>> From: Bingbu Cao >>>>> >>>>> Add a v4l2 sub-device driver for the Sony imx319 image sensor. >>>>> This is a camera sensor using the i2c bus for con

Re: [PATCH v6] media: add imx319 camera sensor driver

2018-09-25 Thread Sakari Ailus
ngbu@intel.com wrote: > >>> From: Bingbu Cao > >>> > >>> Add a v4l2 sub-device driver for the Sony imx319 image sensor. > >>> This is a camera sensor using the i2c bus for control and the > >>> csi-2 bus for data. > >>> >

Re: [PATCH v6] media: add imx319 camera sensor driver

2018-09-24 Thread Bing Bu Cao
On 09/25/2018 11:57 AM, Bing Bu Cao wrote: > > On 09/21/2018 08:06 PM, Sakari Ailus wrote: >> Hi Bingbu, >> >> On Fri, Sep 21, 2018 at 05:41:55PM +0800, bingbu@intel.com wrote: >>> From: Bingbu Cao >>> >>> Add a v4l2 sub-device driver for

Re: [PATCH v6] media: add imx319 camera sensor driver

2018-09-24 Thread Bing Bu Cao
On 09/21/2018 08:06 PM, Sakari Ailus wrote: > Hi Bingbu, > > On Fri, Sep 21, 2018 at 05:41:55PM +0800, bingbu@intel.com wrote: >> From: Bingbu Cao >> >> Add a v4l2 sub-device driver for the Sony imx319 image sensor. >> This is a camera sensor using the i2c

Re: [PATCH v6] media: add imx319 camera sensor driver

2018-09-22 Thread kbuild test robot
/linux/commits/bingbu-cao-intel-com/media-add-imx319-camera-sensor-driver/20180922-115504 base: git://linuxtv.org/media_tree.git master config: openrisc-allmodconfig (attached as .config) compiler: or1k-linux-gcc (GCC) 6.0.0 20160327 (experimental) reproduce: wget https

Re: [PATCH v6] media: add imx319 camera sensor driver

2018-09-21 Thread Sakari Ailus
Hi Bingbu, On Fri, Sep 21, 2018 at 05:41:55PM +0800, bingbu@intel.com wrote: > From: Bingbu Cao > > Add a v4l2 sub-device driver for the Sony imx319 image sensor. > This is a camera sensor using the i2c bus for control and the > csi-2 bus for data. > > This driv

[PATCH v6] media: add imx319 camera sensor driver

2018-09-21 Thread bingbu . cao
From: Bingbu Cao Add a v4l2 sub-device driver for the Sony imx319 image sensor. This is a camera sensor using the i2c bus for control and the csi-2 bus for data. This driver supports following features: - manual exposure and analog/digital gain control support - vblank/hblank control support

Re: [PATCH v5] media: add imx319 camera sensor driver

2018-09-21 Thread Bing Bu Cao
On 09/21/2018 03:41 PM, Sakari Ailus wrote: > Hi Bingbu, > > On Fri, Sep 21, 2018 at 03:20:19PM +0800, Bing Bu Cao wrote: > ... + try_fmt->field = V4L2_FIELD_NONE; + + mutex_unlock(&imx319->mutex); + + return 0; +} + +static int imx319_update_digital_ga

Re: [PATCH v5] media: add imx319 camera sensor driver

2018-09-21 Thread Tomasz Figa
On Fri, Sep 21, 2018 at 11:28 AM Bing Bu Cao wrote: > > > On 09/18/2018 05:49 PM, Tomasz Figa wrote: > > Hi Bingbu, > > > > On Mon, Sep 17, 2018 at 2:53 PM wrote: > >> From: Bingbu Cao > >> > >> Add a v4l2 sub-device driver for the Sony i

Re: [PATCH v5] media: add imx319 camera sensor driver

2018-09-21 Thread Sakari Ailus
Hi Bingbu, On Fri, Sep 21, 2018 at 03:20:19PM +0800, Bing Bu Cao wrote: ... > >> + try_fmt->field = V4L2_FIELD_NONE; > >> + > >> + mutex_unlock(&imx319->mutex); > >> + > >> + return 0; > >> +} > >> + > >> +static int imx319_update_digital_gain(struct imx319 *imx319, u32 d_gain) > >> +{ > >> +

Re: [PATCH v5] media: imx208: Add imx208 camera sensor driver

2018-09-21 Thread Helmut Grohne
On Thu, Sep 20, 2018 at 11:00:26PM +0200, Laurent Pinchart wrote: > On Thursday, 20 September 2018 23:16:47 EEST Sylwester Nawrocki wrote: > > On 09/20/2018 06:49 PM, Grant Grundler wrote: > > > On Thu, Sep 20, 2018 at 1:52 AM Tomasz Figa wrote: > > >> We have a problem here. The sensor supports on

Re: [PATCH v5] media: add imx319 camera sensor driver

2018-09-21 Thread Bing Bu Cao
4l2 sub-device driver for the Sony imx319 image sensor. >> This is a camera sensor using the i2c bus for control and the >> csi-2 bus for data. >> >> This driver supports following features: >> - manual exposure and analog/digital gain control support >> - vblank/

RE: [PATCH v5] media: imx208: Add imx208 camera sensor driver

2018-09-21 Thread Chen, Ping-chung
romium.org; Mani, Rajmohan Subject: RE: [PATCH v5] media: imx208: Add imx208 camera sensor driver Hi Sakari, >-Original Message- >From: Ricardo Ribalda Delgado [mailto:ricardo.riba...@gmail.com] >Sent: Friday, September 21, 2018 5:55 AM >HI On Thu, Sep 20, 2018 at 11:13 PM La

RE: [PATCH v5] media: imx208: Add imx208 camera sensor driver

2018-09-21 Thread Chen, Ping-chung
Hi Sakari, >-Original Message- >From: Ricardo Ribalda Delgado [mailto:ricardo.riba...@gmail.com] >Sent: Friday, September 21, 2018 5:55 AM >HI On Thu, Sep 20, 2018 at 11:13 PM Laurent Pinchart wrote: > > Hi Sakari, > > On Thursday, 20 September 2018 23:56:59 EEST Sakari Ailus wrote: >

Re: [PATCH v5] media: add imx319 camera sensor driver

2018-09-20 Thread Bing Bu Cao
Ack, I will add more explanation into the code. On 09/19/2018 12:11 PM, Tomasz Figa wrote: > Hi Bingbu, > > On Mon, Sep 17, 2018 at 2:53 PM wrote: > [snip] >> +static int imx319_update_digital_gain(struct imx319 *imx319, u32 d_gain) >> +{ >> + int ret; >> + >> + ret = imx319_write_reg

Re: [PATCH v5] media: add imx319 camera sensor driver

2018-09-20 Thread Bing Bu Cao
On 09/18/2018 05:49 PM, Tomasz Figa wrote: > Hi Bingbu, > > On Mon, Sep 17, 2018 at 2:53 PM wrote: >> From: Bingbu Cao >> >> Add a v4l2 sub-device driver for the Sony imx319 image sensor. >> This is a camera sensor using the i2c bus for control and the >&

Re: [PATCH v5] media: add imx319 camera sensor driver

2018-09-20 Thread Bing Bu Cao
Add a v4l2 sub-device driver for the Sony imx319 image sensor. >> This is a camera sensor using the i2c bus for control and the >> csi-2 bus for data. >> >> This driver supports following features: >> - manual exposure and analog/digital gain control support >> - v

Re: [PATCH v5] media: imx208: Add imx208 camera sensor driver

2018-09-20 Thread Ricardo Ribalda Delgado
HI On Thu, Sep 20, 2018 at 11:13 PM Laurent Pinchart wrote: > > Hi Sakari, > > On Thursday, 20 September 2018 23:56:59 EEST Sakari Ailus wrote: > > On Thu, Sep 20, 2018 at 05:51:55PM +0900, Tomasz Figa wrote: > > > On Wed, Aug 8, 2018 at 4:08 PM Ping-chung Chen wrote: > > > [snip] > > > > > > > +

Re: [PATCH v5] media: imx208: Add imx208 camera sensor driver

2018-09-20 Thread Laurent Pinchart
Hi Sakari, On Thursday, 20 September 2018 23:56:59 EEST Sakari Ailus wrote: > On Thu, Sep 20, 2018 at 05:51:55PM +0900, Tomasz Figa wrote: > > On Wed, Aug 8, 2018 at 4:08 PM Ping-chung Chen wrote: > > [snip] > > > > > + > > > +/* Digital gain control */ > > > +#define IMX208_REG_GR_DIGITAL_GAIN

Re: [PATCH v5] media: imx208: Add imx208 camera sensor driver

2018-09-20 Thread Laurent Pinchart
Hello, (CC'ing Helmut Grohne) On Thursday, 20 September 2018 23:16:47 EEST Sylwester Nawrocki wrote: > On 09/20/2018 06:49 PM, Grant Grundler wrote: > > On Thu, Sep 20, 2018 at 1:52 AM Tomasz Figa wrote: > >> On Wed, Aug 8, 2018 at 4:08 PM Ping-chung Chen wrote: > >>> +/* Digital gain control */

  1   2   3   4   5   6   >