Re: AF9035 experimental header changes

2012-05-13 Thread Antti Palosaari
On 13.05.2012 20:26, Oliver Schinagl wrote: On 13-05-12 17:51, Antti Palosaari wrote: On 13.05.2012 18:24, Oliver Schinagl wrote: Hi antti, I've just updated my local branch of your experimental branch and got some conflicts because you moved the header inclusions from the C file to the header

Re: AF9035 experimental header changes

2012-05-13 Thread Oliver Schinagl
On 13-05-12 17:51, Antti Palosaari wrote: On 13.05.2012 18:24, Oliver Schinagl wrote: Hi antti, I've just updated my local branch of your experimental branch and got some conflicts because you moved the header inclusions from the C file to the header file. Why is that? I thought it was really b

Re: AF9035 experimental header changes

2012-05-13 Thread Antti Palosaari
On 13.05.2012 18:24, Oliver Schinagl wrote: Hi antti, I've just updated my local branch of your experimental branch and got some conflicts because you moved the header inclusions from the C file to the header file. Why is that? I thought it was really bad practice to have includes in header file

AF9035 experimental header changes

2012-05-13 Thread Oliver Schinagl
Hi antti, I've just updated my local branch of your experimental branch and got some conflicts because you moved the header inclusions from the C file to the header file. Why is that? I thought it was really bad practice to have includes in header files. http://git.linuxtv.org/anttip/media_t