I got the following notification.
- http://patchwork.linuxtv.org/patch/47270/
- for: Linux Media kernel patches
was: New
now: Rejected
Would you like to clarify still any other variant for this change proposal?
Regards,
Markus
Hello,
On Wednesday, 28 February 2018 10:45:21 EET SF Markus Elfring wrote:
> >> +put_isp:
> >> + omap3isp_put(video->isp);
> >> +delete_fh:
> >> + v4l2_fh_del(&handle->vfh);
> >> + v4l2_fh_exit(&handle->vfh);
> >> + kfree(handle);
> >
> > Please prefix the error labels with error_.
>
> How
>> +put_isp:
>> +omap3isp_put(video->isp);
>> +delete_fh:
>> +v4l2_fh_del(&handle->vfh);
>> +v4l2_fh_exit(&handle->vfh);
>> +kfree(handle);
>
> Please prefix the error labels with error_.
How often do you really need such an extra prefix?
>> +++ b/drivers/media/usb/uvc/uvc_v4l2.
Hi Markus,
Thank you for the patch.
On 19.02.2018 20:11, SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Mon, 19 Feb 2018 18:50:40 +0100
>
> Adjust jump targets so that a bit of exception handling can be better
> reused at the end of these functions.
>
> This issue was partly detected
Hello Markus,
On Monday, 19 February 2018 20:11:56 EET SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Mon, 19 Feb 2018 18:50:40 +0100
>
> Adjust jump targets so that a bit of exception handling can be better
> reused at the end of these functions.
>
> This issue was partly detected by
From: Markus Elfring
Date: Mon, 19 Feb 2018 18:50:40 +0100
Adjust jump targets so that a bit of exception handling can be better
reused at the end of these functions.
This issue was partly detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
v2:
Hans Verkuil insisted o
