Re: [patch] video/saa7134: potential null dereferences in debug code

2010-05-29 Thread Jean Delvare
On Sat, 29 May 2010 01:29:54 -0300, Mauro Carvalho Chehab wrote: > Em Sat, 22 May 2010 22:59:21 +0200 > Jean Delvare escreveu: > > I would have used "(null)" instead of "" for consistency with > > lib/vsprintf.c:string(). > > > > But more importantly, I suspect that a better fix would be to not c

Re: [patch] video/saa7134: potential null dereferences in debug code

2010-05-28 Thread Mauro Carvalho Chehab
Em Sat, 22 May 2010 22:59:21 +0200 Jean Delvare escreveu: > Hi Dan, > > On Sat, 22 May 2010 22:15:35 +0200, Dan Carpenter wrote: > > I modified the dprintk and i2cdprintk macros to handle null dev and ir > > pointers. There are two couple places that call dprintk() when "dev" is > > null. One

Re: [patch] video/saa7134: potential null dereferences in debug code

2010-05-22 Thread Jean Delvare
Hi Dan, On Sat, 22 May 2010 22:15:35 +0200, Dan Carpenter wrote: > I modified the dprintk and i2cdprintk macros to handle null dev and ir > pointers. There are two couple places that call dprintk() when "dev" is > null. One is in get_key_msi_tvanywhere_plus() and the other is in > get_key_flydvb

[patch] video/saa7134: potential null dereferences in debug code

2010-05-22 Thread Dan Carpenter
I modified the dprintk and i2cdprintk macros to handle null dev and ir pointers. There are two couple places that call dprintk() when "dev" is null. One is in get_key_msi_tvanywhere_plus() and the other is in get_key_flydvb_trio(). Signed-off-by: Dan Carpenter diff --git a/drivers/media/video