Re: [media] winbond-cir: Move a variable assignment in two functions

2016-10-19 Thread SF Markus Elfring
>> Move the assignment for the local variable "data" behind the source code >> for condition checks by these functions. > > Why? * Would you like to set these variables only after the initial check succeeded? * Do you care for data access locality also in these cases? Regards, Markus -- To u

Re: [PATCH 5/5] [media] winbond-cir: Move a variable assignment in two functions

2016-10-19 Thread David Härdeman
October 14, 2016 1:45 PM, "SF Markus Elfring" wrote: > From: Markus Elfring > Date: Fri, 14 Oct 2016 13:13:11 +0200 > > Move the assignment for the local variable "data" behind the source code > for condition checks by these functions. Why? > Signed-off-by: Markus Elfring > --- > drivers/med

[PATCH 5/5] [media] winbond-cir: Move a variable assignment in two functions

2016-10-14 Thread SF Markus Elfring
From: Markus Elfring Date: Fri, 14 Oct 2016 13:13:11 +0200 Move the assignment for the local variable "data" behind the source code for condition checks by these functions. Signed-off-by: Markus Elfring --- drivers/media/rc/winbond-cir.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions