Re: [media] s5p-mfc: Adjust a null pointer check in four functions

2017-09-12 Thread SF Markus Elfring
> Generating patch is only part of the story, I can follow this view in principle. > it seems the patch is not sent properly I got an other impression. > and tags which should be in SMTP header end up in the message body. I agree that extra message fields were presented by the git software f

Re: [media] s5p-mfc: Adjust a null pointer check in four functions

2017-09-12 Thread Sylwester Nawrocki
On 09/12/2017 05:00 PM, SF Markus Elfring wrote: * Do you care to preserve an information like the author date? In this case not, but actually the Date line is not an issue. Thanks for your information. It seems then that you quoted a line too much. Anyway the patch is malformed, … > I ha

Re: [media] s5p-mfc: Adjust a null pointer check in four functions

2017-09-12 Thread SF Markus Elfring
>> * Do you care to preserve an information like the author date? > > In this case not, but actually the Date line is not an issue. Thanks for your information. It seems then that you quoted a line too much. > Anyway the patch is malformed, … I have got doubts for this view because the file w

Re: [media] s5p-mfc: Adjust a null pointer check in four functions

2017-09-12 Thread Sylwester Nawrocki
On 09/11/2017 09:21 PM, SF Markus Elfring wrote: Date: Fri, 8 Sep 2017 22:37:00 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Can you resend with that 4 lines removed? * Do you care to preserve an information like the author date? In this ca

Re: [media] s5p-mfc: Adjust a null pointer check in four functions

2017-09-11 Thread SF Markus Elfring
>> Date: Fri, 8 Sep 2017 22:37:00 +0200 >> MIME-Version: 1.0 >> Content-Type: text/plain; charset=UTF-8 >> Content-Transfer-Encoding: 8bit > > Can you resend with that 4 lines removed? * Do you care to preserve an information like the author date? * Would you like to support special characters i

Re: [PATCH 3/3] [media] s5p-mfc: Adjust a null pointer check in four functions

2017-09-11 Thread Sylwester Nawrocki
On 09/08/2017 10:53 PM, SF Markus Elfring wrote: From: Markus Elfring Date: Fri, 8 Sep 2017 22:37:00 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Can you resend with that 4 lines removed? Are you using git send-email for sending patches? -

[PATCH 3/3] [media] s5p-mfc: Adjust a null pointer check in four functions

2017-09-08 Thread SF Markus Elfring
From: Markus Elfring Date: Fri, 8 Sep 2017 22:37:00 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script “checkpatch.pl” pointed information out like the following. Comparison to NULL could be written … Thus fix the affected source code plac