Re: [RFCv1 PATCH 3/9] v4l2-ioctl: add ctrl_handler to v4l2_fh

2011-04-11 Thread Laurent Pinchart
Hi Hans, On Friday 08 April 2011 17:39:01 Hans Verkuil wrote: > On Friday, April 08, 2011 17:10:32 Laurent Pinchart wrote: > > On Monday 04 April 2011 13:51:48 Hans Verkuil wrote: > > > From: Hans Verkuil > > > > > > This is required to implement control events and is also needed to > > > allow

Re: [RFCv1 PATCH 3/9] v4l2-ioctl: add ctrl_handler to v4l2_fh

2011-04-08 Thread Hans Verkuil
On Friday, April 08, 2011 17:10:32 Laurent Pinchart wrote: > Hi Hans, > > On Monday 04 April 2011 13:51:48 Hans Verkuil wrote: > > From: Hans Verkuil > > > > This is required to implement control events and is also needed to allow > > for per-filehandle control handlers. > > Thanks for the patc

Re: [RFCv1 PATCH 3/9] v4l2-ioctl: add ctrl_handler to v4l2_fh

2011-04-08 Thread Laurent Pinchart
Hi Hans, On Monday 04 April 2011 13:51:48 Hans Verkuil wrote: > From: Hans Verkuil > > This is required to implement control events and is also needed to allow > for per-filehandle control handlers. Thanks for the patch. Shouldn't you modify v4l2-subdev.c similarly ? -- Regards, Laurent Pin

[RFCv1 PATCH 3/9] v4l2-ioctl: add ctrl_handler to v4l2_fh

2011-04-04 Thread Hans Verkuil
From: Hans Verkuil This is required to implement control events and is also needed to allow for per-filehandle control handlers. Signed-off-by: Hans Verkuil --- drivers/media/video/v4l2-fh.c|2 ++ drivers/media/video/v4l2-ioctl.c | 36 +++- include/med