Re: [RFCv1 PATCH 1/6] videobuf2-core: move num_planes from vb2_buffer to vb2_queue.

2012-09-19 Thread Sylwester Nawrocki
On 09/19/2012 05:28 PM, Hans Verkuil wrote: > On Wed September 19 2012 17:18:11 Sylwester Nawrocki wrote: >> Hi Hans, >> >> On 09/19/2012 04:37 PM, Hans Verkuil wrote: >>> From: Hans Verkuil >>> >>> It's a queue-global value, so keep it there rather than with the >>> buffer struct. >> >> I would p

Re: [RFCv1 PATCH 1/6] videobuf2-core: move num_planes from vb2_buffer to vb2_queue.

2012-09-19 Thread Hans Verkuil
On Wed September 19 2012 17:18:11 Sylwester Nawrocki wrote: > Hi Hans, > > On 09/19/2012 04:37 PM, Hans Verkuil wrote: > > From: Hans Verkuil > > > > It's a queue-global value, so keep it there rather than with the > > buffer struct. > > I would prefer not doing this. It makes the path to varia

Re: [RFCv1 PATCH 1/6] videobuf2-core: move num_planes from vb2_buffer to vb2_queue.

2012-09-19 Thread Sylwester Nawrocki
Hi Hans, On 09/19/2012 04:37 PM, Hans Verkuil wrote: > From: Hans Verkuil > > It's a queue-global value, so keep it there rather than with the > buffer struct. I would prefer not doing this. It makes the path to variable number of per buffer planes more difficult. Regards, Sylwester -- To uns

[RFCv1 PATCH 1/6] videobuf2-core: move num_planes from vb2_buffer to vb2_queue.

2012-09-19 Thread Hans Verkuil
From: Hans Verkuil It's a queue-global value, so keep it there rather than with the buffer struct. Signed-off-by: Hans Verkuil --- drivers/media/v4l2-core/videobuf2-core.c | 40 -- include/media/videobuf2-core.h | 12 - 2 files changed, 27 inse