Re: [RFC v2] [media] v4l2: add V4L2 pixel format array and helper functions

2014-09-02 Thread Philipp Zabel
Hi Hans, Am Donnerstag, den 28.08.2014, 19:41 +0200 schrieb Hans Verkuil: > On 08/28/2014 07:32 PM, Hans Verkuil wrote: > > On 08/28/2014 07:18 PM, Mauro Carvalho Chehab wrote: > >> I really don't see any gain on applying such patch. If the concern is > >> just about properly naming the pixel form

Re: [RFC v2] [media] v4l2: add V4L2 pixel format array and helper functions

2014-08-28 Thread Hans Verkuil
On 08/28/2014 07:32 PM, Hans Verkuil wrote: > On 08/28/2014 07:18 PM, Mauro Carvalho Chehab wrote: >> Em Thu, 28 Aug 2014 18:40:53 +0200 >> Hans Verkuil escreveu: >> >>> On 08/28/2014 06:25 PM, Laurent Pinchart wrote: Hi Philipp, On Thursday 28 August 2014 18:09:35 Philipp Zabel wro

Re: [RFC v2] [media] v4l2: add V4L2 pixel format array and helper functions

2014-08-28 Thread Hans Verkuil
On 08/28/2014 07:18 PM, Mauro Carvalho Chehab wrote: > Em Thu, 28 Aug 2014 18:40:53 +0200 > Hans Verkuil escreveu: > >> On 08/28/2014 06:25 PM, Laurent Pinchart wrote: >>> Hi Philipp, >>> >>> On Thursday 28 August 2014 18:09:35 Philipp Zabel wrote: Am Donnerstag, den 28.08.2014, 14:24 +0200

Re: [RFC v2] [media] v4l2: add V4L2 pixel format array and helper functions

2014-08-28 Thread Mauro Carvalho Chehab
Em Thu, 28 Aug 2014 18:40:53 +0200 Hans Verkuil escreveu: > On 08/28/2014 06:25 PM, Laurent Pinchart wrote: > > Hi Philipp, > > > > On Thursday 28 August 2014 18:09:35 Philipp Zabel wrote: > >> Am Donnerstag, den 28.08.2014, 14:24 +0200 schrieb Laurent Pinchart: > A driver could then do the

Re: [RFC v2] [media] v4l2: add V4L2 pixel format array and helper functions

2014-08-28 Thread Hans Verkuil
On 08/28/2014 06:25 PM, Laurent Pinchart wrote: > Hi Philipp, > > On Thursday 28 August 2014 18:09:35 Philipp Zabel wrote: >> Am Donnerstag, den 28.08.2014, 14:24 +0200 schrieb Laurent Pinchart: A driver could then do the following: static struct v4l2_pixfmt_info driver_formats[] =

Re: [RFC v2] [media] v4l2: add V4L2 pixel format array and helper functions

2014-08-28 Thread Laurent Pinchart
Hi Philipp, On Thursday 28 August 2014 18:09:35 Philipp Zabel wrote: > Am Donnerstag, den 28.08.2014, 14:24 +0200 schrieb Laurent Pinchart: > > > A driver could then do the following: > > > > > > static struct v4l2_pixfmt_info driver_formats[] = { > > > > > > { .pixelformat = V4L2_PIX_FMT_YUYV

Re: [RFC v2] [media] v4l2: add V4L2 pixel format array and helper functions

2014-08-28 Thread Philipp Zabel
Hi Laurent, Am Donnerstag, den 28.08.2014, 14:24 +0200 schrieb Laurent Pinchart: > > A driver could then do the following: > > > > static struct v4l2_pixfmt_info driver_formats[] = { > > { .pixelformat = V4L2_PIX_FMT_YUYV }, > > { .pixelformat = V4L2_PIX_FMT_YUV420 }, > > }; > > > > int

Re: [RFC v2] [media] v4l2: add V4L2 pixel format array and helper functions

2014-08-28 Thread Laurent Pinchart
Hi Philipp, On Wednesday 27 August 2014 11:30:14 Philipp Zabel wrote: > Am Dienstag, den 26.08.2014, 12:01 +0200 schrieb Laurent Pinchart: > [...] > > > > +}; > > > + > > > +const struct v4l2_pixfmt *v4l2_pixfmt_by_fourcc(u32 fourcc) > > > +{ > > > + int i; > > > > The loop counter is always pos

Re: [RFC v2] [media] v4l2: add V4L2 pixel format array and helper functions

2014-08-27 Thread Philipp Zabel
Hi Laurent, thank you for the comments. Am Dienstag, den 26.08.2014, 12:01 +0200 schrieb Laurent Pinchart: [...] > > +}; > > + > > +const struct v4l2_pixfmt *v4l2_pixfmt_by_fourcc(u32 fourcc) > > +{ > > + int i; > > The loop counter is always positive, it can be an unsigned int. I'll change t

Re: [RFC v2] [media] v4l2: add V4L2 pixel format array and helper functions

2014-08-26 Thread Laurent Pinchart
Hi Philipp, Thank you for the patch. On Tuesday 26 August 2014 11:00:54 Philipp Zabel wrote: > This patch adds an array of V4L2 pixel formats and descriptions that can be > used by drivers so that each driver doesn't have to provide its own slightly > different format descriptions for VIDIOC_ENUM

[RFC v2] [media] v4l2: add V4L2 pixel format array and helper functions

2014-08-26 Thread Philipp Zabel
This patch adds an array of V4L2 pixel formats and descriptions that can be used by drivers so that each driver doesn't have to provide its own slightly different format descriptions for VIDIOC_ENUM_FMT. Each array entry also includes two bits per pixel values (for a single line and one for the wh