Re: [RFC PATCH] ivtv-alsa: regression fix: remove __init from ivtv_alsa_load

2013-02-07 Thread Andy Walls
Hans Verkuil wrote: >On Thu February 7 2013 22:58:53 Andy Walls wrote: >> Hans Verkuil wrote: >> >> >Andy, >> > >> >Please review this patch. This fix probably should be fast-tracked >to >> >3.8 and >> >queued for stable 3.7. >> > >> >ivtv-alsa kept crashing my machine every time I loaded it, a

Re: [RFC PATCH] ivtv-alsa: regression fix: remove __init from ivtv_alsa_load

2013-02-07 Thread Hans Verkuil
On Thu February 7 2013 22:58:53 Andy Walls wrote: > Hans Verkuil wrote: > > >Andy, > > > >Please review this patch. This fix probably should be fast-tracked to > >3.8 and > >queued for stable 3.7. > > > >ivtv-alsa kept crashing my machine every time I loaded it, and this is > >the > >cause. > > >

Re: [RFC PATCH] ivtv-alsa: regression fix: remove __init from ivtv_alsa_load

2013-02-07 Thread Andy Walls
Hans Verkuil wrote: >Andy, > >Please review this patch. This fix probably should be fast-tracked to >3.8 and >queued for stable 3.7. > >ivtv-alsa kept crashing my machine every time I loaded it, and this is >the >cause. > >Regards, > > Hans > >This function is called after initialization, s

[RFC PATCH] ivtv-alsa: regression fix: remove __init from ivtv_alsa_load

2013-02-07 Thread Hans Verkuil
Andy, Please review this patch. This fix probably should be fast-tracked to 3.8 and queued for stable 3.7. ivtv-alsa kept crashing my machine every time I loaded it, and this is the cause. Regards, Hans This function is called after initialization, so it should never be marked __init!