Re: [RFC PATCH] Modify volatile auto cluster handling as per earlier discussions

2011-08-26 Thread Hans Verkuil
On Thursday, August 25, 2011 22:22:28 Hans de Goede wrote: > Hi, > > First of all thanks for doing this! Overall it looks good, > see below for several (small) remarks which I have. Thanks for the review! > On 08/09/2011 06:40 PM, Hans Verkuil wrote: > > This patch modifies the way autoclusters

Re: [RFC PATCH] Modify volatile auto cluster handling as per earlier discussions

2011-08-25 Thread Hans de Goede
Hi, First of all thanks for doing this! Overall it looks good, see below for several (small) remarks which I have. On 08/09/2011 06:40 PM, Hans Verkuil wrote: This patch modifies the way autoclusters work when the 'foo' controls are volatile if autofoo is on. E.g.: if autogain is true, then ga

[RFC PATCH] Modify volatile auto cluster handling as per earlier discussions

2011-08-09 Thread Hans Verkuil
This patch modifies the way autoclusters work when the 'foo' controls are volatile if autofoo is on. E.g.: if autogain is true, then gain returns the gain set by the autogain circuitry. This patch makes the following changes: 1) The V4L2_CTRL_FLAG_VOLATILE flag is added to let userspace know tha