Re: [RFC 1/3] v4l: Add pixel clock to struct v4l2_mbus_framefmt

2011-12-15 Thread Sakari Ailus
Hi Sylwester, On Thu, Dec 15, 2011 at 11:19:40PM +0100, Sylwester Nawrocki wrote: > On 12/15/2011 11:01 PM, Sakari Ailus wrote: > >>> __u32 > >>> - reserved[7] > >>> + pixel_clock > >>> + Pixel clock in kHz. This clock is the maximum rate at > >>> + which pixels are transferred on the

Re: [RFC 1/3] v4l: Add pixel clock to struct v4l2_mbus_framefmt

2011-12-15 Thread Sylwester Nawrocki
On 12/15/2011 11:01 PM, Sakari Ailus wrote: >>> __u32 >>> - reserved[7] >>> + pixel_clock >>> + Pixel clock in kHz. This clock is the maximum rate at >>> + which pixels are transferred on the bus. The pixel_clock >>> + field is read-only. >> >> I searched a couple of datas

Re: [RFC 1/3] v4l: Add pixel clock to struct v4l2_mbus_framefmt

2011-12-15 Thread Sakari Ailus
Hi Sylwester, Thanks for the comments! On Thu, Dec 15, 2011 at 10:46:22PM +0100, Sylwester Nawrocki wrote: > Hi Sakari, > > thanks for the patch. > > On 12/14/2011 04:22 PM, Sakari Ailus wrote: > > Pixel clock is an essential part of the image data parameters. Add this. > > Together, the curren

Re: [RFC 1/3] v4l: Add pixel clock to struct v4l2_mbus_framefmt

2011-12-15 Thread Sylwester Nawrocki
Hi Sakari, thanks for the patch. On 12/14/2011 04:22 PM, Sakari Ailus wrote: > Pixel clock is an essential part of the image data parameters. Add this. > Together, the current parameters also define the frame rate. > > Sensors do not have a concept of frame rate; pixel clock is much more > meani

[RFC 1/3] v4l: Add pixel clock to struct v4l2_mbus_framefmt

2011-12-14 Thread Sakari Ailus
Pixel clock is an essential part of the image data parameters. Add this. Together, the current parameters also define the frame rate. Sensors do not have a concept of frame rate; pixel clock is much more meaningful in this context. Also, it is best to combine the pixel clock with the other format