Re: [RFC] BKL in open functions in drivers

2009-04-02 Thread Hans Verkuil
On Thursday 02 April 2009 20:25:10 Alexey Klimov wrote: > On Thu, Apr 2, 2009 at 11:29 AM, Hans Verkuil wrote: > > [...] > > >> So, questions are: > >> > >> 1) What for is lock/unlock_kernel() used in open? > > > > It's pointless. Just remove it. > > Actually, i can see lock/unlock_kernel() in

Re: [RFC] BKL in open functions in drivers

2009-04-02 Thread Alexey Klimov
On Thu, Apr 2, 2009 at 11:29 AM, Hans Verkuil wrote: [...] >> So, questions are: >> >> 1) What for is lock/unlock_kernel() used in open? > > It's pointless. Just remove it. Actually, i can see lock/unlock_kernel() in open in other V4L drivers too. What for is it used in other drivers? >> 2) Ca

Re: [RFC] BKL in open functions in drivers

2009-04-02 Thread Hans Verkuil
On Wednesday 01 April 2009 23:00:56 Alexey Klimov wrote: > Hello, > > Few days ago Alessio Igor Bogani sent me patch > that removes BKLs like lock/unlock_kernel() in open call and place mutex > there in media/radio/radio-mr800.c. > This patch broke the driver, so we figured out new approah. We adde

[RFC] BKL in open functions in drivers

2009-04-01 Thread Alexey Klimov
Hello, Few days ago Alessio Igor Bogani sent me patch that removes BKLs like lock/unlock_kernel() in open call and place mutex there in media/radio/radio-mr800.c. This patch broke the driver, so we figured out new approah. We added one more mutex lock that was used in open call. The patch is below