RE: [RFC/PATCH v6 1/4] Changes in include/linux/videodev2.h for MFC 5.1

2011-01-24 Thread Jaeryul Oh
> Szyprowski; pa...@osciak.com; kyungmin.p...@samsung.com; > jaeryul...@samsung.com; kgene....@samsung.com > Subject: RE: [RFC/PATCH v6 1/4] Changes in include/linux/videodev2.h for > MFC 5.1 > > Hi Hans, > > I am pretty busy with other work now. That's why I have l

RE: [RFC/PATCH v6 1/4] Changes in include/linux/videodev2.h for MFC 5.1

2011-01-24 Thread Kamil Debski
Hi Hans, I am pretty busy with other work now. That's why I have little time to work on the open source driver for the open source. I hope to have more time soon. > From: Hans Verkuil [mailto:hverk...@xs4all.nl] > > Hi Kamil, > > Here is a review of this patch. I didn't really look that closely

Re: [RFC/PATCH v6 1/4] Changes in include/linux/videodev2.h for MFC 5.1

2011-01-23 Thread Hans Verkuil
Hi Kamil, Here is a review of this patch. I didn't really look that closely at the others, other than noticing that they didn't use the control framework yet. The main issue really is lack of documentation. It's hard to review something if you don't know what a new define stands for. On Friday,

[RFC/PATCH v6 1/4] Changes in include/linux/videodev2.h for MFC 5.1

2011-01-07 Thread Kamil Debski
This patch adds fourcc values for compressed video stream formats and V4L2_CTRL_CLASS_CODEC. Also adds controls used by MFC 5.1 driver. Signed-off-by: Kamil Debski Signed-off-by: Kyungmin Park --- include/linux/videodev2.h | 45 + 1 files changed, 4