On Monday, December 13, 2010 14:31:18 Andy Walls wrote:
> On Mon, 2010-12-13 at 08:32 +0100, Hans Verkuil wrote:
> > On Sunday, December 12, 2010 19:46:33 Andy Walls wrote:
>
> Hi Hans,
>
> > > 1. Why set the vol step to 655, when the volume will actaully step at
> > > increments of 512?
> >
>
On Mon, 2010-12-13 at 08:32 +0100, Hans Verkuil wrote:
> On Sunday, December 12, 2010 19:46:33 Andy Walls wrote:
Hi Hans,
> > 1. Why set the vol step to 655, when the volume will actaully step at
> > increments of 512?
>
> The goal of the exercise is to convert to the control framework. I don'
On Sunday, December 12, 2010 19:46:33 Andy Walls wrote:
> Hi Hans,
>
> It looks like it should. I'm looking at things on my phone while out and
> about - not the best environment for code review.
>
> You just need to ensure default vol is >= 0 and <= 65535 which may not be the
> case if reg 8
Hi Hans,
It looks like it should. I'm looking at things on my phone while out and
about - not the best environment for code review.
You just need to ensure default vol is >= 0 and <= 65535 which may not be the
case if reg 8d4 has a value near 0.
Two other topics while I'm here:
1. Why set
On Sunday, December 12, 2010 19:09:36 Andy Walls wrote:
> Hans,
>
> This has at least the same two problems the change for cx25840 had:
>
> 1. Volume control init should use 65535 not 65335
>
> 2. You cannot trust reg 0x8d4 to have a value in it for the default volume
> that won't give an ERANG
Hans,
This has at least the same two problems the change for cx25840 had:
1. Volume control init should use 65535 not 65335
2. You cannot trust reg 0x8d4 to have a value in it for the default volume that
won't give an ERANGE error when you go to init the volume control. Subdev
probe will fail
Signed-off-by: Hans Verkuil
---
drivers/media/video/cx18/cx18-av-audio.c | 92 ++-
drivers/media/video/cx18/cx18-av-core.c | 162 ++---
drivers/media/video/cx18/cx18-av-core.h | 12 +-
drivers/media/video/cx18/cx18-controls.c | 285 --
drive
