Re: [REVIEW PATCH 1/2] v4l: Add data_offset to struct v4l2_buffer

2014-12-06 Thread Sakari Ailus
Hi Hans, On Sat, Dec 06, 2014 at 01:05:16PM +0100, Hans Verkuil wrote: > On 12/06/2014 12:48 PM, Sakari Ailus wrote: > > Hi Hans, > > > > On Fri, Dec 05, 2014 at 04:10:05PM +0100, Hans Verkuil wrote: > >> On 12/03/2014 12:14 PM, Sakari Ailus wrote: > >>> From: Sakari Ailus > > > > >> I think

Re: [REVIEW PATCH 1/2] v4l: Add data_offset to struct v4l2_buffer

2014-12-06 Thread Hans Verkuil
On 12/06/2014 12:48 PM, Sakari Ailus wrote: > Hi Hans, > > On Fri, Dec 05, 2014 at 04:10:05PM +0100, Hans Verkuil wrote: >> On 12/03/2014 12:14 PM, Sakari Ailus wrote: >>> From: Sakari Ailus >> I think we need to add new helper functions that give back the real plane >> size >> (i.e. bytesuse

Re: [REVIEW PATCH 1/2] v4l: Add data_offset to struct v4l2_buffer

2014-12-06 Thread Sakari Ailus
Hi Hans, On Fri, Dec 05, 2014 at 04:10:05PM +0100, Hans Verkuil wrote: > On 12/03/2014 12:14 PM, Sakari Ailus wrote: > > From: Sakari Ailus > > > > The data_offset field tells the start of the image data from the beginning > > of the buffer. The bsize field > > bsize field? There is no bsize f

Re: [REVIEW PATCH 1/2] v4l: Add data_offset to struct v4l2_buffer

2014-12-05 Thread Hans Verkuil
On 12/03/2014 12:14 PM, Sakari Ailus wrote: > From: Sakari Ailus > > The data_offset field tells the start of the image data from the beginning > of the buffer. The bsize field bsize field? There is no bsize field in v4l2_buffer, so I'm confused. > in struct v4l2_buffer includes this, but the

[REVIEW PATCH 1/2] v4l: Add data_offset to struct v4l2_buffer

2014-12-03 Thread Sakari Ailus
From: Sakari Ailus The data_offset field tells the start of the image data from the beginning of the buffer. The bsize field in struct v4l2_buffer includes this, but the sizeimage field in struct v4l2_pix_format does not. Signed-off-by: Sakari Ailus --- Documentation/DocBook/media/v4l/compat.x