Re: [PATCHv6 4/3] v4l2-dev: disable frequency and tuner ioctls for touch

2019-10-14 Thread Hans Verkuil
On 10/14/19 11:43 PM, Laurent Pinchart wrote: > Hi Hans, > > Thank you for the patch. > > On Mon, Oct 14, 2019 at 02:01:05PM +0200, Hans Verkuil wrote: >> Touch devices have obviously no tuner, so don't attempt to enable those >> ioctls >> for such devices. > > Shouldn't this be disabled for pu

Re: [PATCHv6 4/3] v4l2-dev: disable frequency and tuner ioctls for touch

2019-10-14 Thread Laurent Pinchart
Hi Hans, Thank you for the patch. On Mon, Oct 14, 2019 at 02:01:05PM +0200, Hans Verkuil wrote: > Touch devices have obviously no tuner, so don't attempt to enable those ioctls > for such devices. Shouldn't this be disabled for pure metadata devices (is_meta && !is_vid) too ? > Signed-off-by: H

[PATCHv6 4/3] v4l2-dev: disable frequency and tuner ioctls for touch

2019-10-14 Thread Hans Verkuil
Touch devices have obviously no tuner, so don't attempt to enable those ioctls for such devices. Signed-off-by: Hans Verkuil --- diff --git a/drivers/media/v4l2-core/v4l2-dev.c b/drivers/media/v4l2-core/v4l2-dev.c index cec588b04711..da42d172714a 100644 --- a/drivers/media/v4l2-core/v4l2-dev.c +