Re: [PATCHv2 22/29] v4l2-async: Don't use dynamic static allocation

2013-11-05 Thread Hans Verkuil
On 11/05/13 14:16, Mauro Carvalho Chehab wrote: > New patch enclosed. Please reply with your reviewed-by if you're ok with > it. Reviewed-by: Hans Verkuil Regards, Hans -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.

Re: [PATCHv2 22/29] v4l2-async: Don't use dynamic static allocation

2013-11-05 Thread Mauro Carvalho Chehab
Em Tue, 05 Nov 2013 13:35:49 +0100 Hans Verkuil escreveu: > On 11/05/13 13:03, Mauro Carvalho Chehab wrote: > > Em Tue, 05 Nov 2013 12:42:23 +0100 > > Sylwester Nawrocki escreveu: > > > >> On 05/11/13 12:36, Mauro Carvalho Chehab wrote: > > diff --git a/drivers/media/v4l2-core/v4l2-async.c

Re: [PATCHv2 22/29] v4l2-async: Don't use dynamic static allocation

2013-11-05 Thread Hans Verkuil
On 11/05/13 13:03, Mauro Carvalho Chehab wrote: > Em Tue, 05 Nov 2013 12:42:23 +0100 > Sylwester Nawrocki escreveu: > >> On 05/11/13 12:36, Mauro Carvalho Chehab wrote: > diff --git a/drivers/media/v4l2-core/v4l2-async.c > b/drivers/media/v4l2-core/v4l2-async.c >>> index c85d69da35bd

Re: [PATCHv2 22/29] v4l2-async: Don't use dynamic static allocation

2013-11-05 Thread Mauro Carvalho Chehab
Em Tue, 05 Nov 2013 12:42:23 +0100 Sylwester Nawrocki escreveu: > On 05/11/13 12:36, Mauro Carvalho Chehab wrote: > >>> diff --git a/drivers/media/v4l2-core/v4l2-async.c > >>> b/drivers/media/v4l2-core/v4l2-async.c > >>> > > index c85d69da35bd..071596869036 100644 > >>> > > --- a/drivers/media/v

Re: [PATCHv2 22/29] v4l2-async: Don't use dynamic static allocation

2013-11-05 Thread Sylwester Nawrocki
On 05/11/13 12:36, Mauro Carvalho Chehab wrote: >>> diff --git a/drivers/media/v4l2-core/v4l2-async.c >>> b/drivers/media/v4l2-core/v4l2-async.c >>> > > index c85d69da35bd..071596869036 100644 >>> > > --- a/drivers/media/v4l2-core/v4l2-async.c >>> > > +++ b/drivers/media/v4l2-core/v4l2-async.c >>>

Re: [PATCHv2 22/29] v4l2-async: Don't use dynamic static allocation

2013-11-05 Thread Mauro Carvalho Chehab
Em Mon, 04 Nov 2013 14:15:04 +0100 Hans Verkuil escreveu: > On 11/02/2013 02:31 PM, Mauro Carvalho Chehab wrote: > > Dynamic static allocation is evil, as Kernel stack is too low, and > > compilation complains about it on some archs: > > > > drivers/media/v4l2-core/v4l2-async.c:238:1: warnin

Re: [PATCHv2 22/29] v4l2-async: Don't use dynamic static allocation

2013-11-04 Thread Hans Verkuil
On 11/02/2013 02:31 PM, Mauro Carvalho Chehab wrote: > Dynamic static allocation is evil, as Kernel stack is too low, and > compilation complains about it on some archs: > > drivers/media/v4l2-core/v4l2-async.c:238:1: warning: > 'v4l2_async_notifier_unregister' uses dynamic stack allocation

[PATCHv2 22/29] v4l2-async: Don't use dynamic static allocation

2013-11-02 Thread Mauro Carvalho Chehab
Dynamic static allocation is evil, as Kernel stack is too low, and compilation complains about it on some archs: drivers/media/v4l2-core/v4l2-async.c:238:1: warning: 'v4l2_async_notifier_unregister' uses dynamic stack allocation [enabled by default] Instead, let's enforce a limit for th