Re: [PATCHv2 09/13] v4l2-compat-ioctl32.c: fix ctrl_is_pointer

2018-01-30 Thread Laurent Pinchart
Hi Hans, Thank you for the patch. On Tuesday, 30 January 2018 12:26:57 EET Hans Verkuil wrote: > From: Hans Verkuil > > ctrl_is_pointer just hardcoded two known string controls, but that > caused problems when using e.g. custom controls that use a pointer > for the payload. > > Reimplement thi

Re: [PATCHv2 09/13] v4l2-compat-ioctl32.c: fix ctrl_is_pointer

2018-01-30 Thread Sakari Ailus
On Tue, Jan 30, 2018 at 11:26:57AM +0100, Hans Verkuil wrote: > From: Hans Verkuil > > ctrl_is_pointer just hardcoded two known string controls, but that > caused problems when using e.g. custom controls that use a pointer > for the payload. > > Reimplement this function: it now finds the v4l2_c

[PATCHv2 09/13] v4l2-compat-ioctl32.c: fix ctrl_is_pointer

2018-01-30 Thread Hans Verkuil
From: Hans Verkuil ctrl_is_pointer just hardcoded two known string controls, but that caused problems when using e.g. custom controls that use a pointer for the payload. Reimplement this function: it now finds the v4l2_ctrl (if the driver uses the control framework) or it calls vidioc_query_ext_