Re: [PATCH v7] s5k5baf: add camera sensor driver

2013-09-02 Thread Mark Rutland
On Mon, Sep 02, 2013 at 05:21:58PM +0100, Sylwester Nawrocki wrote: > Hi Mark, Hi Sylwester, > > On 08/27/2013 11:14 AM, Mark Rutland wrote: > >> +endpoint node > >> +- > >> + > >> +- data-lanes : (optional) specifies MIPI CSI-2 data lanes as covered in > >> + video-interfaces.txt.

Re: [PATCH v7] s5k5baf: add camera sensor driver

2013-09-02 Thread Sylwester Nawrocki
Hi Mark, On 08/27/2013 11:14 AM, Mark Rutland wrote: >> +endpoint node >> +- >> + >> +- data-lanes : (optional) specifies MIPI CSI-2 data lanes as covered in >> + video-interfaces.txt. This property can be only used to specify number >> + of data lanes, i.e. the array's content is un

Re: [PATCH v7] s5k5baf: add camera sensor driver

2013-08-27 Thread Laurent Pinchart
Hi Andrejz, On Monday 26 August 2013 14:34:21 Andrzej Hajda wrote: > On 08/23/2013 02:53 PM, Laurent Pinchart wrote: > > On Wednesday 21 August 2013 16:41:31 Andrzej Hajda wrote: > >> Driver for Samsung S5K5BAF UXGA 1/5" 2M CMOS Image Sensor > >> with embedded SoC ISP. > >> The driver exposes the

Re: [PATCH v7] s5k5baf: add camera sensor driver

2013-08-27 Thread Mark Rutland
Hi, [trimming down to relevant context] > +endpoint node > +- > + > +- data-lanes : (optional) specifies MIPI CSI-2 data lanes as covered in > + video-interfaces.txt. This property can be only used to specify number > + of data lanes, i.e. the array's content is unused, only its len

Re: [PATCH v7] s5k5baf: add camera sensor driver

2013-08-26 Thread Andrzej Hajda
Hi Laurent, Thank you for the review. On 08/23/2013 02:53 PM, Laurent Pinchart wrote: > Hi Andrzej, > > Thank you for the patch. > > On Wednesday 21 August 2013 16:41:31 Andrzej Hajda wrote: >> Driver for Samsung S5K5BAF UXGA 1/5" 2M CMOS Image Sensor >> with embedded SoC ISP. >> The driver expos

Re: [PATCH v7] s5k5baf: add camera sensor driver

2013-08-23 Thread Laurent Pinchart
Hi Andrzej, Thank you for the patch. On Wednesday 21 August 2013 16:41:31 Andrzej Hajda wrote: > Driver for Samsung S5K5BAF UXGA 1/5" 2M CMOS Image Sensor > with embedded SoC ISP. > The driver exposes the sensor as two V4L2 subdevices: > - S5K5BAF-CIS - pure CMOS Image Sensor, fixed 1600x1200 for

Re: [PATCH v7] s5k5baf: add camera sensor driver

2013-08-23 Thread Pawel Moll
On Wed, 2013-08-21 at 15:41 +0100, Andrzej Hajda wrote: > diff --git a/Documentation/devicetree/bindings/media/samsung-s5k5baf.txt > b/Documentation/devicetree/bindings/media/samsung-s5k5baf.txt > new file mode 100644 > index 000..d680d99 > --- /dev/null > +++ b/Documentation/devicetree/bindin

Re: [PATCH v7] s5k5baf: add camera sensor driver

2013-08-23 Thread Sylwester Nawrocki
On 08/23/2013 11:23 AM, Sylwester Nawrocki wrote: +- stbyn-gpios : GPIO connected to STDBYN pin; >> > +- rstn-gpios : GPIO connected to RSTN pin; >> > >> > Both GPIOs above have names suggesting that they are active low. I wonder >> > how the GPIO flags cell is interpreted here,

Re: [PATCH v7] s5k5baf: add camera sensor driver

2013-08-23 Thread Sylwester Nawrocki
On 08/23/2013 12:39 AM, Tomasz Figa wrote: >> Documentation/devicetree/bindings/media/samsung-s5k5baf.txt create mode >> > 100644 drivers/media/i2c/s5k5baf.c >> > >> > diff --git a/Documentation/devicetree/bindings/media/samsung-s5k5baf.txt >> > b/Documentation/devicetree/bindings/media/samsung-s5

Re: [PATCH v7] s5k5baf: add camera sensor driver

2013-08-22 Thread Tomasz Figa
Hi Andrzej, Please see some minor comments inline. On Wednesday 21 of August 2013 16:41:31 Andrzej Hajda wrote: > Driver for Samsung S5K5BAF UXGA 1/5" 2M CMOS Image Sensor > with embedded SoC ISP. > The driver exposes the sensor as two V4L2 subdevices: > - S5K5BAF-CIS - pure CMOS Image Sensor, fi

Re: [PATCH v7] s5k5baf: add camera sensor driver

2013-08-22 Thread Stephen Warren
On 08/21/2013 08:41 AM, Andrzej Hajda wrote: > Driver for Samsung S5K5BAF UXGA 1/5" 2M CMOS Image Sensor > with embedded SoC ISP. > The driver exposes the sensor as two V4L2 subdevices: > - S5K5BAF-CIS - pure CMOS Image Sensor, fixed 1600x1200 format, > no controls. > - S5K5BAF-ISP - Image Signal