Re: [PATCH v4.1 3/3] v4l: Add V4L2_BUF_FLAG_TIMESTAMP_SOF and use it

2014-02-05 Thread Sakari Ailus
On Sun, Feb 02, 2014 at 10:27:49AM +0100, Laurent Pinchart wrote: > Hi Hans, > > On Friday 31 January 2014 18:21:15 Hans Verkuil wrote: > > On 01/31/2014 05:42 PM, Sakari Ailus wrote: > > > On Fri, Jan 31, 2014 at 04:45:56PM +0100, Hans Verkuil wrote: > > >> > > >> How about defining a capability

Re: [PATCH v4.1 3/3] v4l: Add V4L2_BUF_FLAG_TIMESTAMP_SOF and use it

2014-02-02 Thread Laurent Pinchart
Hi Hans, On Friday 31 January 2014 18:21:15 Hans Verkuil wrote: > On 01/31/2014 05:42 PM, Sakari Ailus wrote: > > On Fri, Jan 31, 2014 at 04:45:56PM +0100, Hans Verkuil wrote: > >> > >> How about defining a capability for use with ENUMINPUT/OUTPUT? I agree > >> that this won't change between buffe

Re: [PATCH v4.1 3/3] v4l: Add V4L2_BUF_FLAG_TIMESTAMP_SOF and use it

2014-02-01 Thread Sakari Ailus
Hi Hans, Hans Verkuil wrote: > Hi Sakari, > > On 01/31/2014 05:42 PM, Sakari Ailus wrote: >> Hi Hans and Laurent, >> >> On Fri, Jan 31, 2014 at 04:45:56PM +0100, Hans Verkuil wrote: >>> How about defining a capability for use with ENUMINPUT/OUTPUT? I agree that >>> this >>> won't change between

Re: [PATCH v4.1 3/3] v4l: Add V4L2_BUF_FLAG_TIMESTAMP_SOF and use it

2014-01-31 Thread Hans Verkuil
Hi Sakari, On 01/31/2014 05:42 PM, Sakari Ailus wrote: > Hi Hans and Laurent, > > On Fri, Jan 31, 2014 at 04:45:56PM +0100, Hans Verkuil wrote: >> How about defining a capability for use with ENUMINPUT/OUTPUT? I agree that >> this >> won't change between buffers, but it is a property of a specif

Re: [PATCH v4.1 3/3] v4l: Add V4L2_BUF_FLAG_TIMESTAMP_SOF and use it

2014-01-31 Thread Sakari Ailus
Hi Hans and Laurent, On Fri, Jan 31, 2014 at 04:45:56PM +0100, Hans Verkuil wrote: > How about defining a capability for use with ENUMINPUT/OUTPUT? I agree that > this > won't change between buffers, but it is a property of a specific input or > output. Over 80 characters per line. :-P > There

Re: [PATCH v4.1 3/3] v4l: Add V4L2_BUF_FLAG_TIMESTAMP_SOF and use it

2014-01-31 Thread Hans Verkuil
Hi Laurent, On 01/31/2014 04:39 PM, Laurent Pinchart wrote: > Hi Hans, > > On Thursday 12 December 2013 13:37:10 Hans Verkuil wrote: >> Sakari asked me to reply to this old thread... > > He asked me to reply as well :-) > >> On 09/06/13 13:05, Laurent Pinchart wrote: >>> On Thursday 05 Septembe

Re: [PATCH v4.1 3/3] v4l: Add V4L2_BUF_FLAG_TIMESTAMP_SOF and use it

2014-01-31 Thread Laurent Pinchart
Hi Hans, On Thursday 12 December 2013 13:37:10 Hans Verkuil wrote: > Sakari asked me to reply to this old thread... He asked me to reply as well :-) > On 09/06/13 13:05, Laurent Pinchart wrote: > > On Thursday 05 September 2013 19:31:30 Sakari Ailus wrote: > >> On Sat, Aug 31, 2013 at 11:43:18PM

Re: [PATCH v4.1 3/3] v4l: Add V4L2_BUF_FLAG_TIMESTAMP_SOF and use it

2013-12-12 Thread Hans Verkuil
Sakari asked me to reply to this old thread... On 09/06/13 13:05, Laurent Pinchart wrote: > Hi Sakari, > > On Thursday 05 September 2013 19:31:30 Sakari Ailus wrote: >> On Sat, Aug 31, 2013 at 11:43:18PM +0200, Laurent Pinchart wrote: >>> On Friday 30 August 2013 19:08:48 Sakari Ailus wrote:

Re: [PATCH v4.1 3/3] v4l: Add V4L2_BUF_FLAG_TIMESTAMP_SOF and use it

2013-09-06 Thread Laurent Pinchart
Hi Sakari, On Thursday 05 September 2013 19:31:30 Sakari Ailus wrote: > On Sat, Aug 31, 2013 at 11:43:18PM +0200, Laurent Pinchart wrote: > > On Friday 30 August 2013 19:08:48 Sakari Ailus wrote: > > > On Fri, Aug 30, 2013 at 01:31:44PM +0200, Laurent Pinchart wrote: > > > > On Thursday 29 August

Re: [PATCH v4.1 3/3] v4l: Add V4L2_BUF_FLAG_TIMESTAMP_SOF and use it

2013-09-05 Thread Sakari Ailus
Hi Laurent, On Sat, Aug 31, 2013 at 11:43:18PM +0200, Laurent Pinchart wrote: > Hi Sakari, > > On Friday 30 August 2013 19:08:48 Sakari Ailus wrote: > > On Fri, Aug 30, 2013 at 01:31:44PM +0200, Laurent Pinchart wrote: > > > On Thursday 29 August 2013 14:33:39 Sakari Ailus wrote: > > > > On Thu,

Re: [PATCH v4.1 3/3] v4l: Add V4L2_BUF_FLAG_TIMESTAMP_SOF and use it

2013-08-31 Thread Laurent Pinchart
Hi Sakari, On Friday 30 August 2013 19:08:48 Sakari Ailus wrote: > On Fri, Aug 30, 2013 at 01:31:44PM +0200, Laurent Pinchart wrote: > > On Thursday 29 August 2013 14:33:39 Sakari Ailus wrote: > > > On Thu, Aug 29, 2013 at 01:25:05AM +0200, Laurent Pinchart wrote: > > > > On Wednesday 28 August 20

Re: [PATCH v4.1 3/3] v4l: Add V4L2_BUF_FLAG_TIMESTAMP_SOF and use it

2013-08-30 Thread Sakari Ailus
Hi Laurent, On Fri, Aug 30, 2013 at 01:31:44PM +0200, Laurent Pinchart wrote: > Hi Sakari, > > On Thursday 29 August 2013 14:33:39 Sakari Ailus wrote: > > On Thu, Aug 29, 2013 at 01:25:05AM +0200, Laurent Pinchart wrote: > > > On Wednesday 28 August 2013 19:39:19 Sakari Ailus wrote: > > > > On We

Re: [PATCH v4.1 3/3] v4l: Add V4L2_BUF_FLAG_TIMESTAMP_SOF and use it

2013-08-30 Thread Laurent Pinchart
Hi Sakari, On Thursday 29 August 2013 14:33:39 Sakari Ailus wrote: > On Thu, Aug 29, 2013 at 01:25:05AM +0200, Laurent Pinchart wrote: > > On Wednesday 28 August 2013 19:39:19 Sakari Ailus wrote: > > > On Wed, Aug 28, 2013 at 06:14:44PM +0200, Laurent Pinchart wrote: > > > ... > > > > > > > > > U

Re: [PATCH v4.1 3/3] v4l: Add V4L2_BUF_FLAG_TIMESTAMP_SOF and use it

2013-08-29 Thread Sakari Ailus
Hi Laurent, On Thu, Aug 29, 2013 at 01:25:05AM +0200, Laurent Pinchart wrote: > Hi Sakari, > > On Wednesday 28 August 2013 19:39:19 Sakari Ailus wrote: > > On Wed, Aug 28, 2013 at 06:14:44PM +0200, Laurent Pinchart wrote: > > ... > > > > > > > > diff --git a/drivers/media/usb/uvc/uvc_queue.c > >

Re: [PATCH v4.1 3/3] v4l: Add V4L2_BUF_FLAG_TIMESTAMP_SOF and use it

2013-08-28 Thread Laurent Pinchart
Hi Sakari, On Wednesday 28 August 2013 19:39:19 Sakari Ailus wrote: > On Wed, Aug 28, 2013 at 06:14:44PM +0200, Laurent Pinchart wrote: > ... > > > > > > diff --git a/drivers/media/usb/uvc/uvc_queue.c > > > > > b/drivers/media/usb/uvc/uvc_queue.c index cd962be..0d80512 100644 > > > > > --- a/driv

Re: [PATCH v4.1 3/3] v4l: Add V4L2_BUF_FLAG_TIMESTAMP_SOF and use it

2013-08-28 Thread Sakari Ailus
Hi Laurent, On Wed, Aug 28, 2013 at 06:14:44PM +0200, Laurent Pinchart wrote: ... > > > > diff --git a/drivers/media/usb/uvc/uvc_queue.c > > > > b/drivers/media/usb/uvc/uvc_queue.c index cd962be..0d80512 100644 > > > > --- a/drivers/media/usb/uvc/uvc_queue.c > > > > +++ b/drivers/media/usb/uvc/uvc

Re: [PATCH v4.1 3/3] v4l: Add V4L2_BUF_FLAG_TIMESTAMP_SOF and use it

2013-08-28 Thread Laurent Pinchart
On Wednesday 28 August 2013 19:09:23 Sakari Ailus wrote: > Hi Laurent, > > Thanks for the comments! > > On Wed, Aug 28, 2013 at 06:03:20PM +0200, Laurent Pinchart wrote: > > Hi Sakari, > > > > Thank you for the patches. > > > > On Wednesday 28 August 2013 18:24:55 Sakari Ailus wrote: > > > Some

Re: [PATCH v4.1 3/3] v4l: Add V4L2_BUF_FLAG_TIMESTAMP_SOF and use it

2013-08-28 Thread Sakari Ailus
Hi Laurent, Thanks for the comments! On Wed, Aug 28, 2013 at 06:03:20PM +0200, Laurent Pinchart wrote: > Hi Sakari, > > Thank you for the patches. > > On Wednesday 28 August 2013 18:24:55 Sakari Ailus wrote: > > Some devices such as the uvc produce timestamps at the beginning of the > > frame r

Re: [PATCH v4.1 3/3] v4l: Add V4L2_BUF_FLAG_TIMESTAMP_SOF and use it

2013-08-28 Thread Sakari Ailus
Hi Hans, Thanks for your prompt comments. On Wed, Aug 28, 2013 at 05:30:01PM +0200, Hans Verkuil wrote: > On 08/28/2013 05:24 PM, Sakari Ailus wrote: > > Some devices such as the uvc produce timestamps at the beginning of the > > frame rather than at the end of it. Add a buffer flag > > (V4L2_BUF

Re: [PATCH v4.1 3/3] v4l: Add V4L2_BUF_FLAG_TIMESTAMP_SOF and use it

2013-08-28 Thread Laurent Pinchart
Hi Sakari, Thank you for the patches. On Wednesday 28 August 2013 18:24:55 Sakari Ailus wrote: > Some devices such as the uvc produce timestamps at the beginning of the > frame rather than at the end of it. Add a buffer flag > (V4L2_BUF_FLAG_TIMESTAMP_SOF) to tell about this. > > Also document t

Re: [PATCH v4.1 3/3] v4l: Add V4L2_BUF_FLAG_TIMESTAMP_SOF and use it

2013-08-28 Thread Hans Verkuil
On 08/28/2013 05:24 PM, Sakari Ailus wrote: > Some devices such as the uvc produce timestamps at the beginning of the > frame rather than at the end of it. Add a buffer flag > (V4L2_BUF_FLAG_TIMESTAMP_SOF) to tell about this. > > Also document timestamp_type in struct vb2_queue, and make the uvc s

[PATCH v4.1 3/3] v4l: Add V4L2_BUF_FLAG_TIMESTAMP_SOF and use it

2013-08-28 Thread Sakari Ailus
Some devices such as the uvc produce timestamps at the beginning of the frame rather than at the end of it. Add a buffer flag (V4L2_BUF_FLAG_TIMESTAMP_SOF) to tell about this. Also document timestamp_type in struct vb2_queue, and make the uvc set the buffer flag. Signed-off-by: Sakari Ailus ---