Re: [PATCH v4] venus: venc: Fix enum frameintervals

2019-10-17 Thread Loic Poulain
Hi Stanimir, On Thu, 17 Oct 2019 at 17:47, Stanimir Varbanov wrote: > > Hi Loic, > > On 10/17/19 6:08 PM, Loic Poulain wrote: > > Hi Stanimir, > > > > On Thu, 3 Oct 2019 at 12:15, Stanimir Varbanov > > wrote: > >> > >> I have tested this on db410c with following gst pipeline: > >> > >> gst-launc

Re: [PATCH v4] venus: venc: Fix enum frameintervals

2019-10-17 Thread Stanimir Varbanov
Hi Loic, On 10/17/19 6:08 PM, Loic Poulain wrote: > Hi Stanimir, > > On Thu, 3 Oct 2019 at 12:15, Stanimir Varbanov > wrote: >> >> I have tested this on db410c with following gst pipeline: >> >> gst-launch-1.0 -v videotestsrc ! >> video/x-raw,format=NV12,width=1280,height=960,framerate=24/1 ! >>

Re: [PATCH v4] venus: venc: Fix enum frameintervals

2019-10-17 Thread Loic Poulain
Hi Stanimir, On Thu, 3 Oct 2019 at 12:15, Stanimir Varbanov wrote: > > I have tested this on db410c with following gst pipeline: > > gst-launch-1.0 -v videotestsrc ! > video/x-raw,format=NV12,width=1280,height=960,framerate=24/1 ! > v4l2h264enc > extra-controls="controls,h264_profile=4,h264_level

Re: [PATCH v4] venus: venc: Fix enum frameintervals

2019-10-04 Thread Mauro Carvalho Chehab
Em Thu, 3 Oct 2019 13:10:38 +0300 Stanimir Varbanov escreveu: > This fixes an issue when setting the encoder framerate because of > missing precision. Now the frameinterval type is changed to > TYPE_CONTINUOUS and step = 1. Also the math is changed when > framerate property is called - the firmw

Re: [PATCH v4] venus: venc: Fix enum frameintervals

2019-10-03 Thread Stanimir Varbanov
I have tested this on db410c with following gst pipeline: gst-launch-1.0 -v videotestsrc ! video/x-raw,format=NV12,width=1280,height=960,framerate=24/1 ! v4l2h264enc extra-controls="controls,h264_profile=4,h264_level="5",video_bitrate=1000;" ! filesink location=gstenc.h264 Loic, could you giv

[PATCH v4] venus: venc: Fix enum frameintervals

2019-10-03 Thread Stanimir Varbanov
This fixes an issue when setting the encoder framerate because of missing precision. Now the frameinterval type is changed to TYPE_CONTINUOUS and step = 1. Also the math is changed when framerate property is called - the firmware side expects the framerate in Q16 values. Signed-off-by: Stanimir Va