Re: [PATCH v4] media: vimc: Add vimc-streamer for stream control

2019-02-07 Thread Lucas Magalhães
Hi Hans, > > frame_size is set, but not used: > > vimc-sensor.c:208:15: warning: variable 'frame_size' set but not used > [-Wunused-but-set-variable] > > Can you make a patch fixing this? > > I'm not sure how I missed this sparse warning, weird. Sorry about that. I will be more careful next time

Re: [PATCH v4] media: vimc: Add vimc-streamer for stream control

2019-02-07 Thread Hans Verkuil
Hi Lucas, On 1/22/19 2:05 AM, Lucas A. M. Magalhaes wrote: > Add a linear pipeline logic for the stream control. It's created by > walking backwards on the entity graph. When the stream starts it will > simply loop through the pipeline calling the respective process_frame > function of each entity

Re: [PATCH v4] media: vimc: Add vimc-streamer for stream control

2019-01-22 Thread Helen Koike
Hi Lucas, On 1/21/19 11:05 PM, Lucas A. M. Magalhaes wrote: > Add a linear pipeline logic for the stream control. It's created by > walking backwards on the entity graph. When the stream starts it will > simply loop through the pipeline calling the respective process_frame > function of each entit

[PATCH v4] media: vimc: Add vimc-streamer for stream control

2019-01-21 Thread Lucas A. M. Magalhaes
Add a linear pipeline logic for the stream control. It's created by walking backwards on the entity graph. When the stream starts it will simply loop through the pipeline calling the respective process_frame function of each entity. Fixes: f2fe89061d797 ("vimc: Virtual Media Controller core, captu