Re: [PATCH v3 3/9] media: venus: adding core part and helper functions

Hi Hans, On 11/14/2016 12:25 PM, Hans Verkuil wrote: > On 11/14/2016 11:11 AM, Stanimir Varbanov wrote: >> Hi Hans, >> >> >> > >> +void vidc_vb2_stop_streaming(struct vb2_queue *q) >> +{ >> +struct venus_inst *inst = vb2_get_drv_priv(q); >> +struct venus_core *

Re: [PATCH v3 3/9] media: venus: adding core part and helper functions

On 11/14/2016 11:11 AM, Stanimir Varbanov wrote: > Hi Hans, > > > > +void vidc_vb2_stop_streaming(struct vb2_queue *q) > +{ > + struct venus_inst *inst = vb2_get_drv_priv(q); > + struct venus_core *core = inst->core; > + struct device *dev = core->dev; > + struct vb2

Re: [PATCH v3 3/9] media: venus: adding core part and helper functions

Hi Hans, >>> +void vidc_vb2_stop_streaming(struct vb2_queue *q) +{ + struct venus_inst *inst = vb2_get_drv_priv(q); + struct venus_core *core = inst->core; + struct device *dev = core->dev; + struct vb2_queue *other_queue; + struct vidc_buffer *buf, *n; >>

Re: [PATCH v3 3/9] media: venus: adding core part and helper functions

On 11/14/2016 10:42 AM, Stanimir Varbanov wrote: > Hi Hans, > > Thanks for the comments! > > On 11/11/2016 01:32 PM, Hans Verkuil wrote: >> Hi Stanimir, >> >> Some comments: >> >> On 11/07/2016 06:33 PM, Stanimir Varbanov wrote: >>> * core.c has implemented the platform dirver methods, file >>>

Re: [PATCH v3 3/9] media: venus: adding core part and helper functions

Hi Hans, Thanks for the comments! On 11/11/2016 01:32 PM, Hans Verkuil wrote: > Hi Stanimir, > > Some comments: > > On 11/07/2016 06:33 PM, Stanimir Varbanov wrote: >> * core.c has implemented the platform dirver methods, file >> operations and v4l2 registration. >> >> * helpers.c has impleme

Re: [PATCH v3 3/9] media: venus: adding core part and helper functions

On 11/11, Stanimir Varbanov wrote: > On 11/10/2016 11:43 PM, Stephen Boyd wrote: > > > > Should this be ret |= ? Only the last time through the loop will > > there be an error. Or perhaps we should be bailing out early from > > this loop? > > I think that even if unset_buffers fail we need to fre

Re: [PATCH v3 3/9] media: venus: adding core part and helper functions

Hi Stephen, Thanks for the comments! On 11/10/2016 11:43 PM, Stephen Boyd wrote: > On 11/07, Stanimir Varbanov wrote: >> diff --git a/drivers/media/platform/qcom/venus/core.c >> b/drivers/media/platform/qcom/venus/core.c >> new file mode 100644 >> index ..7b14b1f12e20 >> --- /dev/nul

Re: [PATCH v3 3/9] media: venus: adding core part and helper functions

Hi Stanimir, Some comments: On 11/07/2016 06:33 PM, Stanimir Varbanov wrote: > * core.c has implemented the platform dirver methods, file > operations and v4l2 registration. > > * helpers.c has implemented common helper functions for: >- buffer management > >- vb2_ops and functions fo

Re: [PATCH v3 3/9] media: venus: adding core part and helper functions

On 11/07, Stanimir Varbanov wrote: > diff --git a/drivers/media/platform/qcom/venus/core.c > b/drivers/media/platform/qcom/venus/core.c > new file mode 100644 > index ..7b14b1f12e20 > --- /dev/null > +++ b/drivers/media/platform/qcom/venus/core.c > @@ -0,0 +1,557 @@ > +/* > + * Copyrig

[PATCH v3 3/9] media: venus: adding core part and helper functions

* core.c has implemented the platform dirver methods, file operations and v4l2 registration. * helpers.c has implemented common helper functions for: - buffer management - vb2_ops and functions for format propagation, - functions for allocating and freeing buffers for internal usag