Re: [PATCH v3 08/10] v4l: fdp1: Rewrite format setting code

2016-09-11 Thread Kieran Bingham
I've gone through this one as well, and certainly seems like some much better approaches in there. I can't find anything to fault it. Acked-by: Kieran Bingham Reviewed-by: Kieran Bingham Thanks again, Kieran On 07/09/16 23:25, Laurent Pinchart wrote: > The handling of the TRY_FMT and S_FMT i

[PATCH v3 08/10] v4l: fdp1: Rewrite format setting code

2016-09-07 Thread Laurent Pinchart
The handling of the TRY_FMT and S_FMT ioctls isn't correct. In particular, the sink format isn't propagated to the source format automatically, the strides are not computed when the device is opened, and the colorspace handling is wrong. Rewrite the implementation. Signed-off-by: Laurent Pinchart