Re: [PATCH v3 0/9] Qualcomm video decoder/encoder driver

On 11/14/2016 03:59 PM, Stanimir Varbanov wrote: > Hi, > > On 11/11/2016 02:11 PM, Javier Martinez Canillas wrote: >> Hello Hans, >> >> On Fri, Nov 11, 2016 at 8:49 AM, Hans Verkuil wrote: >>> Hi Stanimir, >>> >>> Overall it looks good. As you saw, I do have some comments but nothing >>> major.

Re: [PATCH v3 0/9] Qualcomm video decoder/encoder driver

Hi, On 11/11/2016 02:11 PM, Javier Martinez Canillas wrote: > Hello Hans, > > On Fri, Nov 11, 2016 at 8:49 AM, Hans Verkuil wrote: >> Hi Stanimir, >> >> Overall it looks good. As you saw, I do have some comments but nothing major. >> >> One question: you use qcom as the directory name. How about

Re: [PATCH v3 0/9] Qualcomm video decoder/encoder driver

Hello Hans, On Fri, Nov 11, 2016 at 8:49 AM, Hans Verkuil wrote: > Hi Stanimir, > > Overall it looks good. As you saw, I do have some comments but nothing major. > > One question: you use qcom as the directory name. How about using qualcomm? > > It's really not that much longer and a bit more obv

Re: [PATCH v3 0/9] Qualcomm video decoder/encoder driver

Hi Stanimir, Overall it looks good. As you saw, I do have some comments but nothing major. One question: you use qcom as the directory name. How about using qualcomm? It's really not that much longer and a bit more obvious. Up to you, though. Regards, Hans On 11/07/2016 06:33 PM, Sta

[PATCH v3 0/9] Qualcomm video decoder/encoder driver

Hi, Here is v3 of the Venus v4l2 video encoder/decoder driver. The changes since v2 are: - return queued buffers on stream_on error. - changed name of the driver vidc -> venus and reflect that in querycap. - fix video_device::release to point to video_device_release.