Re: [PATCH v2 2/5] media: vimc: cleanup code that assigns entity in entities array

2019-10-03 Thread Helen Koike
On 10/3/19 7:44 AM, Dafna Hirschfeld wrote: > Since the add callback returns NULL on failure and the array > is initialized to NULLs, there is no need for the intermediate > assignment to local var. > > Signed-off-by: Dafna Hirschfeld I would just rename the title to something like: "media: v

[PATCH v2 2/5] media: vimc: cleanup code that assigns entity in entities array

2019-10-03 Thread Dafna Hirschfeld
Since the add callback returns NULL on failure and the array is initialized to NULLs, there is no need for the intermediate assignment to local var. Signed-off-by: Dafna Hirschfeld --- drivers/media/platform/vimc/vimc-core.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git