Re: [PATCH v2 13/13] media: imx274: add SELECTION support for cropping

2018-04-26 Thread Luca Ceresoli
Hi Sakari, thanks for your feedback, see below my replies. On 26/04/2018 10:13, Sakari Ailus wrote: > Hi Luca, > > On Tue, Apr 24, 2018 at 04:30:38PM +0200, Luca Ceresoli wrote: >> Hi Sakari, >> >> On 24/04/2018 11:59, Sakari Ailus wrote: >>> Hi Luca, >>> >>> Thank you for the patchset. >>> >>>

Re: [PATCH v2 13/13] media: imx274: add SELECTION support for cropping

2018-04-26 Thread Sakari Ailus
Hi Luca, On Tue, Apr 24, 2018 at 04:30:38PM +0200, Luca Ceresoli wrote: > Hi Sakari, > > On 24/04/2018 11:59, Sakari Ailus wrote: > > Hi Luca, > > > > Thank you for the patchset. > > > > Some comments below... what I propose is that I apply the rest of the > > patches and then the comments to t

Re: [PATCH v2 13/13] media: imx274: add SELECTION support for cropping

2018-04-24 Thread Luca Ceresoli
Hi Sakari, On 24/04/2018 11:59, Sakari Ailus wrote: > Hi Luca, > > Thank you for the patchset. > > Some comments below... what I propose is that I apply the rest of the > patches and then the comments to this one could be addressed separately. > Would that work for you? Yes, but I suggest you o

Re: [PATCH v2 13/13] media: imx274: add SELECTION support for cropping

2018-04-24 Thread Sakari Ailus
Hi Luca, Thank you for the patchset. Some comments below... what I propose is that I apply the rest of the patches and then the comments to this one could be addressed separately. Would that work for you? On Tue, Apr 24, 2018 at 10:24:18AM +0200, Luca Ceresoli wrote: > Currently this driver does

[PATCH v2 13/13] media: imx274: add SELECTION support for cropping

2018-04-24 Thread Luca Ceresoli
Currently this driver does not support cropping. The supported modes are the following, all capturing the entire area: - 3840x2160, 1:1 binning (native sensor resolution) - 1920x1080, 2:1 binning - 1280x720, 3:1 binning The set_fmt callback chooses among these 3 configurations the one that ma