Re: [PATCH v2 0/8] Qualcomm video decoder/encoder driver

2016-09-19 Thread Hans Verkuil
Hi Stanimir, I've finished my review of this patch series. I'll be traveling for the next three weeks, so you can take your time with making a v3 since it is very unlikely I'll be able to review it before I'm back mid-October. Thanks for working on this! Regards, Hans On 09/07/2016 01

Re: [PATCH v2 0/8] Qualcomm video decoder/encoder driver

2016-09-07 Thread Hans Verkuil
One thing you need to add is a patch for the MAINTAINERS file. It needs an entry for this new driver. I think pretty much all new drivers I've reviewed recently forgot to update that file :-( Regards, Hans On 09/07/16 13:37, Stanimir Varbanov wrote: Changes since v1: - s/ENOTSUPP/EI

[PATCH v2 0/8] Qualcomm video decoder/encoder driver

2016-09-07 Thread Stanimir Varbanov
Changes since v1: - s/ENOTSUPP/EINVAL in vidc_set_color_format() - use video_device_alloc - fill struct device pointer in vb2_queue_init instead of .setup_queue - fill device_caps in struct video_device instead of .vidioc_querycap - fill colorspace, ycbcr_enc, quantization and xfer_func o