Re: [PATCH v2] V4L2: avoid name conflicts in macros

2010-08-14 Thread Andy Walls
On Thu, 2010-08-12 at 22:16 +0200, Guennadi Liakhovetski wrote: > "sd" and "err" are too common names to be used in macros for local variables. > Prefix them with an underscore to avoid name clashing. > > Signed-off-by: Guennadi Liakhovetski I've reviewed these but not tetsed them. The function

Re: [PATCH v2] V4L2: avoid name conflicts in macros

2010-08-13 Thread lawrence rust
On Thu, 2010-08-12 at 22:16 +0200, Guennadi Liakhovetski wrote: > "sd" and "err" are too common names to be used in macros for local variables. > Prefix them with an underscore to avoid name clashing. Identifiers that begin with a double underscore (as you have used) are reserved for standard head

[PATCH v2] V4L2: avoid name conflicts in macros

2010-08-12 Thread Guennadi Liakhovetski
"sd" and "err" are too common names to be used in macros for local variables. Prefix them with an underscore to avoid name clashing. Signed-off-by: Guennadi Liakhovetski --- v2: as suggested by Mauro, also patched v4l2_device_call_all and v4l2_device_call_until_err, as well as ivtv and cx18 sp