Re: [PATCH v2] Input: Add missing event codes for common IR remote buttons

2019-01-24 Thread VDR User
> > > KEY_ASPECT_RATIO (formerly KEY_SCREEN). > > > > Physical displays have a single set aspect ratio (W/H). Images have > > their own aspect ratios. When the AR of the video to be display and > > the display itself are mismatched, you have to do something > > (letterbox, pillarbox, windowbox) to

Re: [PATCH v2] Input: Add missing event codes for common IR remote buttons

2019-01-24 Thread Dmitry Torokhov
On Tue, Jan 22, 2019 at 11:50:50PM -0800, VDR User wrote: > > > > > > KEY_DISPLAY_FORMAT doesn't open any menus and is used to cycle through > > > how video is displayed on-screen to the user; full, zoomed, > > > letterboxed, stretched, etc. KEY_CONTEXT_MENU would be for something > > > like bringi

Re: [PATCH v2] Input: Add missing event codes for common IR remote buttons

2019-01-23 Thread VDR User
Hi Bastian, > > There are multiple MENU keys I assume for clarity purposes and to > > give > > some kind of relation between the key definition and the action/event > > that occurs when you use it. I would say it's more a matter of > > convenience rather that need, similar to KEY_ROOT_MENU & > > K

Re: [PATCH v2] Input: Add missing event codes for common IR remote buttons

2019-01-23 Thread Bastien Nocera
On Tue, 2019-01-22 at 23:50 -0800, VDR User wrote: > > > KEY_SCREEN_INPUT is used to bring up things like an on-screen > > > keyboard or other on-onscreen user input method. > > > > We already have KEY_ONSCREEN_KEYBOARD. > > > > > > > +#define KEY_SYSTEM_MENU 0x2ed /* Open

Re: [PATCH v2] Input: Add missing event codes for common IR remote buttons

2019-01-22 Thread VDR User
Hi Dmitry, thanks for replying. Notes follow.. > > > > +/* Remote control buttons found across provider & universal remotes */ > > > > +#define KEY_LIVE_TV 0x2e8 /* Jump to live tv > > > > viewing */ > > > > > > KEY_TV? > > > > KEY_TV selects TV as a *input source* the same as

Re: [PATCH v2] Input: Add missing event codes for common IR remote buttons

2019-01-19 Thread Dmitry Torokhov
Hi Derek, On Tue, Nov 13, 2018 at 08:20:22AM -0800, VDR User wrote: > > On Sat, 2018-11-03 at 07:55 -0700, Derek Kelly wrote: > > > The following patch adds event codes for common buttons found on > > > various > > > provider and universal remote controls. They represent functions not > > > covere

Re: [PATCH v2] Input: Add missing event codes for common IR remote buttons

2018-11-13 Thread VDR User
> On Sat, 2018-11-03 at 07:55 -0700, Derek Kelly wrote: > > The following patch adds event codes for common buttons found on > > various > > provider and universal remote controls. They represent functions not > > covered by existing event codes. Once added, rc_keymaps can be > > updated > > accord

Re: [PATCH v2] Input: Add missing event codes for common IR remote buttons

2018-11-13 Thread Bastien Nocera
On Sat, 2018-11-03 at 07:55 -0700, Derek Kelly wrote: > The following patch adds event codes for common buttons found on > various > provider and universal remote controls. They represent functions not > covered by existing event codes. Once added, rc_keymaps can be > updated > accordingly where ap

Re: [PATCH v2] Input: Add missing event codes for common IR remote buttons

2018-11-05 Thread Sean Young
On Sat, Nov 03, 2018 at 07:55:32AM -0700, Derek Kelly wrote: > The following patch adds event codes for common buttons found on various > provider and universal remote controls. They represent functions not > covered by existing event codes. Once added, rc_keymaps can be updated > accordingly where

[PATCH v2] Input: Add missing event codes for common IR remote buttons

2018-11-03 Thread Derek Kelly
The following patch adds event codes for common buttons found on various provider and universal remote controls. They represent functions not covered by existing event codes. Once added, rc_keymaps can be updated accordingly where applicable. v2 changes: Renamed KEY_SYSTEM to KEY_SYSTEM_MENU to av