Re: [PATCH v12 18/26] v4l: fwnode: Add a helper function for parsing generic references

2017-09-15 Thread Sakari Ailus
Hi Hans, On Wed, Sep 13, 2017 at 12:32:17PM +0200, Hans Verkuil wrote: > On 09/13/17 12:07, Sakari Ailus wrote: > > Hi Hans, > > > > On Wed, Sep 13, 2017 at 11:28:44AM +0200, Hans Verkuil wrote: > >> On 09/13/17 11:24, Sakari Ailus wrote: > >>> Hi Hans, > >>> > >>> Thanks for the review! > >>> >

Re: [PATCH v12 18/26] v4l: fwnode: Add a helper function for parsing generic references

2017-09-13 Thread Hans Verkuil
On 09/13/17 12:07, Sakari Ailus wrote: > Hi Hans, > > On Wed, Sep 13, 2017 at 11:28:44AM +0200, Hans Verkuil wrote: >> On 09/13/17 11:24, Sakari Ailus wrote: >>> Hi Hans, >>> >>> Thanks for the review! >>> >>> On Wed, Sep 13, 2017 at 09:27:34AM +0200, Hans Verkuil wrote: On 09/12/2017 03:41 P

Re: [PATCH v12 18/26] v4l: fwnode: Add a helper function for parsing generic references

2017-09-13 Thread Sakari Ailus
Hi Hans, On Wed, Sep 13, 2017 at 11:28:44AM +0200, Hans Verkuil wrote: > On 09/13/17 11:24, Sakari Ailus wrote: > > Hi Hans, > > > > Thanks for the review! > > > > On Wed, Sep 13, 2017 at 09:27:34AM +0200, Hans Verkuil wrote: > >> On 09/12/2017 03:41 PM, Sakari Ailus wrote: > >>> Add function v4

Re: [PATCH v12 18/26] v4l: fwnode: Add a helper function for parsing generic references

2017-09-13 Thread Hans Verkuil
On 09/13/17 11:24, Sakari Ailus wrote: > Hi Hans, > > Thanks for the review! > > On Wed, Sep 13, 2017 at 09:27:34AM +0200, Hans Verkuil wrote: >> On 09/12/2017 03:41 PM, Sakari Ailus wrote: >>> Add function v4l2_fwnode_reference_count() for counting external >> >> There is no function v4l2_f

Re: [PATCH v12 18/26] v4l: fwnode: Add a helper function for parsing generic references

2017-09-13 Thread Sakari Ailus
Hi Hans, Thanks for the review! On Wed, Sep 13, 2017 at 09:27:34AM +0200, Hans Verkuil wrote: > On 09/12/2017 03:41 PM, Sakari Ailus wrote: > > Add function v4l2_fwnode_reference_count() for counting external > > There is no function v4l2_fwnode_reference_count()?! It got removed during th

Re: [PATCH v12 18/26] v4l: fwnode: Add a helper function for parsing generic references

2017-09-13 Thread Hans Verkuil
On 09/12/2017 03:41 PM, Sakari Ailus wrote: > Add function v4l2_fwnode_reference_count() for counting external There is no function v4l2_fwnode_reference_count()?! > references and v4l2_fwnode_reference_parse() for parsing them as async > sub-devices. > > This can be done on e.g. flash or l

[PATCH v12 18/26] v4l: fwnode: Add a helper function for parsing generic references

2017-09-12 Thread Sakari Ailus
Add function v4l2_fwnode_reference_count() for counting external references and v4l2_fwnode_reference_parse() for parsing them as async sub-devices. This can be done on e.g. flash or lens async sub-devices that are not part of but are associated with a sensor. struct v4l2_async_notifier.max_subde