Re: [PATCH v1.2 1/1] omap3isp: Skip CSI-2 receiver initialisation in CCP2 configuration

2017-08-14 Thread Sakari Ailus
On Mon, Aug 14, 2017 at 04:33:39PM +0300, Laurent Pinchart wrote: > Hi Sakari, > > On Monday 14 Aug 2017 13:53:27 Sakari Ailus wrote: > > On Fri, Aug 11, 2017 at 02:32:00PM +0300, Laurent Pinchart wrote: > > > On Friday 11 Aug 2017 12:57:09 Sakari Ailus wrote: > > >> If the CSI-2 receiver isn't pa

Re: [PATCH v1.2 1/1] omap3isp: Skip CSI-2 receiver initialisation in CCP2 configuration

2017-08-14 Thread Laurent Pinchart
Hi Sakari, On Monday 14 Aug 2017 13:53:27 Sakari Ailus wrote: > On Fri, Aug 11, 2017 at 02:32:00PM +0300, Laurent Pinchart wrote: > > On Friday 11 Aug 2017 12:57:09 Sakari Ailus wrote: > >> If the CSI-2 receiver isn't part of the pipeline (or isn't there to > >> begin with), skip its initialisatio

Re: [PATCH v1.2 1/1] omap3isp: Skip CSI-2 receiver initialisation in CCP2 configuration

2017-08-14 Thread Sakari Ailus
On Fri, Aug 11, 2017 at 02:32:00PM +0300, Laurent Pinchart wrote: > > + if (!pipe) > > + return -EBUSY; > > When can this happen ? And this test should be for phy->entity instead. -- Sakari Ailus e-mail: sakari.ai...@iki.fi

Re: [PATCH v1.2 1/1] omap3isp: Skip CSI-2 receiver initialisation in CCP2 configuration

2017-08-14 Thread Sakari Ailus
Hi Laurent, On Fri, Aug 11, 2017 at 02:32:00PM +0300, Laurent Pinchart wrote: > Hi Sakari, > > Thank you for the patch. > > On Friday 11 Aug 2017 12:57:09 Sakari Ailus wrote: > > If the CSI-2 receiver isn't part of the pipeline (or isn't there to begin > > with), skip its initialisation. > > I

Re: [PATCH v1.2 1/1] omap3isp: Skip CSI-2 receiver initialisation in CCP2 configuration

2017-08-11 Thread Sakari Ailus
Hi Pavel, On Fri, Aug 11, 2017 at 12:46:05PM +0200, Pavel Machek wrote: > On Fri 2017-08-11 12:57:09, Sakari Ailus wrote: > > If the CSI-2 receiver isn't part of the pipeline (or isn't there to begin > > with), skip its initialisation. > > > > Signed-off-by: Sakari Ailus > > Tested-by: Laurent P

Re: [PATCH v1.2 1/1] omap3isp: Skip CSI-2 receiver initialisation in CCP2 configuration

2017-08-11 Thread Laurent Pinchart
Hi Sakari, Thank you for the patch. On Friday 11 Aug 2017 12:57:09 Sakari Ailus wrote: > If the CSI-2 receiver isn't part of the pipeline (or isn't there to begin > with), skip its initialisation. I don't think the commit message really describes the patch. > Signed-off-by: Sakari Ailus > Test

Re: [PATCH v1.2 1/1] omap3isp: Skip CSI-2 receiver initialisation in CCP2 configuration

2017-08-11 Thread Pavel Machek
On Fri 2017-08-11 12:57:09, Sakari Ailus wrote: > If the CSI-2 receiver isn't part of the pipeline (or isn't there to begin > with), skip its initialisation. > > Signed-off-by: Sakari Ailus > Tested-by: Laurent Pinchart # on > Beagleboard-xM + MPT9P031 > Acked-by: Pavel Machek Tested-by: Pave

[PATCH v1.2 1/1] omap3isp: Skip CSI-2 receiver initialisation in CCP2 configuration

2017-08-11 Thread Sakari Ailus
If the CSI-2 receiver isn't part of the pipeline (or isn't there to begin with), skip its initialisation. Signed-off-by: Sakari Ailus Tested-by: Laurent Pinchart # on Beagleboard-xM + MPT9P031 Acked-by: Pavel Machek --- since v1.1: - Assign phy->entity before calling omap3isp_csiphy_config(),