Re: [PATCH v1 16/19] v4l: Add encoding camera controls.

2013-11-10 Thread Laurent Pinchart
Hi Pawel, Thank you for the patch. On Friday 30 August 2013 11:17:15 Pawel Osciak wrote: > Add defines for controls found in UVC 1.5 encoding cameras. In addition to the comments already sent by Hans, Kamil and Sylwester, I'll just point out that documentation is needed. > Signed-off-by: Pawel

Re: [PATCH v1 16/19] v4l: Add encoding camera controls.

2013-09-11 Thread Hans Verkuil
Hi Pawel, On 09/12/2013 03:10 AM, Pawel Osciak wrote: > On Tue, Sep 10, 2013 at 6:17 PM, Hans Verkuil wrote: >> On Mon 9 September 2013 11:09:57 Sylwester Nawrocki wrote: >>> On 09/09/2013 11:00 AM, Kamil Debski wrote: >>> [...] >>> We have QP controls separately for H264, H263 and MPEG4. Why

Re: [PATCH v1 16/19] v4l: Add encoding camera controls.

2013-09-11 Thread Pawel Osciak
On Tue, Sep 10, 2013 at 6:17 PM, Hans Verkuil wrote: > On Mon 9 September 2013 11:09:57 Sylwester Nawrocki wrote: >> On 09/09/2013 11:00 AM, Kamil Debski wrote: >> [...] >> We have QP controls separately for H264, H263 and MPEG4. Why is that? >> Which one should I use for VP8? Shouldn't

Re: [PATCH v1 16/19] v4l: Add encoding camera controls.

2013-09-10 Thread Hans Verkuil
On Mon 9 September 2013 11:09:57 Sylwester Nawrocki wrote: > On 09/09/2013 11:00 AM, Kamil Debski wrote: > [...] > We have QP controls separately for H264, H263 and MPEG4. Why is that? > Which one should I use for VP8? Shouldn't we unify them instead? > >>> > >>> I can't quite remember th

Re: [PATCH v1 16/19] v4l: Add encoding camera controls.

2013-09-09 Thread Sylwester Nawrocki
On 09/09/2013 11:00 AM, Kamil Debski wrote: [...] We have QP controls separately for H264, H263 and MPEG4. Why is that? Which one should I use for VP8? Shouldn't we unify them instead? >>> >>> I can't quite remember the details, so I've CCed Kamil since he added >> those controls. >>> At

RE: [PATCH v1 16/19] v4l: Add encoding camera controls.

2013-09-09 Thread Kamil Debski
Hi, > From: Pawel Osciak [mailto:posc...@chromium.org] > Sent: Monday, September 09, 2013 9:59 AM > > On Mon, Sep 9, 2013 at 4:52 PM, Hans Verkuil wrote: > > On 09/09/2013 05:48 AM, Pawel Osciak wrote: > >> Hi Hans, > >> Thanks for the comments, one question inline. > >> > >> On Fri, Aug 30, 201

Re: [PATCH v1 16/19] v4l: Add encoding camera controls.

2013-09-09 Thread Pawel Osciak
On Mon, Sep 9, 2013 at 4:52 PM, Hans Verkuil wrote: > On 09/09/2013 05:48 AM, Pawel Osciak wrote: >> Hi Hans, >> Thanks for the comments, one question inline. >> >> On Fri, Aug 30, 2013 at 3:48 PM, Hans Verkuil wrote: >>> On 08/30/2013 04:17 AM, Pawel Osciak wrote: Add defines for controls f

Re: [PATCH v1 16/19] v4l: Add encoding camera controls.

2013-09-09 Thread Hans Verkuil
On 09/09/2013 05:48 AM, Pawel Osciak wrote: > Hi Hans, > Thanks for the comments, one question inline. > > On Fri, Aug 30, 2013 at 3:48 PM, Hans Verkuil wrote: >> On 08/30/2013 04:17 AM, Pawel Osciak wrote: >>> Add defines for controls found in UVC 1.5 encoding cameras. >>> >>> Signed-off-by: Paw

Re: [PATCH v1 16/19] v4l: Add encoding camera controls.

2013-09-08 Thread Pawel Osciak
Hi Hans, Thanks for the comments, one question inline. On Fri, Aug 30, 2013 at 3:48 PM, Hans Verkuil wrote: > On 08/30/2013 04:17 AM, Pawel Osciak wrote: >> Add defines for controls found in UVC 1.5 encoding cameras. >> >> Signed-off-by: Pawel Osciak >> --- >> drivers/media/v4l2-core/v4l2-ctrls

Re: [PATCH v1 16/19] v4l: Add encoding camera controls.

2013-08-29 Thread Hans Verkuil
On 08/30/2013 04:17 AM, Pawel Osciak wrote: > Add defines for controls found in UVC 1.5 encoding cameras. > > Signed-off-by: Pawel Osciak > --- > drivers/media/v4l2-core/v4l2-ctrls.c | 29 + > include/uapi/linux/v4l2-controls.h | 31 +++ >

[PATCH v1 16/19] v4l: Add encoding camera controls.

2013-08-29 Thread Pawel Osciak
Add defines for controls found in UVC 1.5 encoding cameras. Signed-off-by: Pawel Osciak --- drivers/media/v4l2-core/v4l2-ctrls.c | 29 + include/uapi/linux/v4l2-controls.h | 31 +++ 2 files changed, 60 insertions(+) diff --git a/drivers/